From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EE1CF2034A86B for ; Tue, 31 Oct 2017 20:23:56 -0700 (PDT) Received: by mail-wm0-x241.google.com with SMTP id r68so2448241wmr.3 for ; Tue, 31 Oct 2017 20:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7A0a52UPXzq1ZOEoEoGsxgHJXCOHJYvM5pdskrm3qO4=; b=iu+HWoN6T2ocKfeSBFNAfpDZrCyrVnvMgm2SmMx4AGsJqr5d6Wz2tIZBN8MrZ/d12S 0VCCCMD2kd8FMEBFIeCKU3VutfgYL6U7YRdluROaRAAju/HRNMKd44JqgizUjDjAVqZl dP4MZ5CX3KhdeBJXHzrBUDUc6xk2ODTw5woOE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7A0a52UPXzq1ZOEoEoGsxgHJXCOHJYvM5pdskrm3qO4=; b=Y+9sfsCcsVT5X7HSIo1uTYg1KQkGuRzTw9TjG1I9EOPONUjpmwD+PShlwIZY6aqaii hope65u5xdv1wDyL5LY9CuX+qqEGm2YGt5fqe+QpRWg84OpBLDJN7l/wCm+gn17Tmksb sXBRkCFaTOS2u8Zp24B+77In1fh/uZJKUzA70ns8SgRzp1FbJhcRr5HLXNjEjlcEaUHY KqMDr/2noglHlElLpl+JOCiFZG2Dsr3GRuYUfrZyuj+aogI7ppVV49VxeSliiLQu0Rpr ghcEZ0qi1+qBHOtAwe71Ow1j/BsaxrEA+/dYV4I/udbkuIdSUqf3HM3+DEWz0DZyfR7F yJNQ== X-Gm-Message-State: AMCzsaVDxbcUrE9umWF6pWd4EcVhauTkIsh6mjtZfpXeAqcLUS1/7XaR ok6NbHTP3tWpwoH5d2aGddDygg== X-Google-Smtp-Source: ABhQp+RiKtZcByyCksDYBCxsfxX30g8SzHEAxp/JvjD1XiVGDlVITl4jh9toIZp9v6u9F+B8GXMU8w== X-Received: by 10.28.127.206 with SMTP id a197mr3185831wmd.12.1509506868023; Tue, 31 Oct 2017 20:27:48 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j13sm1304255wrb.18.2017.10.31.20.27.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Oct 2017 20:27:46 -0700 (PDT) Date: Wed, 1 Nov 2017 03:27:45 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171101032745.ggi5b4cha3w4m7yz@bivouac.eciton.net> References: <1509422375-20198-1-git-send-email-mw@semihalf.com> <1509422375-20198-4-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1509422375-20198-4-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 3/6] Marvell/Drivers: MvSpiFlash: Remove duplicated macros X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2017 03:23:57 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 31, 2017 at 04:59:32AM +0100, Marcin Wojtas wrote: > Flash commands macros are already defined locally, so > remove them from the protocol header. Locally? I have no issue with the patch, but the commit message can be a bit more descriptive. / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > --- > Platform/Marvell/Include/Protocol/SpiFlash.h | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/Platform/Marvell/Include/Protocol/SpiFlash.h b/Platform/Marvell/Include/Protocol/SpiFlash.h > index 4a3053e..4ba29ba 100644 > --- a/Platform/Marvell/Include/Protocol/SpiFlash.h > +++ b/Platform/Marvell/Include/Protocol/SpiFlash.h > @@ -36,17 +36,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > #include > > -#define CMD_READ_ID 0x9f > -#define READ_STATUS_REG_CMD 0x0b > -#define CMD_WRITE_ENABLE 0x06 > -#define CMD_FLAG_STATUS 0x70 > -#define CMD_WRITE_STATUS_REG 0x01 > -#define CMD_READ_ARRAY_FAST 0x0b > -#define CMD_PAGE_PROGRAM 0x02 > -#define CMD_BANK_WRITE 0xc5 > -#define CMD_ERASE_64K 0xd8 > -#define CMD_4B_ADDR_ENABLE 0xb7 > - > extern EFI_GUID gMarvellSpiFlashProtocolGuid; > > typedef struct _MARVELL_SPI_FLASH_PROTOCOL MARVELL_SPI_FLASH_PROTOCOL; > -- > 2.7.4 >