From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, graeme.gregory@linaro.org,
daniel.thompson@linaro.org, masami.hiramatsu@linaro.org,
methavanitpong.pipat@socionext.com
Subject: Re: [PATCH edk2-platforms v3 04/27] Silicon/SynQuacer: implement a platform DXE driver
Date: Wed, 1 Nov 2017 04:46:42 +0000 [thread overview]
Message-ID: <20171101044642.rwiwsoapw24yy3fc@bivouac.eciton.net> (raw)
In-Reply-To: <20171031105218.30208-5-ard.biesheuvel@linaro.org>
On Tue, Oct 31, 2017 at 10:51:55AM +0000, Ard Biesheuvel wrote:
> This implements a driver that will take care of platform specific
> initialization, such as declaring non-discoverable devices. For
> the moment, this is limited to declaring the presence of the NETSEC
> controller.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c | 106 ++++++++++++++++++++
> Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf | 52 ++++++++++
> Silicon/Socionext/SynQuacer/SynQuacer.dec | 3 +
> 3 files changed, 161 insertions(+)
>
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> new file mode 100644
> index 000000000000..86e81bc3593c
> --- /dev/null
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> @@ -0,0 +1,106 @@
> +/** @file
> + SynQuacer DXE platform driver.
> +
> + Copyright (c) 2017, Linaro, Ltd. All rights reserved.<BR>
> +
> + This program and the accompanying materials are licensed and made available
> + under the terms and conditions of the BSD License which accompanies this
> + distribution. The full text of the license may be found at
> + http://opensource.org/licenses/bsd-license.php
> +
> + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +**/
> +
> +#include <PiDxe.h>
> +#include <Library/BaseMemoryLib.h>
> +#include <Library/DebugLib.h>
> +#include <Library/MemoryAllocationLib.h>
> +#include <Library/UefiBootServicesTableLib.h>
> +#include <Platform/MemoryMap.h>
> +#include <Protocol/NonDiscoverableDevice.h>
> +
> +STATIC EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR mNetsecDesc[] = {
> + {
> + ACPI_ADDRESS_SPACE_DESCRIPTOR, // Desc
> + sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) - 3, // Len
> + ACPI_ADDRESS_SPACE_TYPE_MEM, // ResType
> + 0, // GenFlag
> + 0, // SpecificFlag
> + 32, // AddrSpaceGranularity
> + SYNQUACER_NETSEC_BASE, // AddrRangeMin
> + SYNQUACER_NETSEC_BASE +
> + SYNQUACER_NETSEC_BASE_SZ - 1, // AddrRangeMax
> + 0, // AddrTranslationOffset
> + SYNQUACER_NETSEC_BASE_SZ, // AddrLen
> + }, {
> + ACPI_ADDRESS_SPACE_DESCRIPTOR, // Desc
> + sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) - 3, // Len
> + ACPI_ADDRESS_SPACE_TYPE_MEM, // ResType
> + 0, // GenFlag
> + 0, // SpecificFlag
> + 32, // AddrSpaceGranularity
> + FixedPcdGet32 (PcdNetsecEepromBase), // AddrRangeMin
> + FixedPcdGet32 (PcdNetsecEepromBase) +
> + SYNQUACER_EEPROM_BASE_SZ - 1, // AddrRangeMax
> + 0, // AddrTranslationOffset
> + SYNQUACER_EEPROM_BASE_SZ, // AddrLen
> + }, {
> + ACPI_ADDRESS_SPACE_DESCRIPTOR, // Desc
> + sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) - 3, // Len
> + ACPI_ADDRESS_SPACE_TYPE_MEM, // ResType
> + 0, // GenFlag
> + 0, // SpecificFlag
> + 32, // AddrSpaceGranularity
> + FixedPcdGet32 (PcdNetsecPhyAddress), // AddrRangeMin
> + FixedPcdGet32 (PcdNetsecPhyAddress), // AddrRangeMax
> + 0, // AddrTranslationOffset
> + 1, // AddrLen
> + }, {
> + ACPI_END_TAG_DESCRIPTOR // Desc
> + }
> +};
> +
> +STATIC
> +EFI_STATUS
> +RegisterNetsec (
> + VOID
> + )
> +{
> + NON_DISCOVERABLE_DEVICE *Device;
> + EFI_STATUS Status;
> + EFI_HANDLE Handle;
> +
> + Device = (NON_DISCOVERABLE_DEVICE *)AllocateZeroPool (sizeof (*Device));
> + if (Device == NULL) {
> + return EFI_OUT_OF_RESOURCES;
> + }
> +
> + Device->Type = &gNetsecNonDiscoverableDeviceGuid;
> + Device->DmaType = NonDiscoverableDeviceDmaTypeNonCoherent;
> + Device->Resources = mNetsecDesc;
> +
> + Handle = NULL;
> + Status = gBS->InstallMultipleProtocolInterfaces (&Handle,
> + &gEdkiiNonDiscoverableDeviceProtocolGuid, Device,
> + NULL);
> + if (EFI_ERROR (Status)) {
> + goto FreeDevice;
> + }
> + return EFI_SUCCESS;
> +
> +FreeDevice:
> + FreePool (Device);
> +
> + return Status;
> +}
> +
> +EFI_STATUS
> +EFIAPI
> +PlatformDxeEntryPoint (
> + IN EFI_HANDLE ImageHandle,
> + IN EFI_SYSTEM_TABLE *SystemTable
> + )
> +{
> + return RegisterNetsec ();
> +}
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> new file mode 100644
> index 000000000000..59a3d1fb47f4
> --- /dev/null
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> @@ -0,0 +1,52 @@
> +## @file
> +#
> +# Component description file for the SynQuacer DXE platform driver.
> +#
> +# Copyright (c) 2017, Linaro, Ltd. All rights reserved.<BR>
> +#
> +# This program and the accompanying materials
> +# are licensed and made available under the terms and conditions of the BSD License
> +# which accompanies this distribution. The full text of the license may be found at
> +# http://opensource.org/licenses/bsd-license.php
> +#
> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +##
> +
> +[Defines]
> + INF_VERSION = 0x0001001A
> + BASE_NAME = PlatformDxe
> + FILE_GUID = ac422cc1-d916-489a-b165-536fdfc633c2
> + MODULE_TYPE = DXE_DRIVER
> + VERSION_STRING = 1.0
> + ENTRY_POINT = PlatformDxeEntryPoint
> +
> +[Sources]
> + PlatformDxe.c
> +
> +[Packages]
> + MdeModulePkg/MdeModulePkg.dec
> + MdePkg/MdePkg.dec
> + Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.dec
> + Silicon/Socionext/SynQuacer/SynQuacer.dec
> +
> +[LibraryClasses]
> + BaseMemoryLib
> + DebugLib
> + MemoryAllocationLib
> + UefiBootServicesTableLib
> + UefiDriverEntryPoint
> +
> +[Guids]
> + gNetsecNonDiscoverableDeviceGuid
> +
> +[Protocols]
> + gEdkiiNonDiscoverableDeviceProtocolGuid ## PRODUCES
> +
> +[FixedPcd]
> + gSynQuacerTokenSpaceGuid.PcdNetsecEepromBase
> + gSynQuacerTokenSpaceGuid.PcdNetsecPhyAddress
> +
> +[Depex]
> + TRUE
> diff --git a/Silicon/Socionext/SynQuacer/SynQuacer.dec b/Silicon/Socionext/SynQuacer/SynQuacer.dec
> index 446be69473fb..80c53b1a7a2d 100644
> --- a/Silicon/Socionext/SynQuacer/SynQuacer.dec
> +++ b/Silicon/Socionext/SynQuacer/SynQuacer.dec
> @@ -30,3 +30,6 @@ [PcdsFixedAtBuild]
>
> gSynQuacerTokenSpaceGuid.PcdSecondaryFvBase|0|UINT64|0x00000002
> gSynQuacerTokenSpaceGuid.PcdSecondaryFvSize|0|UINT64|0x00000003
> +
> + gSynQuacerTokenSpaceGuid.PcdNetsecEepromBase|0|UINT32|0x00000004
> + gSynQuacerTokenSpaceGuid.PcdNetsecPhyAddress|0|UINT8|0x00000005
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-11-01 4:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 10:51 [PATCH edk2-platforms v3 00/27] add support for Socionext Synquacer Ard Biesheuvel
2017-10-31 10:51 ` [PATCH edk2-platforms v3 01/27] Silicon/SynQuacer: add package with platform headers Ard Biesheuvel
2017-10-31 10:51 ` [PATCH edk2-platforms v3 02/27] Silicon/Socionext: add driver for NETSEC network controller Ard Biesheuvel
2017-11-01 4:41 ` Leif Lindholm
2017-10-31 10:51 ` [PATCH edk2-platforms v3 03/27] Silicon/Socionext: add PlatformPeilib implementation for SynQuacer Ard Biesheuvel
2017-11-01 4:44 ` Leif Lindholm
2017-10-31 10:51 ` [PATCH edk2-platforms v3 04/27] Silicon/SynQuacer: implement a platform DXE driver Ard Biesheuvel
2017-11-01 4:46 ` Leif Lindholm [this message]
2017-10-31 10:51 ` [PATCH edk2-platforms v3 05/27] Silicon/SynQuacer: add MemoryInitPeiLib implementation Ard Biesheuvel
2017-11-01 4:49 ` Leif Lindholm
2017-10-31 10:51 ` [PATCH edk2-platforms v3 06/27] Platform: add support for Socionext SynQuacer eval board Ard Biesheuvel
2017-11-01 4:53 ` Leif Lindholm
2017-10-31 10:51 ` [PATCH edk2-platforms v3 07/27] Silicon/SynQuacer: implement PciSegmentLib to support dual RCs Ard Biesheuvel
2017-10-31 10:51 ` [PATCH edk2-platforms v3 08/27] Silicon/SynQuacer: implement PciHostBridgeLib support Ard Biesheuvel
2017-11-01 4:57 ` Leif Lindholm
2017-10-31 10:52 ` [PATCH edk2-platforms v3 09/27] Silicon/SynQuacer: implement EFI_CPU_IO2_PROTOCOL Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 10/27] Platform/SynQuacerEvalBoard: add PCI support Ard Biesheuvel
2017-11-01 4:59 ` Leif Lindholm
2017-10-31 10:52 ` [PATCH edk2-platforms v3 11/27] Platform/SynQuacerEvalBoard: add NETSEC driver Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 12/27] Silicon/SynQuacer: add ACPI support Ard Biesheuvel
2017-11-01 10:15 ` graeme.gregory
2017-11-01 16:36 ` Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 13/27] Silicon/SynQuacer: add device tree support for eval board Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 14/27] Silicon/SynQuacer: add NorFlashPlatformLib implementation Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 15/27] Silicon/Socionext: add driver for SPI NOR flash Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 16/27] Platform/SynQuacer: incorporate NOR flash and variable drivers Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 17/27] Silicon/SynQuacer: implement PlatformFlashAccessLib Ard Biesheuvel
2017-11-01 5:06 ` Leif Lindholm
2017-10-31 10:52 ` [PATCH edk2-platforms v3 18/27] SynQuacer/SynQuacerMemoryInitPeiLib: add capsule support Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 19/27] Socionext/SynQuacerEvalBoard: wire up basic " Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 20/27] Socionext/SynQuacerEvalBoard: switch to execute in place Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 21/27] Platform/SynQuacerEvalBoard: add signed capsule update support Ard Biesheuvel
2017-11-01 5:10 ` Leif Lindholm
2017-10-31 10:52 ` [PATCH edk2-platforms v3 22/27] Silicon/SynQuacer/AcpiTables: hide PCI domain #0 Ard Biesheuvel
2017-11-01 5:12 ` Leif Lindholm
2017-10-31 10:52 ` [PATCH edk2-platforms v3 23/27] Silicon/SynQuacerPciHostBridgeLib: add workaround to support 32-bit only cards Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 24/27] Platform/Socionext: add support for Socionext Developer Box rev 0.1 Ard Biesheuvel
2017-11-01 5:18 ` Leif Lindholm
2017-11-01 8:31 ` Ard Biesheuvel
2017-11-01 10:01 ` Leif Lindholm
2017-11-01 14:34 ` Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 25/27] Platform/DeveloperBox: add ConsolePrefDxe driver Ard Biesheuvel
2017-10-31 10:52 ` [PATCH edk2-platforms v3 26/27] Silicon/SynQuacer: add description of GPIO block to device tree Ard Biesheuvel
2017-11-01 5:20 ` Leif Lindholm
2017-10-31 10:52 ` [PATCH edk2-platforms v3 27/27] Silicon/SynQuacer: add description of EXIU to the " Ard Biesheuvel
2017-11-01 5:21 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101044642.rwiwsoapw24yy3fc@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox