From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F393721CEB13F for ; Tue, 31 Oct 2017 21:56:09 -0700 (PDT) Received: by mail-wr0-x241.google.com with SMTP id r79so917196wrb.13 for ; Tue, 31 Oct 2017 22:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aATGLEi6S/if98glmyzqKS0Nb2lrrznfem9E/4cch/o=; b=gy3mZ/XcdbcIK0aypQGjKAMniyCZ9/KiqmEa7H7XXpuxUybOxq/muhLqttBopfp8V0 9dRSCdq2ukt0ZYaErbYsYFBRgwqKAaO/R7QBh4iYi2vnZiDd+aSMUACYvMBouDx3iN71 DnAz0iuWdf94cH0emCmb6qCYu/QwI/IOv19RA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aATGLEi6S/if98glmyzqKS0Nb2lrrznfem9E/4cch/o=; b=kS+//f2qFOLztwZUUqNPcJ+NmWAoyXmzslZ7Y5FGcX7ZxlLZgXdaTkUPoEoYVqOPFx 7f/I8CgVcg+sxsXCPWBgDsDWRDWOMSRWusNpgEm7b0NpfE1lk7Tx5HFXbjXKaF9umrvG bhewGWxo0OtEHIns08hnFiP/z27AbaETun98leqP+wJpXnk5XNBKfYeQZyRSzHaNOXSf 6i8qEFk2sB3HfuxfKaO89iHsBz+uUFnq+9CgKnxZebWKXlAWLyclGVxxDar1bouTUxXl iGcZy9UxDQv3j6jVdMKzp408w0fxQYu5138x45WQnx9MWT9lTBK5EqquSGkCVnS7jYRc /+VA== X-Gm-Message-State: AMCzsaWIvXPDjJMjg1p9DpVh6KK9sigFj95M3UvXn42aZz77HumLGYsd x6KWVxeNTO7nQs8Q85n6zRtIvA== X-Google-Smtp-Source: ABhQp+QT7rxOcl01LNy2Wwt20MXIr5qNVqLz4TSROkjUvYJ4BK8VlNafc/v3NLUtduSQcv1uzl6jQA== X-Received: by 10.223.166.181 with SMTP id t50mr3596109wrc.251.1509512401012; Tue, 31 Oct 2017 22:00:01 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m8sm2985555wrg.55.2017.10.31.21.59.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Oct 2017 21:59:59 -0700 (PDT) Date: Wed, 1 Nov 2017 04:59:58 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, graeme.gregory@linaro.org, daniel.thompson@linaro.org, masami.hiramatsu@linaro.org, methavanitpong.pipat@socionext.com Message-ID: <20171101045958.cmfompxqbn4chmwy@bivouac.eciton.net> References: <20171031105218.30208-1-ard.biesheuvel@linaro.org> <20171031105218.30208-11-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171031105218.30208-11-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v3 10/27] Platform/SynQuacerEvalBoard: add PCI support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2017 04:56:10 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 31, 2017 at 10:52:01AM +0000, Ard Biesheuvel wrote: > Wire up the various drivers and libraries for the SynQuacerEvalBoard > platform. Also enable the usual PCI suspects: XHCI, SATA and NVME, > and the various bus, partition and file system drivers that we need > to make use of PCIe devices. > > Given how PCI support enables USB support too, and taking the lack of > a RNG on this SoC into account, let's enable the ChaosKey driver as > well. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 52 ++++++++++++++++++++ > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 41 +++++++++++++++ > 2 files changed, 93 insertions(+) > > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > index 3dc8aa7461d6..519a078e15dc 100644 > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > @@ -100,6 +100,7 @@ [LibraryClasses.common] > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > + UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > # BDS Libraries > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > @@ -151,6 +152,12 @@ [LibraryClasses.common.DXE_DRIVER] > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > + # > + # PCI > + # > + PciSegmentLib|Silicon/Socionext/SynQuacer/Library/SynQuacerPciSegmentLib/SynQuacerPciSegmentLib.inf > + PciHostBridgeLib|Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf > + > [LibraryClasses.common.UEFI_APPLICATION] > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > @@ -193,6 +200,7 @@ [PcdsFixedAtBuild.common] > gSynQuacerTokenSpaceGuid.PcdDramInfoBase|0x2E00FFC0 > > gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40 > + gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24 > > # 12x 2-core processor clusters > gArmPlatformTokenSpaceGuid.PcdCoreCount|2 > @@ -430,3 +438,47 @@ [Components.common] > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > } > + > + # > + # PCI > + # > + Silicon/Socionext/SynQuacer/Drivers/SynQuacerPciCpuIo2Dxe/SynQuacerPciCpuIo2Dxe.inf > + MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf { > + > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8010004F > + } > + MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > + > + # > + # AHCI Support > + # > + MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > + MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > + MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > + MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > + MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > + > + # > + # USB > + # > + MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf > + MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf > + MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > + MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > + MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > + > + # > + # FAT filesystem + GPT/MBR partitioning > + # > + MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > + MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > + MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > + FatPkg/EnhancedFatDxe/Fat.inf > + > + # > + # RNG > + # > + Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDxe.inf > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > index f74e22c31aa5..838963eff612 100644 > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > @@ -132,6 +132,47 @@ [FV.FvMain] > INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > INF MdeModulePkg/Application/UiApp/UiApp.inf > > + # > + # PCI > + # > + INF Silicon/Socionext/SynQuacer/Drivers/SynQuacerPciCpuIo2Dxe/SynQuacerPciCpuIo2Dxe.inf > + INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > + INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > + > + # > + # AHCI Support > + # > + INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > + INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > + INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > + INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > + INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > + > + # > + # USB > + # > + INF MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf > + INF MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf > + INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > + > + # > + # FAT filesystem + GPT/MBR partitioning > + # > + INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > + INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > + INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > + INF FatPkg/EnhancedFatDxe/Fat.inf > + > + # > + # RNG > + # > + INF Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDxe.inf > + > [FV.FVMAIN_PEI] > FvAlignment = 16 > ERASE_POLARITY = 1 > -- > 2.11.0 >