public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jian J Wang <jian.j.wang@intel.com>
To: edk2-devel@lists.01.org
Subject: [PATCH 0/3] Fix misuses of AllocateCopyPool
Date: Fri,  3 Nov 2017 12:57:56 +0800	[thread overview]
Message-ID: <20171103045759.26508-1-jian.j.wang@intel.com> (raw)

AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of
memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger
than size of "Buffer", heap memory overflow occurs during copy.

The solution is to allocate pool first then copy the necessary bytes to new
memory. This can avoid copying extra bytes from unknown memory range.

Jian J Wang (3):
  MdeModulePkg: Fix misuses of AllocateCopyPool
  ShellPkg: Fix misuses of AllocateCopyPool
  IntelFrameworkModulePkg: Fix misuses of AllocateCopyPool

 .../Universal/BdsDxe/DeviceMngr/DeviceManager.c                |  4 +++-
 MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c  |  3 ++-
 .../BootMaintenanceManagerCustomizedUiSupport.c                |  3 ++-
 MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c        |  4 +++-
 MdeModulePkg/Library/UefiHiiLib/HiiLib.c                       | 10 ++++++----
 .../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c       |  3 ++-
 MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c   |  3 ++-
 ShellPkg/Application/Shell/Shell.c                             |  4 +++-
 .../Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c  |  6 ++++--
 9 files changed, 27 insertions(+), 13 deletions(-)

-- 
2.14.1.windows.1



             reply	other threads:[~2017-11-03  4:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03  4:57 Jian J Wang [this message]
2017-11-03  4:57 ` [PATCH 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool Jian J Wang
2017-11-03  9:14   ` Zeng, Star
2017-11-06  0:49     ` Wang, Jian J
2017-11-03  4:57 ` [PATCH 2/3] ShellPkg: " Jian J Wang
2017-11-03  8:22   ` Ni, Ruiyu
2017-11-03 11:43     ` Jim.Dailey
2017-11-06  0:55       ` Wang, Jian J
2017-11-06  0:35     ` Wang, Jian J
2017-11-03  4:57 ` [PATCH 3/3] IntelFrameworkModulePkg: " Jian J Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171103045759.26508-1-jian.j.wang@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox