From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AC122202E5E6A for ; Thu, 2 Nov 2017 21:54:08 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Nov 2017 21:58:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,336,1505804400"; d="scan'208";a="171412422" Received: from jwang36-mobl2.ccr.corp.intel.com ([10.239.192.100]) by fmsmga006.fm.intel.com with ESMTP; 02 Nov 2017 21:58:02 -0700 From: Jian J Wang To: edk2-devel@lists.01.org Date: Fri, 3 Nov 2017 12:57:56 +0800 Message-Id: <20171103045759.26508-1-jian.j.wang@intel.com> X-Mailer: git-send-email 2.14.1.windows.1 Subject: [PATCH 0/3] Fix misuses of AllocateCopyPool X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 04:54:08 -0000 AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger than size of "Buffer", heap memory overflow occurs during copy. The solution is to allocate pool first then copy the necessary bytes to new memory. This can avoid copying extra bytes from unknown memory range. Jian J Wang (3): MdeModulePkg: Fix misuses of AllocateCopyPool ShellPkg: Fix misuses of AllocateCopyPool IntelFrameworkModulePkg: Fix misuses of AllocateCopyPool .../Universal/BdsDxe/DeviceMngr/DeviceManager.c | 4 +++- MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 3 ++- .../BootMaintenanceManagerCustomizedUiSupport.c | 3 ++- MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 4 +++- MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 10 ++++++---- .../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c | 3 ++- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 3 ++- ShellPkg/Application/Shell/Shell.c | 4 +++- .../Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 6 ++++-- 9 files changed, 27 insertions(+), 13 deletions(-) -- 2.14.1.windows.1