Re: [PATCH 1/2] EmbeddedPkg: introduce GPIO PPI

[Leif Lindholm <leif.lindholm@linaro.org>]

On Wed, Nov 01, 2017 at 01:11:44PM +0000, Ard Biesheuvel wrote:
> Introduce a PPI counterpart of the existing 'embedded GPIO' protocol,
> so we can manipulate GPIOs from PEI modules. This allows things like
> setting the boot mode based on a DIP switch setting.
> 
> Note that the naming is slightly awkward, as there is nothing 'embedded'
> about a GPIO, but given that the DXE protocol already resides here and
> has the 'embedded' prefix, it makes sense to retain uniformity.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

I have no objection to this, so:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

...but I do have a question:
Do we strictly need to duplicate this include file? It feels like a
bit of a maintenance hazard/burden.

/
    Leif