public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, daniel.thompson@linaro.org
Subject: Re: [PATCH 1/2] EmbeddedPkg: introduce GPIO PPI
Date: Sun, 5 Nov 2017 05:38:52 +0000	[thread overview]
Message-ID: <20171105053852.ppzfshzqrtwsts4a@bivouac.eciton.net> (raw)
In-Reply-To: <20171101131145.16459-2-ard.biesheuvel@linaro.org>

On Wed, Nov 01, 2017 at 01:11:44PM +0000, Ard Biesheuvel wrote:
> Introduce a PPI counterpart of the existing 'embedded GPIO' protocol,
> so we can manipulate GPIOs from PEI modules. This allows things like
> setting the boot mode based on a DIP switch setting.
> 
> Note that the naming is slightly awkward, as there is nothing 'embedded'
> about a GPIO, but given that the DXE protocol already resides here and
> has the 'embedded' prefix, it makes sense to retain uniformity.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

I have no objection to this, so:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

...but I do have a question:
Do we strictly need to duplicate this include file? It feels like a
bit of a maintenance hazard/burden.

/
    Leif


  reply	other threads:[~2017-11-05  5:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01 13:11 [PATCH 0/2] PEI phase boot mode setting Ard Biesheuvel
2017-11-01 13:11 ` [PATCH 1/2] EmbeddedPkg: introduce GPIO PPI Ard Biesheuvel
2017-11-05  5:38   ` Leif Lindholm [this message]
2017-11-05 10:05     ` Ard Biesheuvel
2017-11-05 16:21       ` Ard Biesheuvel
2017-11-01 13:11 ` [PATCH 2/2] ArmPlatformPkg/PlatformPeim: allow PlatformPeiLib to set the boot mode Ard Biesheuvel
2017-11-05  5:43   ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171105053852.ppzfshzqrtwsts4a@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox