From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22e; helo=mail-wm0-x22e.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 67E9E2034EE18 for ; Sat, 4 Nov 2017 22:35:01 -0700 (PDT) Received: by mail-wm0-x22e.google.com with SMTP id r68so8307928wmr.3 for ; Sat, 04 Nov 2017 22:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IJbGj1GXEp6E3fPDbFF7M49RcKyv4QfawRPUxniRhqQ=; b=JzGlkwZFMrzjk5neBgBX6ZmoTkns9TZL4aWTaIo8Wt1jECFFW7awlJiARS/XWq9dKP em2ENWNX3iTBBx7w6t2I22Y+h1EKXYHK4qPCeAhEozWihEMN7SDnIsknnwKY6G39EM5b rydfieMq5sRnnAE6JmmUrm2qPkAX3NgwFpdhs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IJbGj1GXEp6E3fPDbFF7M49RcKyv4QfawRPUxniRhqQ=; b=gusYPzDlYStwjxug4Yqsxxu5rNF1z/WzN6nGelDX8NrWUnkwbvjKBJGbFJnpEqDm4w t/zz/uoPlvZmVYa23mHiOgHVyWXZ9fTIludUhqnFCxkPGYbIOsEqHXll0BXeKjZ2Ap2l dZBnOiuQaRTKzxik9cXNW4tXsAgTZSIpU+Kbngsj+7W9i8kearYoM943a+V85L9MEvWQ b7MU60nxYJ0Z4tnD0VljpQYpvRZYg9V2iN8BZcswlhqOIo1O9vD1qbiZ4B9e0dKHcU4e CQ27qSbQXpLJSK7peRiuTTgLfjd3HtN2NastLMITEyKJrE42XlHQbjZzi065XP/tmDyN VyRA== X-Gm-Message-State: AJaThX6daLQJqwUybyALom+7ItzGHjrlVYSmGSats2C2YPG04H7b9lr1 Ka6ReOXHTZjBMegclUtJ21uerw== X-Google-Smtp-Source: ABhQp+TMQx5MUNv2Cg5DDXmmRdToRAQnmklCkk8yf1DIsIosL+kCEI0k0h+fIy1/km7LfbkNtYV3/w== X-Received: by 10.28.228.197 with SMTP id b188mr2341080wmh.59.1509860336370; Sat, 04 Nov 2017 22:38:56 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h2sm3573562wrf.47.2017.11.04.22.38.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Nov 2017 22:38:54 -0700 (PDT) Date: Sun, 5 Nov 2017 05:38:52 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, daniel.thompson@linaro.org Message-ID: <20171105053852.ppzfshzqrtwsts4a@bivouac.eciton.net> References: <20171101131145.16459-1-ard.biesheuvel@linaro.org> <20171101131145.16459-2-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171101131145.16459-2-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 1/2] EmbeddedPkg: introduce GPIO PPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Nov 2017 05:35:01 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 01, 2017 at 01:11:44PM +0000, Ard Biesheuvel wrote: > Introduce a PPI counterpart of the existing 'embedded GPIO' protocol, > so we can manipulate GPIOs from PEI modules. This allows things like > setting the boot mode based on a DIP switch setting. > > Note that the naming is slightly awkward, as there is nothing 'embedded' > about a GPIO, but given that the DXE protocol already resides here and > has the 'embedded' prefix, it makes sense to retain uniformity. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel I have no objection to this, so: Reviewed-by: Leif Lindholm ...but I do have a question: Do we strictly need to duplicate this include file? It feels like a bit of a maintenance hazard/burden. / Leif