* [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo
@ 2017-11-07 7:34 Ruiyu Ni
2017-11-07 14:53 ` Carsey, Jaben
0 siblings, 1 reply; 2+ messages in thread
From: Ruiyu Ni @ 2017-11-07 7:34 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
---
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
index d343f3352e..b7b0246ac9 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
@@ -682,7 +682,7 @@ PciRootBridgeIoDumpInformation(
break;
}
if (Temp != NULL) {
- Temp2 = CatSPrint(RetVal, L"%s", Temp);
+ Temp2 = CatSPrint(RetVal, L"\r\n%s", Temp);
FreePool(Temp);
FreePool(RetVal);
RetVal = Temp2;
@@ -690,7 +690,7 @@ PciRootBridgeIoDumpInformation(
}
Temp2 = CatSPrint(RetVal,
- L"\r\n%%H%02x %016lx %016lx %02x%%N",
+ L"%%H%02x %016lx %016lx %02x%%N",
Configuration->SpecificFlag,
Configuration->AddrRangeMin,
Configuration->AddrRangeMax,
--
2.12.2.windows.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo
2017-11-07 7:34 [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo Ruiyu Ni
@ 2017-11-07 14:53 ` Carsey, Jaben
0 siblings, 0 replies; 2+ messages in thread
From: Carsey, Jaben @ 2017-11-07 14:53 UTC (permalink / raw)
To: Ni, Ruiyu, edk2-devel@lists.01.org
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Monday, November 06, 2017 11:35 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [edk2] [PATCH] ShellPkg/dh: Fix wrong output when dumping
> PciRootBridgeIo
> Importance: High
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
> ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index d343f3352e..b7b0246ac9 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -682,7 +682,7 @@ PciRootBridgeIoDumpInformation(
> break;
> }
> if (Temp != NULL) {
> - Temp2 = CatSPrint(RetVal, L"%s", Temp);
> + Temp2 = CatSPrint(RetVal, L"\r\n%s", Temp);
> FreePool(Temp);
> FreePool(RetVal);
> RetVal = Temp2;
> @@ -690,7 +690,7 @@ PciRootBridgeIoDumpInformation(
> }
>
> Temp2 = CatSPrint(RetVal,
> - L"\r\n%%H%02x %016lx %016lx %02x%%N",
> + L"%%H%02x %016lx %016lx %02x%%N",
> Configuration->SpecificFlag,
> Configuration->AddrRangeMin,
> Configuration->AddrRangeMax,
> --
> 2.12.2.windows.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-07 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-07 7:34 [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo Ruiyu Ni
2017-11-07 14:53 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox