Re: [PATCH v3 1/1] EmbeddedPkg: Implement NorFlashInfoLib

[Leif Lindholm <leif.lindholm@linaro.org>]

On Tue, Nov 07, 2017 at 04:45:19PM +0100, Marcin Wojtas wrote:
> Hi Leif,
> 
> 2017-11-07 16:37 GMT+01:00 Leif Lindholm <leif.lindholm@linaro.org>:
> > On Fri, Nov 03, 2017 at 06:55:17PM +0100, Marcin Wojtas wrote:
> >> The SPI NOR flash drivers which base on ArmPlatformPkg's
> >> NorFlashDxe usually make use of static declarations of the
> >> flash instances with their type and parameters. As a result
> >> it implies hardcoding the exact way of flash handling, not to
> >> mention the code does not look very nice. Much better solution
> >> would be obtaining the flash ID and hence its description
> >> in runtime.
> >>
> >> JEDEC compliant SPI NOR devices allow to obtain their IDs with
> >> READ_ID command (0x9f), which should return the vendor ID byte,
> >> followed by 2 to 4 following device ID bytes. Use this capability
> >> for implementing a NorFlashInfoLib that gives an access to the
> >> NOR flash description data, such as name, page size, sector
> >> (block) size and others, of more than 50 different models.
> >> The new library user should pass an output array from issuing
> >> READ_ID command to the NorFlashGetInfo () routine - if the
> >> match is found, an allocated (optionally for RT) pool with
> >> the flash description copy will be returned.
> >>
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> >>
> >> ==========================
> >
> > Please, the separator is ---
> > The below does not belong in the commit message (but should be
> > included below --- for clarity).
> >
> >
> > I would however also like to fold in the following hunk, to enable
> > standalone building:
> >
> > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> > index d7ee6a3018..bc19000e4b 100644
> > --- a/EmbeddedPkg/EmbeddedPkg.dsc
> > +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> > @@ -282,6 +282,8 @@ [Components.common]
> >
> >    EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf
> >
> > +  EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf
> > +
> >  [Components.ARM]
> >     EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf
> >
> > If you are OK with these changes:
> > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> > (do let me know)
> 
> Thanks, I'm of course ok with the changes. Should I resubmit?

Nah, that's fine.

Pushed as 7046610163. (no that's not my phone number accidentally
pasted, it's a short hash containing no a-f)

/
    Leif