From: Leif Lindholm <leif.lindholm@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org,
nadavh@marvell.com, neta@marvell.com, kostap@marvell.com,
jinghua@marvell.com, jsd@semihalf.com
Subject: Re: [platforms: PATCH v2 0/6] Armada 7k/8k SPI improvements pt 2.
Date: Tue, 7 Nov 2017 17:21:49 +0000 [thread overview]
Message-ID: <20171107172149.guvrgvtblcfmhbwm@bivouac.eciton.net> (raw)
In-Reply-To: <1509731835-5664-1-git-send-email-mw@semihalf.com>
On Fri, Nov 03, 2017 at 06:57:09PM +0100, Marcin Wojtas wrote:
> Hi,
>
> I submit corrected version of the Armada SPI improvements
> after the first round of review. There were no significant changes
> comparing to v1, please check the changelog below for the details.
>
> Patches are available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20171103
> NorFlashInfoLib:
> https://github.com/MarvellEmbeddedProcessors/edk2/commits/norlib-upstream-r20171103
>
> I'm looking forward to the comments or remarks.
For the remaining patches of the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as f79bce44ac..6c7c803218.
> Best regards,
> Marcin
>
> Changelog:
> v1 -> v2
> 1/6
> - Replace NOR_FLASH_ID_DEFAULT_LEN with PcdGetSize (PcdSpiFlashId)
>
> 2/6
> - Adjust to renamed functions and macros according to NorFlashInfoLib v2
> - Restore handling of CMD_ERASE_32K
> - Check NOR_FLASH_4B_ADDR only once and use SPI_DEVICE structure instead
>
> 3/6
> - Improve commit log
>
> 4/6
> - Use global variable explicitly (mSlave)
>
> 5/6
> - Use NOR_FLASH_ID_SPANSION from EmbeddedPkg/Include/Library/NorFlashInfoLib.h
>
> 6/6
> - Add RB
>
> Marcin Wojtas (6):
> Marvell/Drivers: MvSpiFlash: Improve ReadId
> Marvell/Drivers: MvSpiFlash: Enable dynamic SPI Flash detection
> Marvell/Drivers: MvSpiFlash: Remove duplicated macros
> Marvell/Applications: SpiTool: Do not override existing slave device
> Marvell/Drivers: MvSpiFlash: Fix bank selection for Spansion
> Marvell/Drivers: MvSpiDxe: Keep data in SPI_DEVICE structure
>
> Platform/Marvell/Applications/FirmwareUpdate/FUpdate.c | 25 +----
> Platform/Marvell/Applications/FirmwareUpdate/FUpdate.inf | 4 +-
> Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c | 57 ++++------
> Platform/Marvell/Applications/SpiTool/SpiFlashCmd.inf | 2 +-
> Platform/Marvell/Armada/Armada.dsc.inc | 1 +
> Platform/Marvell/Armada/Armada70x0.dsc | 5 -
> Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c | 116 ++++++++++----------
> Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.h | 3 +
> Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.inf | 9 +-
> Platform/Marvell/Drivers/Spi/MvSpiDxe.c | 63 ++++++-----
> Platform/Marvell/Drivers/Spi/MvSpiDxe.h | 1 +
> Platform/Marvell/Drivers/Spi/MvSpiDxe.inf | 2 +
> Platform/Marvell/Include/Protocol/Spi.h | 7 ++
> Platform/Marvell/Include/Protocol/SpiFlash.h | 14 +--
> Platform/Marvell/Marvell.dec | 6 -
> Silicon/Marvell/Documentation/PortingGuide.txt | 18 ---
> 16 files changed, 142 insertions(+), 191 deletions(-)
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-11-07 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 17:57 [platforms: PATCH v2 0/6] Armada 7k/8k SPI improvements pt 2 Marcin Wojtas
2017-11-03 17:57 ` [platforms: PATCH v2 1/6] Marvell/Drivers: MvSpiFlash: Improve ReadId Marcin Wojtas
2017-11-03 17:57 ` [platforms: PATCH v2 2/6] Marvell/Drivers: MvSpiFlash: Enable dynamic SPI Flash detection Marcin Wojtas
2017-11-03 17:57 ` [platforms: PATCH v2 3/6] Marvell/Drivers: MvSpiFlash: Remove duplicated macros Marcin Wojtas
2017-11-03 17:57 ` [platforms: PATCH v2 4/6] Marvell/Applications: SpiTool: Do not override existing slave device Marcin Wojtas
2017-11-03 17:57 ` [platforms: PATCH v2 5/6] Marvell/Drivers: MvSpiFlash: Fix bank selection for Spansion Marcin Wojtas
2017-11-03 17:57 ` [platforms: PATCH v2 6/6] Marvell/Drivers: MvSpiDxe: Keep data in SPI_DEVICE structure Marcin Wojtas
2017-11-05 6:13 ` [platforms: PATCH v2 0/6] Armada 7k/8k SPI improvements pt 2 Leif Lindholm
2017-11-05 7:51 ` Marcin Wojtas
2017-11-07 17:21 ` Leif Lindholm [this message]
2017-11-07 18:10 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107172149.guvrgvtblcfmhbwm@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox