From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6FCD3202E6182 for ; Tue, 7 Nov 2017 09:17:53 -0800 (PST) Received: by mail-wr0-x242.google.com with SMTP id j15so12525711wre.8 for ; Tue, 07 Nov 2017 09:21:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=H6p1ag7+yp9nkujsQ1bbS9xdhhcFbmWhj3SdQps9brs=; b=BKcWrPCYdR28usFgavtkxqCREjiAtsSKO3+lVOfbXYikOMmOt/4TN4I6uyqcx2oe06 SbgakiqoDgcSJ8fGKAYSQEY3NrHUhs/DF668sLIEKWii0ZNBx8I4BOAgRYlRlwQxQSAR cGLNSjcbYBxEj1VxHNh3QFrdRw7RzP/mAHd0o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=H6p1ag7+yp9nkujsQ1bbS9xdhhcFbmWhj3SdQps9brs=; b=SAuykb8d2Qr//tfckzJabhBZ7gB97EkHsF7urRNST7UbNi+zm+ZCYMlVfgWdjl5TiQ 5qyX5aWlVINH8EL25gzLbNVWJCQq7CaYko13TD0wsUWJkuHG1ziVHkesbjR8d5BVFwlk OpjP5tR87aITVbUWVANNPz5uSOvxFheeiyp0CXOxopEmSiPfvb2yZsZNrYYYcAu9O1HB 4SyFzBfwJ08EtPlmCxBQDJo5fqRn8dFdPf2WQeld0JECugQ3lXAIyvPu49bg1cBDsTHV NFoOQ9oTLX8iFlqBe7jB0Sg+msFz9m7VXPbpx7kId7OWF+mrOKQJbwZXE/687JCjaQaL +bYw== X-Gm-Message-State: AJaThX5QSNp72EZpKXmMcGxpOr5LOxOFGcyzB4EDSc3sMLtaDkzZ6nf8 tqIOXELp/QWrA6jxKs+Kg/AZ1w== X-Google-Smtp-Source: ABhQp+Tebl6lgXW2htu3tgF6yHIt/gbaEFfueK60QkMxCjbJ8voLyD+UxDvLAEpe799lib5tmPIM6A== X-Received: by 10.223.154.202 with SMTP id a68mr8362516wrc.8.1510075311607; Tue, 07 Nov 2017 09:21:51 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t6sm1636067wra.28.2017.11.07.09.21.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Nov 2017 09:21:50 -0800 (PST) Date: Tue, 7 Nov 2017 17:21:49 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171107172149.guvrgvtblcfmhbwm@bivouac.eciton.net> References: <1509731835-5664-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1509731835-5664-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 0/6] Armada 7k/8k SPI improvements pt 2. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 17:17:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 03, 2017 at 06:57:09PM +0100, Marcin Wojtas wrote: > Hi, > > I submit corrected version of the Armada SPI improvements > after the first round of review. There were no significant changes > comparing to v1, please check the changelog below for the details. > > Patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20171103 > NorFlashInfoLib: > https://github.com/MarvellEmbeddedProcessors/edk2/commits/norlib-upstream-r20171103 > > I'm looking forward to the comments or remarks. For the remaining patches of the series: Reviewed-by: Leif Lindholm Pushed as f79bce44ac..6c7c803218. > Best regards, > Marcin > > Changelog: > v1 -> v2 > 1/6 > - Replace NOR_FLASH_ID_DEFAULT_LEN with PcdGetSize (PcdSpiFlashId) > > 2/6 > - Adjust to renamed functions and macros according to NorFlashInfoLib v2 > - Restore handling of CMD_ERASE_32K > - Check NOR_FLASH_4B_ADDR only once and use SPI_DEVICE structure instead > > 3/6 > - Improve commit log > > 4/6 > - Use global variable explicitly (mSlave) > > 5/6 > - Use NOR_FLASH_ID_SPANSION from EmbeddedPkg/Include/Library/NorFlashInfoLib.h > > 6/6 > - Add RB > > Marcin Wojtas (6): > Marvell/Drivers: MvSpiFlash: Improve ReadId > Marvell/Drivers: MvSpiFlash: Enable dynamic SPI Flash detection > Marvell/Drivers: MvSpiFlash: Remove duplicated macros > Marvell/Applications: SpiTool: Do not override existing slave device > Marvell/Drivers: MvSpiFlash: Fix bank selection for Spansion > Marvell/Drivers: MvSpiDxe: Keep data in SPI_DEVICE structure > > Platform/Marvell/Applications/FirmwareUpdate/FUpdate.c | 25 +---- > Platform/Marvell/Applications/FirmwareUpdate/FUpdate.inf | 4 +- > Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c | 57 ++++------ > Platform/Marvell/Applications/SpiTool/SpiFlashCmd.inf | 2 +- > Platform/Marvell/Armada/Armada.dsc.inc | 1 + > Platform/Marvell/Armada/Armada70x0.dsc | 5 - > Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c | 116 ++++++++++---------- > Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.h | 3 + > Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.inf | 9 +- > Platform/Marvell/Drivers/Spi/MvSpiDxe.c | 63 ++++++----- > Platform/Marvell/Drivers/Spi/MvSpiDxe.h | 1 + > Platform/Marvell/Drivers/Spi/MvSpiDxe.inf | 2 + > Platform/Marvell/Include/Protocol/Spi.h | 7 ++ > Platform/Marvell/Include/Protocol/SpiFlash.h | 14 +-- > Platform/Marvell/Marvell.dec | 6 - > Silicon/Marvell/Documentation/PortingGuide.txt | 18 --- > 16 files changed, 142 insertions(+), 191 deletions(-) > > -- > 2.7.4 >