From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D6CE020355202 for ; Tue, 7 Nov 2017 18:08:06 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2017 18:12:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,361,1505804400"; d="scan'208";a="1241185256" Received: from jwang36-mobl2.ccr.corp.intel.com ([10.239.192.49]) by fmsmga002.fm.intel.com with ESMTP; 07 Nov 2017 18:12:03 -0800 From: Jian J Wang To: edk2-devel@lists.01.org Date: Wed, 8 Nov 2017 10:11:58 +0800 Message-Id: <20171108021201.17436-1-jian.j.wang@intel.com> X-Mailer: git-send-email 2.14.1.windows.1 Subject: [PATCH v3 0/3] Fix misuses of AllocateCopyPool X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 02:08:08 -0000 > v3: > a. Add necessary ASSERT > b. Correct StrCpyS parameter > c. Coding style clean-up > v2: > a. Use ReallocatePool instead of allocating then copying wherever applicable AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger than size of "Buffer", heap memory overflow occurs during copy. One solution is to allocate pool first then copy the necessary bytes to new memory. Another is using ReallocatePool instead if old buffer will be freed on spot. Jian J Wang (3): MdeModulePkg: Fix misuses of AllocateCopyPool ShellPkg: Fix misuses of AllocateCopyPool IntelFrameworkModulePkg: Fix misuses of AllocateCopyPool .../Universal/BdsDxe/DeviceMngr/DeviceManager.c | 10 +++++----- .../Application/UiApp/FrontPageCustomizedUiSupport.c | 8 ++++++-- .../BootMaintenanceManagerCustomizedUiSupport.c | 8 ++++++-- MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 10 +++++----- MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 12 ++++++++---- .../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c | 3 ++- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 9 ++++++--- ShellPkg/Application/Shell/Shell.c | 4 +++- .../UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 7 +++++-- 9 files changed, 46 insertions(+), 25 deletions(-) -- 2.14.1.windows.1