From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2EE6B202E5E5A for ; Wed, 8 Nov 2017 12:15:46 -0800 (PST) Received: by mail-wm0-x242.google.com with SMTP id r68so13377369wmr.3 for ; Wed, 08 Nov 2017 12:19:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bgO4Qq7JijcYqj9HOs6W+ne5Q9lzrnYNUnfheDVX5AM=; b=cdrKHq8SLXRIjj9u9N57gg3xfHEsCNKnF6E7iL74QO8z7ZVv3/ZPwb1OKDtm9zzJph tMVvqsrUd1EDWR45lDco0RvDvWOQ6r57aQbZhQXj2Gtm53sETmwC840f5l6LzZr2ThBW Vob800X8IydI35ikHfNAXaIBYmVZiCjUw4apk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bgO4Qq7JijcYqj9HOs6W+ne5Q9lzrnYNUnfheDVX5AM=; b=RID/zRBkXnW6M+cOKG+vmOtcEw9LGYMC+8ZOI8CqLmxkx2DehVSUE084uDGraFtMqA 5fQjg+nb2Yz77b6aQG+OQTgvaEXm2hI2Sl7/FJ3HKpAvVgzT+J3FmM9BKzRirDWgfnxP JG+k7bC+WMw3WdeRPb9UKoFrq8cqKIv1SMR8Bhbz8BuTFyBrUaJX4Nap4nqVchRqnqvR FD3GprcV0pQMVT9GaVPzGI1XaX1vy1eGwZAmnqVNW5mlxE8nRihzDNXw6G9oh6QOvMy8 2riyzbW8chxJWMHmXRj/CfkAYOr6L/6hcN5geKZj4dSeAUklxLLkT+FAVsY6jVxeEVFT 9iMg== X-Gm-Message-State: AJaThX50m6UvTc4OQ0wvpv+O2kc3HoCWoefM9qsoX99vjeBA7odsTdFl 05Ro6WzoJG+pphweApTWw0i0og== X-Google-Smtp-Source: ABhQp+SIkG7D4/SkO5m2TOYDojVddq+8mcrRrmp5SBgov3Cq5Vis8jPNKK4/KNsHZjXKR2nWi36dOw== X-Received: by 10.28.203.136 with SMTP id b130mr1411804wmg.105.1510172385537; Wed, 08 Nov 2017 12:19:45 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x63sm6516382wma.39.2017.11.08.12.19.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Nov 2017 12:19:44 -0800 (PST) Date: Wed, 8 Nov 2017 20:19:43 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Daniel Thompson Message-ID: <20171108201942.yoodku3khsdnebz2@bivouac.eciton.net> References: <20171103101654.30973-1-ard.biesheuvel@linaro.org> <20171103101654.30973-2-ard.biesheuvel@linaro.org> <20171108164758.edrae5f4invwybc6@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [RFC PATCH edk2-platforms 1/3] Silicon/NXP: add RTC support library for PCF8563 I2C IP X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 20:15:46 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 08, 2017 at 05:45:11PM +0000, Ard Biesheuvel wrote: > On 8 November 2017 at 16:47, Leif Lindholm wrote: > > On Fri, Nov 03, 2017 at 10:16:52AM +0000, Ard Biesheuvel wrote: > >> Add a RealTimeClockLib implementation for the NXP PCF8563 as used on > >> the Socionext Developer Box board. Note that the standard I2C protocol > >> stack does not support runtime use, so this driver invokes the I2C master > >> protocol directly. This requires support from the platform side as well, > >> and so this driver will only attach to a I2C master that has the > >> gPcf8563RealTimeClockLibI2cMasterProtolGuid protocol installed on its > >> handle. It is up to the platform to ensure that the driver producing > >> the I2C master protocol in question is runtime capable, and is not > >> shared with the I2C protocol stack (i.e., it should not have the I2C > >> Bus Configuration Management protocol installed as well). > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Ard Biesheuvel > > > > Reviewed-by: Leif Lindholm > > Ehm, is this in response to the correct patch, given that you already > asked for some changes? No, that's me getting confused by the patches appearing out of order in my inbox... Apologies. / Leif