From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::22c; helo=mail-wr0-x22c.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x22c.google.com (mail-wr0-x22c.google.com [IPv6:2a00:1450:400c:c0c::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DDFBF2034BBD9 for ; Thu, 9 Nov 2017 07:36:33 -0800 (PST) Received: by mail-wr0-x22c.google.com with SMTP id o88so5980184wrb.6 for ; Thu, 09 Nov 2017 07:40:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kl+fNGQo0zpmFfa06GGIzVgFt4lUy4pXdwzF5qiFFtQ=; b=ANQlULk56sOFy9GX3nBS2JFrgN0KpK5ND33N1PVbmb5swTrbu4GLw8i3vWlepLJ9Ea bEBzSsZyUF/LQ3Rt1tCIBxn2FmLhOe03c8Z0fvu3M5WzIakJI2C7DERHggShQGpkaKqx J3oeCSBqjAdldJnIZ9gBnwkQzwyjklkBogHkk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kl+fNGQo0zpmFfa06GGIzVgFt4lUy4pXdwzF5qiFFtQ=; b=ufCb+95lLk+9EgwclUYy41lyb3iu7z29htGVZfbwlfd3VsaKmLZhFmSb42ure4Euai dYedqdIbSnsjoPGbhy0AMrDCcmEuNdEjcBYPuFPyW0gX7IKc0TniQf9uApD+LjmKS7yL BKiN9BdbjeCxHXmyH3RNlIrpWWcBKPn5rLlgR3cPvkSnKXgWg7jogSa0egV5okCyZv0v y7e95U4XHYIvLIS6g9Zn6eAwaEGM4q2BJYmjQhopCWzGJsbLnHzJklkjsrquxb6GiAn4 KMgilmq/WgDTTSPoVZ1La9penCkkdD6lnL7fVqcEIt5sbMsY0ANiLspeSi1XX7ymdNxo y7RA== X-Gm-Message-State: AJaThX4uv1v8jvhWf5BfYuS/ti8FkS8m4DIpGJ0c5M+jHHCEDqmFAaug 9TIVjlECkvIDd0SNyBAVx/UsBhhsCVM= X-Google-Smtp-Source: ABhQp+SyviCTEjMohvMsRUG9Ie8AtqO316F6Sgo7qOq5le2hDkz0gS5EeNDCRjvVLm2q7+5afKHvLA== X-Received: by 10.223.139.149 with SMTP id o21mr786125wra.87.1510242034266; Thu, 09 Nov 2017 07:40:34 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o20sm6946946wro.6.2017.11.09.07.40.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Nov 2017 07:40:33 -0800 (PST) Date: Thu, 9 Nov 2017 15:40:31 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Message-ID: <20171109154031.ewlgdw3rbioyvmcx@bivouac.eciton.net> References: <1509879339-10516-1-git-send-email-mw@semihalf.com> <1509879339-10516-4-git-send-email-mw@semihalf.com> <20171109150259.tafexhjd7qzocrc3@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 3/4] Platform/Marvell: Introduce MvFvbDxe variable support driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2017 15:36:34 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 09, 2017 at 04:16:54PM +0100, Marcin Wojtas wrote: > Hi Leif, > > > > + { > > > + MvFvbGetAttributes, // GetAttributes > > > + MvFvbSetAttributes, // SetAttributes > > > + MvFvbGetPhysicalAddress, // GetPhysicalAddress > > > + MvFvbGetBlockSize, // GetBlockSize > > > + MvFvbRead, // Read > > > + MvFvbWrite, // Write > > > + MvFvbEraseBlocks, // EraseBlocks > > > + NULL, // ParentHandle > > > + }, // FvbProtoccol; > > > > -c > > > > Thanks for thorough review. Everything seems clear, but what does "-c" > above mean? You stole the misspelt "// FvbProtocol" from ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c. This had the benefit of showing me what this file was based on, but should probably be fixed :) / Leif