From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::236; helo=mail-wr0-x236.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x236.google.com (mail-wr0-x236.google.com [IPv6:2a00:1450:400c:c0c::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2EB4721B00DD6 for ; Thu, 9 Nov 2017 08:00:11 -0800 (PST) Received: by mail-wr0-x236.google.com with SMTP id k61so6060782wrc.4 for ; Thu, 09 Nov 2017 08:04:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fzO3ImkJwRS2wZWZfcjA7Btn2VyjRUw84u48y2ttDpg=; b=EDmelIzQ3GgegXAA7o8cLd4h4PRl9lQky+nL8+zlox1ta0uC4bj3Y5EaWbrZWigNeB VOqrLYpa6RPAqiZMZ2r2ZsSpkb8oUAT0N9eafQg4JRa2THfL145Y1M4S0fO6nfijrOrq 6ZPVps4x/L2UpjF1624yQkn92ro+TtUyu/NQI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fzO3ImkJwRS2wZWZfcjA7Btn2VyjRUw84u48y2ttDpg=; b=bOQbtm/icIn1McHG2mvwHILxXtDfzdBfXK1dWzMpylE9JvdWyMXvZJ62Wu5a/Qea5W iOHxnZN7CymZL0h7d//Mw9kMIwira4IYOuib69G18gpM9SLHemwAAZyIL0xwykVljXYK r/9zqZMpYD3FZmv9xIIPBtllrU4TBmMJJAZ2kW5ebGxmCRgzpvYU/ovVhEfgKG2TjA3n SmZkfqyVu/KNnz+6664gMvgIUf0JXfcJ1h7nY7vXZvS0PC3oSoQPC+ydQ5lZ9Fwgp6Ig mK6OIheybmTjZB5Grkwr4f8cB4a5YrcpnuLLLhw749THdXzNRkwiaXmj7VOCru3mUYVc wP/A== X-Gm-Message-State: AJaThX4d5TSXEanM/CbIff5i3xiVjjaV+bFMdao5kBNAjvcb4jcrlzQc rsUq4oVHlhaBydpUif6Sm2vMvw== X-Google-Smtp-Source: ABhQp+S2dGaNeS6b4rK5w+orjy9bfx0lPvDQOKIlCiBurFgK5EGTsNAHi01rGdYct/fMAGywPFyYng== X-Received: by 10.223.161.20 with SMTP id o20mr913385wro.276.1510243452372; Thu, 09 Nov 2017 08:04:12 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id s67sm4928898wmd.23.2017.11.09.08.04.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Nov 2017 08:04:11 -0800 (PST) Date: Thu, 9 Nov 2017 16:04:09 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Message-ID: <20171109160409.4chdx6655ivsotp6@bivouac.eciton.net> References: <1509879339-10516-1-git-send-email-mw@semihalf.com> <1509879339-10516-4-git-send-email-mw@semihalf.com> <20171109150259.tafexhjd7qzocrc3@bivouac.eciton.net> <20171109154031.ewlgdw3rbioyvmcx@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 3/4] Platform/Marvell: Introduce MvFvbDxe variable support driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2017 16:00:12 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 09, 2017 at 04:48:05PM +0100, Marcin Wojtas wrote: > 2017-11-09 16:40 GMT+01:00 Leif Lindholm : > > On Thu, Nov 09, 2017 at 04:16:54PM +0100, Marcin Wojtas wrote: > >> Hi Leif, > >> > >> > > + { > >> > > + MvFvbGetAttributes, // GetAttributes > >> > > + MvFvbSetAttributes, // SetAttributes > >> > > + MvFvbGetPhysicalAddress, // GetPhysicalAddress > >> > > + MvFvbGetBlockSize, // GetBlockSize > >> > > + MvFvbRead, // Read > >> > > + MvFvbWrite, // Write > >> > > + MvFvbEraseBlocks, // EraseBlocks > >> > > + NULL, // ParentHandle > >> > > + }, // FvbProtoccol; > >> > > >> > -c > >> > >> Thanks for thorough review. Everything seems clear, but what does "-c" > >> above mean? > > > > You stole the misspelt "// FvbProtocol" from > > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c. > > > > This had the benefit of showing me what this file was based on, but > > should probably be fixed :) > > > > Right, I could have mentioned it explicitly in the commit message > (only the copyrights are left). Significant part of the issues you > pointed had been inherited from the original driver - my eyes and the > checkpatch missed them. I assumed they had, but that driver predates my reviewing. If you could (completely unrelatedly) mirror those changes to the original, that would of course be highly appreciated. / Leif