From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Jordan Justen <jordan.l.justen@intel.com>,
Ruiyu Ni <ruiyu.ni@intel.com>
Subject: [PATCH 1/4] OvmfPkg/Sec/Ia32: free up EAX for other uses while setting up the stack
Date: Fri, 10 Nov 2017 16:49:05 +0100 [thread overview]
Message-ID: <20171110154908.306-2-lersek@redhat.com> (raw)
In-Reply-To: <20171110154908.306-1-lersek@redhat.com>
Currently EAX is used as an intermediary in setting ESP to
SEC_TOP_OF_STACK, and in passing SEC_TOP_OF_STACK to
SecCoreStartupWithStack() as the "TopOfCurrentStack" argument.
In a later patch we'll use EAX differently, so replace it with EBX under
the current use.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/Sec/Ia32/SecEntry.nasm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/OvmfPkg/Sec/Ia32/SecEntry.nasm b/OvmfPkg/Sec/Ia32/SecEntry.nasm
index 7fee1c2b2e4f..54d074e621f6 100644
--- a/OvmfPkg/Sec/Ia32/SecEntry.nasm
+++ b/OvmfPkg/Sec/Ia32/SecEntry.nasm
@@ -40,8 +40,8 @@ ASM_PFX(_ModuleEntryPoint):
;
%define SEC_TOP_OF_STACK (FixedPcdGet32 (PcdOvmfSecPeiTempRamBase) + \
FixedPcdGet32 (PcdOvmfSecPeiTempRamSize))
- mov eax, SEC_TOP_OF_STACK
- mov esp, eax
+ mov ebx, SEC_TOP_OF_STACK
+ mov esp, ebx
nop
;
@@ -50,7 +50,7 @@ ASM_PFX(_ModuleEntryPoint):
; [esp+4] BootFirmwareVolumePtr
; [esp+8] TopOfCurrentStack
;
- push eax
+ push ebx
push ebp
call ASM_PFX(SecCoreStartupWithStack)
--
2.14.1.3.gb7cf6e02401b
next prev parent reply other threads:[~2017-11-10 15:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 15:49 [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB Laszlo Ersek
2017-11-10 15:49 ` Laszlo Ersek [this message]
2017-11-13 18:08 ` [PATCH 1/4] OvmfPkg/Sec/Ia32: free up EAX for other uses while setting up the stack Jordan Justen
2017-11-13 18:30 ` Laszlo Ersek
2017-11-10 15:49 ` [PATCH 2/4] OvmfPkg/Sec/Ia32: seed the temporary RAM with PcdInitValueInTempStack Laszlo Ersek
2017-11-10 15:56 ` Ard Biesheuvel
2017-11-10 18:11 ` Laszlo Ersek
2017-11-10 18:27 ` Laszlo Ersek
2017-11-11 9:10 ` Ard Biesheuvel
2017-11-13 18:25 ` Jordan Justen
2017-11-13 18:36 ` Laszlo Ersek
2017-11-13 19:02 ` Jordan Justen
2017-11-13 20:58 ` Laszlo Ersek
2017-11-10 15:49 ` [PATCH 3/4] OvmfPkg/Sec/X64: " Laszlo Ersek
2017-11-10 15:49 ` [PATCH 4/4] OvmfPkg: restore temporary SEC/PEI RAM size to 64KB Laszlo Ersek
2017-11-11 9:14 ` [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM " Ard Biesheuvel
2017-11-11 20:38 ` Jordan Justen
2017-11-11 22:04 ` Jordan Justen
2017-11-12 10:58 ` Ard Biesheuvel
2017-11-13 9:08 ` Jordan Justen
2017-11-13 10:09 ` Ard Biesheuvel
2017-11-13 12:34 ` Laszlo Ersek
2017-11-13 13:09 ` Laszlo Ersek
2017-11-13 18:05 ` Jordan Justen
2017-11-13 18:04 ` Jordan Justen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110154908.306-2-lersek@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox