Re: [PATCH edk2-non-osi v3] Hisilicon D0x: Remove uncacheable attribute from memory resource HOB

[Leif Lindholm <leif.lindholm@linaro.org>]

On Mon, Nov 13, 2017 at 02:04:57PM +0000, Ard Biesheuvel wrote:
> On 13 November 2017 at 12:23, Heyi Guo <heyi.guo@linaro.org> wrote:
> > From: Ming Huang <huangming23@huawei.com>
> >
> > If uncacheable attribute is included in memory resource HOB,
> > GCD spaces will also have EFI_MEMORY_UC capability,
> > then NonCoherentPciIoAllocateBuffer of NonDiscoverablePciDeviceDxe
> > module will allocate DMA buffer of EFI_MEMORY_UC type, which will
> > cause alignment fault exception with BaseMemoryLibOptDxe.
> >
> > This not only affects NonDiscoverablePciDeviceDxe, it removes the
> > UC attribute from all DRAM regions in the UEFI memory map,
> > which makes much more sense on ARM
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Liu Yi <liuyi86@huawei.com>
> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> > Signed-off-by: Ming Huang <huangming23@huawei.com>
> 
> Assuming the patch does what it says on the tin:
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Pushed as bd4078f.

> > ---
> >  Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi | Bin 90272 -> 90336 bytes
> >  Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi | Bin 152576 -> 152480 bytes
> >  2 files changed, 0 insertions(+), 0 deletions(-)
> >
> > diff --git a/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi
> > index 354abcc..31e2903 100644
> > Binary files a/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi differ
> > diff --git a/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi
> > index b94e0cb..eb71c44 100644
> > Binary files a/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi differ
> > --
> > 1.9.1
> >