From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 39287203555F8 for ; Mon, 13 Nov 2017 06:22:37 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id v186so6662441wma.2 for ; Mon, 13 Nov 2017 06:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mB+uH1qPjBtkX1NxaSIA4F2Lyc6nkKWZ+Tsd37OV50Q=; b=PQRAMwnKXENUDKkClXpqu/Y+Gdp4HP1gsIybxIiLAF1JF894m8EZd97PRKm91jaGu2 +K+roZusD3PMjN6Y6WtJVoTM3ffxFb2fekMlbhigJ+X6kq0Qtm/tjjusn8um0P6A8lAA 72t0xlPdnnxPKNxzgmliPAGlruQ7UnlK8akrQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mB+uH1qPjBtkX1NxaSIA4F2Lyc6nkKWZ+Tsd37OV50Q=; b=afSanJAkcX5U03+XYeFbs2xhThAAzEvcw9oxDUNawzOodOtdUgjiQQh8XLHvucCAW/ oTFjW7QtjXv8raU8sL/xelf8BySx5VDCbDbHMXunLIM0S3P9fdLLM6Gic5evYcdVNWod zvBAsydnyaMrbSe2Xi5HzfYJSilvI4tqqsLfqXD2mnjsARIJLX+iTgkpHFJe07EJT0fE baM9mcMu25SjVKyUluXh4sJGcmuWXE4DYXdBzG0g/wJdUKj4SUblQLIuTHeTjuSI+5tE 5uLi/GprjZzga2I54smPwH0rRK0zkc0yopTaO2fXwthMov3jArQ3Sn9RAcyfJ7Uy96+T YiUg== X-Gm-Message-State: AJaThX5/RJ/vg1mI83Lp/9lMtIS0SFy2uE76OPB4Ir4/YxSvrzjsS4JX +Jz4Kslk8jox/xVCz7dROImuvw== X-Google-Smtp-Source: AGs4zMZqDA+8lFkJMD4gH9wnPyMfKdq476jro5oKFe1ly7FLqS5CuENQNw7RpPwWvoKDQT/RbxiMcw== X-Received: by 10.28.207.8 with SMTP id f8mr1283289wmg.30.1510583202715; Mon, 13 Nov 2017 06:26:42 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y99sm13192276wmh.0.2017.11.13.06.26.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Nov 2017 06:26:41 -0800 (PST) Date: Mon, 13 Nov 2017 14:26:39 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: Heyi Guo , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , "guoheyi@huawei.com" , wanghuiqiang , huangming , Jason Zhang , Mengfanrong , waip23@126.com, Liu Yi Message-ID: <20171113142639.nlzlf5svftpumqoh@bivouac.eciton.net> References: <1510575804-42572-1-git-send-email-heyi.guo@linaro.org> <1510575804-42572-2-git-send-email-heyi.guo@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-non-osi v3] Hisilicon D0x: Remove uncacheable attribute from memory resource HOB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2017 14:22:38 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 13, 2017 at 02:04:57PM +0000, Ard Biesheuvel wrote: > On 13 November 2017 at 12:23, Heyi Guo wrote: > > From: Ming Huang > > > > If uncacheable attribute is included in memory resource HOB, > > GCD spaces will also have EFI_MEMORY_UC capability, > > then NonCoherentPciIoAllocateBuffer of NonDiscoverablePciDeviceDxe > > module will allocate DMA buffer of EFI_MEMORY_UC type, which will > > cause alignment fault exception with BaseMemoryLibOptDxe. > > > > This not only affects NonDiscoverablePciDeviceDxe, it removes the > > UC attribute from all DRAM regions in the UEFI memory map, > > which makes much more sense on ARM > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Liu Yi > > Signed-off-by: Heyi Guo > > Signed-off-by: Ming Huang > > Assuming the patch does what it says on the tin: > > Reviewed-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Pushed as bd4078f. > > --- > > Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi | Bin 90272 -> 90336 bytes > > Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi | Bin 152576 -> 152480 bytes > > 2 files changed, 0 insertions(+), 0 deletions(-) > > > > diff --git a/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi > > index 354abcc..31e2903 100644 > > Binary files a/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi differ > > diff --git a/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi > > index b94e0cb..eb71c44 100644 > > Binary files a/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi differ > > -- > > 1.9.1 > >