From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CBC77220757F4 for ; Mon, 13 Nov 2017 18:43:22 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2017 18:47:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,392,1505804400"; d="scan'208";a="175890433" Received: from ray-dev.ccr.corp.intel.com ([10.239.9.7]) by fmsmga006.fm.intel.com with ESMTP; 13 Nov 2017 18:47:28 -0800 From: Ruiyu Ni To: edk2-devel@lists.01.org Date: Tue, 14 Nov 2017 10:47:25 +0800 Message-Id: <20171114024725.82392-1-ruiyu.ni@intel.com> X-Mailer: git-send-email 2.12.2.windows.2 Subject: [PATCH] MdeModulePkg/DxeCore: Remove redundant code in Tpl.c X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2017 02:43:22 -0000 (MdeModulePkg\Core\Dxe\Event\Tpl.c) line 120-122 ----------------------------------------------------------------- 120 if (OldTpl >= TPL_HIGH_LEVEL && NewTpl < TPL_HIGH_LEVEL) { 121 gEfiCurrentTpl = TPL_HIGH_LEVEL; 122 } ----------------------------------------------------------------- First, the newly assigned *gEfiCurrentTpl* is never used before next re-assignment by the code that follows. Second, The "OldTpl" comes from "gEfiCurrentTpl". If "OldTpl >= TPL_HIGH_LEVEL" holds, the timer interrupt *must* have been disabled according to the semantic of TPL_HIGH_LEVEL. Since Uefi FW executes as single-threaded *strictly*, no other code will possibly visit the "gEfiCurrentTpl". So the 3 lines of code should be redundant. Contributed-under: TianoCore Contribution Agreement 1.1 Suggested-by: Ming Shao Signed-off-by: Ruiyu Ni --- MdeModulePkg/Core/Dxe/Event/Tpl.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/MdeModulePkg/Core/Dxe/Event/Tpl.c b/MdeModulePkg/Core/Dxe/Event/Tpl.c index e3caf832b8..5f60fd077f 100644 --- a/MdeModulePkg/Core/Dxe/Event/Tpl.c +++ b/MdeModulePkg/Core/Dxe/Event/Tpl.c @@ -113,15 +113,6 @@ CoreRestoreTpl ( ASSERT (VALID_TPL (NewTpl)); // - // If lowering below HIGH_LEVEL, make sure - // interrupts are enabled - // - - if (OldTpl >= TPL_HIGH_LEVEL && NewTpl < TPL_HIGH_LEVEL) { - gEfiCurrentTpl = TPL_HIGH_LEVEL; - } - - // // Dispatch any pending events // while (gEventPending != 0) { @@ -131,6 +122,10 @@ CoreRestoreTpl ( } gEfiCurrentTpl = PendingTpl; + // + // If lowering below HIGH_LEVEL, make sure + // interrupts are enabled + // if (gEfiCurrentTpl < TPL_HIGH_LEVEL) { CoreSetInterruptState (TRUE); } -- 2.12.2.windows.2