From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=benjamin.you@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2EEF020349D90 for ; Tue, 14 Nov 2017 00:37:53 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2017 00:42:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,393,1505804400"; d="scan'208";a="1243824117" Received: from zyou1-mobl.ccr.corp.intel.com ([10.239.158.165]) by fmsmga002.fm.intel.com with ESMTP; 14 Nov 2017 00:41:35 -0800 From: Benjamin You To: edk2-devel@lists.01.org Cc: Maurice Ma , Prince Agyeman Date: Tue, 14 Nov 2017 16:41:13 +0800 Message-Id: <20171114084113.127904-1-benjamin.you@intel.com> X-Mailer: git-send-email 2.14.3.windows.1 Subject: [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2017 08:37:53 -0000 Since UefiCpuPkg's CpuDxe Driver already adds Local Apic's MMIO space to GCD, CorebootModulePkg's CbSupportDxe should not do this again. Doing this again causes error return status from GCD service, and ASSERT (FALSE) with debug build, so the duplicated addition is removed. Cc: Maurice Ma Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Benjamin You --- CorebootModulePkg/CbSupportDxe/CbSupportDxe.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c b/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c index 24bacf815c..c526c9e871 100755 --- a/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c +++ b/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c @@ -140,9 +140,6 @@ CbDxeEntryPoint ( // // Report MMIO/IO Resources // - Status = CbReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo, 0xFEE00000, SIZE_1MB, 0, SystemTable); // LAPIC - ASSERT_EFI_ERROR (Status); - Status = CbReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo, 0xFEC00000, SIZE_4KB, 0, SystemTable); // IOAPIC ASSERT_EFI_ERROR (Status); -- 2.14.3.windows.1