* [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition
@ 2017-11-14 8:41 Benjamin You
2017-11-14 15:37 ` Ma, Maurice
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin You @ 2017-11-14 8:41 UTC (permalink / raw)
To: edk2-devel; +Cc: Maurice Ma, Prince Agyeman
Since UefiCpuPkg's CpuDxe Driver already adds Local Apic's MMIO space to
GCD, CorebootModulePkg's CbSupportDxe should not do this again. Doing this
again causes error return status from GCD service, and ASSERT (FALSE) with
debug build, so the duplicated addition is removed.
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Benjamin You <benjamin.you@intel.com>
---
CorebootModulePkg/CbSupportDxe/CbSupportDxe.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c b/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c
index 24bacf815c..c526c9e871 100755
--- a/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c
+++ b/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c
@@ -140,9 +140,6 @@ CbDxeEntryPoint (
//
// Report MMIO/IO Resources
//
- Status = CbReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo, 0xFEE00000, SIZE_1MB, 0, SystemTable); // LAPIC
- ASSERT_EFI_ERROR (Status);
-
Status = CbReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo, 0xFEC00000, SIZE_4KB, 0, SystemTable); // IOAPIC
ASSERT_EFI_ERROR (Status);
--
2.14.3.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition
2017-11-14 8:41 [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition Benjamin You
@ 2017-11-14 15:37 ` Ma, Maurice
0 siblings, 0 replies; 2+ messages in thread
From: Ma, Maurice @ 2017-11-14 15:37 UTC (permalink / raw)
To: You, Benjamin, edk2-devel@lists.01.org; +Cc: Agyeman, Prince
Looks good to me.
Reviewed-by: Maurice Ma <maurice.ma@intel.com>
Thanks
Maurice
-----Original Message-----
From: You, Benjamin
Sent: Tuesday, November 14, 2017 12:41 AM
To: edk2-devel@lists.01.org
Cc: Ma, Maurice <maurice.ma@intel.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition
Since UefiCpuPkg's CpuDxe Driver already adds Local Apic's MMIO space to GCD, CorebootModulePkg's CbSupportDxe should not do this again. Doing this again causes error return status from GCD service, and ASSERT (FALSE) with debug build, so the duplicated addition is removed.
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Benjamin You <benjamin.you@intel.com>
---
CorebootModulePkg/CbSupportDxe/CbSupportDxe.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c b/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c
index 24bacf815c..c526c9e871 100755
--- a/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c
+++ b/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c
@@ -140,9 +140,6 @@ CbDxeEntryPoint (
//
// Report MMIO/IO Resources
//
- Status = CbReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo, 0xFEE00000, SIZE_1MB, 0, SystemTable); // LAPIC
- ASSERT_EFI_ERROR (Status);
-
Status = CbReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo, 0xFEC00000, SIZE_4KB, 0, SystemTable); // IOAPIC
ASSERT_EFI_ERROR (Status);
--
2.14.3.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-14 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-14 8:41 [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition Benjamin You
2017-11-14 15:37 ` Ma, Maurice
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox