From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ABBB22034EE26 for ; Thu, 16 Nov 2017 03:55:09 -0800 (PST) Received: by mail-wm0-x241.google.com with SMTP id r68so6043wmr.0 for ; Thu, 16 Nov 2017 03:59:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MeI/QqqC5h/WFMSKe2pU5SoC5g/lCIs6e8YTOx7IJvI=; b=ZrvrLltPehy2UzMT/IXMUz/khEmFvcsvbW1s7VHjYPjtahmOwTpm1u338gKGyMn5eR cqcE9RoNx5s4myD+rgIROTsj0gJEhtjTbzabLtWDy8sqOpwiTa2A2Z0iXkGQ5Xa5CC6S gsrshpq3K4Q6ZBUSrdGvQrWvfE4hGosaQ5qVk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MeI/QqqC5h/WFMSKe2pU5SoC5g/lCIs6e8YTOx7IJvI=; b=plsV+bvcusHJifzmC+kzgvwPzDPx6rX7TBsjwf6Ot2yU4jfVZpifrQ4hWPSVaunPqB 1SPcQid0HUkPY0LYDyT37AJKJN6mmTAjNqcRMTCrM7jBR/hZnXojrWoNe8Ty52EwXi9f n7Tl0OFzr+z7hjCoF9fAId3sSUsshfjenVKFXLTBPIrDu+ECa1hc6yvJq6pNvfefueDB dMcfyn3IXFcqCFko1f4PAmyNg2+D436uwP6Z9LGBjLdyZc1gkH3TqV1QmmAG84wdpYTV w1Wu9KvdSvrO9S0dIROgmXR1vi1wD+bH+9W9G4Wde22TydLKD9chw6CHNKbj8eGlCEDq SV1Q== X-Gm-Message-State: AJaThX7sGv40KPHTtq4FPsR+YuF7+dVXI6IcprAYadFY9Er0P6xF7rUF S2R4WE0sT+GMAF2En1lS5jawog== X-Google-Smtp-Source: AGs4zMYiqc48u0tVijiJcUIgqoxcVV00zIO9KTTyH7PzOpv/pF0nSj6MbS7sqFHGqdI20uzOeHOdPw== X-Received: by 10.28.18.144 with SMTP id 138mr1204663wms.135.1510833557048; Thu, 16 Nov 2017 03:59:17 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v23sm395209wmh.8.2017.11.16.03.59.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Nov 2017 03:59:15 -0800 (PST) Date: Thu, 16 Nov 2017 11:59:14 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Laszlo Ersek Message-ID: <20171116115914.foym7hu3p676foer@bivouac.eciton.net> References: <20171115140319.32570-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] ArmVirtPkg: remove ArmPlatformSysConfigLib dependency X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 11:55:10 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 16, 2017 at 09:40:58AM +0000, Ard Biesheuvel wrote: > On 15 November 2017 at 14:03, Ard Biesheuvel wrote: > > Now that the PL031 RTC driver library no longer depends on the ARM > > platform specific ArmPlatformSysConfigLib, we no longer need to > > implement ArmPlatform.h or have a resolution for that library. > > This allows us to get rid of a rather dodgy practice of including > > platform headers using compiler flags, which is a bad idea at various > > levels. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > PL031 patch is on-list and pending. > > > > ArmVirtPkg/ArmVirtQemu.dsc | 7 ----- > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 6 ---- > > ArmVirtPkg/ArmVirtXen.dsc | 6 ---- > > ArmVirtPkg/Include/ArmPlatform.h | 33 -------------------- > > ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/QemuVirtMem.c | 1 - > > ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/RelocatableVirt.c | 1 - > > ArmVirtPkg/Library/ArmVirtPlatformLib/Virt.c | 1 - > > ArmVirtPkg/Library/ArmVirtPlatformLib/VirtMem.c | 1 - > > ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/RelocatableVirt.c | 1 - > > ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/XenVirtMem.c | 1 - > > ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.c | 7 ++++- > > 11 files changed, 6 insertions(+), 59 deletions(-) > > > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > > index 8a60b61f2aa6..d1b3849d856a 100644 > > --- a/ArmVirtPkg/ArmVirtQemu.dsc > > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > > @@ -49,7 +49,6 @@ [LibraryClasses.common] > > QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf > > > > ArmPlatformLib|ArmVirtPkg/Library/ArmVirtPlatformLib/ArmVirtPlatformLib.inf > > - ArmPlatformSysConfigLib|ArmPlatformPkg/Library/ArmPlatformSysConfigLibNull/ArmPlatformSysConfigLibNull.inf > > > > TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf > > NorFlashPlatformLib|ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.inf > > @@ -71,12 +70,6 @@ [LibraryClasses.common] > > [LibraryClasses.common.UEFI_DRIVER] > > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > > > -[BuildOptions] > > - RVCT:*_*_ARM_PLATFORM_FLAGS == --cpu Cortex-A15 -I$(WORKSPACE)/ArmVirtPkg/Include > > - GCC:*_*_ARM_PLATFORM_FLAGS == -mcpu=cortex-a15 -I$(WORKSPACE)/ArmVirtPkg/Include > > Oops. I will need to retain the -mcpu setting here, or the 'hvc' > instruction will be rejected by the assembler. Don't we have source-level overrides for that? At least ".arch_extension virt" for GNU. / Leif