From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5E36621B00DC1 for ; Thu, 16 Nov 2017 08:20:07 -0800 (PST) Received: by mail-wr0-x242.google.com with SMTP id u40so23279664wrf.10 for ; Thu, 16 Nov 2017 08:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1IrgKPXdfk7kapyHSz+/HgMeIHRXMPUMcKjpRmIcDF0=; b=O0GgUEwA3s3dXujxCQkvQcVqdiBpRzqBGXKoMiiGGut5/BIrJvA+5PWvtCdUBGu2jD ECf+u1AA7dPABl7po2TV2LXbbFVhkK1TES9PIaA6hDzaJsnxauc2LWDRzW5VAWojP67q DHG5gW2++PRJTLz+q0Ag0IeZt5FhY0GzKtCpk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1IrgKPXdfk7kapyHSz+/HgMeIHRXMPUMcKjpRmIcDF0=; b=psH1DYhLngj6mOdIf7qvxYz0qFK59P103wHnBMUoAdBYrsZQyQYG4VgWAe8RszfkaA RJJkVFt/Y60GQ1Ne6RRVqxnmZsp0ur6mopt0vywyOmxxJzYTgi/5d8tuvsAHLJ4Ve9og JUNC8gSBUpg8wboPzq0J2L+Sg9NGsbUytkTYBpqUoRjyJqbGyKVyuTPzTfuSLZzhFxnH /e1SI/bBPNyHtpKU72GdtH1mwb9sLmMt5MGBypRec2GYrBBzXH2p+wQyzZNESihpdEns IeP7xXN7hsp8ofGgDvqNJxwPV1dhZca8L4m18T3s7MaeUHLVqwlLIy78l936drR2LIzV jvyg== X-Gm-Message-State: AJaThX7gUJ6K+q9VKYJlDkEjELZFszC+92L+8d3dXgeHY+dZDxFiP3sp fM/EZRn1Gke1Teo741B51+9xcQ== X-Google-Smtp-Source: AGs4zMYg8rG7UQlm+SUHAaDPekI3yurxvgaK2/FltfZtXJlg24ywYfFgHFxvP8liYtYh4OQdEvTcsQ== X-Received: by 10.223.157.41 with SMTP id k41mr27818wre.281.1510849455785; Thu, 16 Nov 2017 08:24:15 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e131sm2687138wmg.1.2017.11.16.08.24.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Nov 2017 08:24:14 -0800 (PST) Date: Thu, 16 Nov 2017 16:24:12 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, mw@semihalf.com, Pipat Methavanitpong Message-ID: <20171116162412.uupodh3m2msjvm5l@bivouac.eciton.net> References: <20171115111932.22507-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171115111932.22507-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] EmbeddedPkg: add mx66u1g45g nor flash info X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 16:20:07 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 15, 2017 at 11:19:32AM +0000, Ard Biesheuvel wrote: > From: Pipat Methavanitpong > > Add Macronix MX66U1G45G definition to NorFlashInfoLib > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pipat Methavanitpong > Signed-off-by: Ard Biesheuvel > --- > EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > index 750f37a0e8..fb26b4f9bc 100644 > --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > @@ -57,6 +57,7 @@ STATIC CONST NOR_FLASH_INFO NorFlashIds[] = { > {L"mx25l51235f", {0xc2, 0x20, 0x1a}, 3, 256, 64 * 1024, 1024, 0}, > {L"mx25l12855e", {0xc2, 0x26, 0x18}, 3, 256, 64 * 1024, 256, 0}, > {L"mx66u51235f", {0xc2, 0x25, 0x3a}, 3, 256, 64 * 1024, 1024, 0}, > + {L"mx66u1g45g", {0xc2, 0x25, 0x3b}, 3, 256, 64 * 1024, 2048, 0}, > {L"mx66l1g45g", {0xc2, 0x20, 0x1b}, 3, 256, 64 * 1024, 2048, 0}, Hmm, I'm beginning to think we should have figured out a sorting strategy for this table ... oh well. The values match what QEMU uses, so: Reviewed-by: Leif Lindholm > /* SPANSION */ > {L"s25fl008a", {0x01, 0x02, 0x13}, 3, 256, 64 * 1024, 16, 0}, > -- > 2.14.1 >