From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 920BD20359A68 for ; Thu, 16 Nov 2017 09:32:15 -0800 (PST) Received: by mail-wm0-x242.google.com with SMTP id b189so1718175wmd.5 for ; Thu, 16 Nov 2017 09:36:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=z7PxGXmlDJXSyCliRH/eytn/kmYqTJ8AY9LZ8KgcSqg=; b=DJGWSKqCdz34NGR+EIgPdHnM8hap63v7lXCCgfDaUJtGIaNZk5vAPVUK57DrCQQKr8 YUabV/rSgsZvRiZVASiaVmMWsbJ4Z+9+JfGy/f1Bq09M//vGivFDUleHngkHtMDu2JN1 acfh9jtzFAL/nV+RBz3Miz/QwSYQlubZ+ecRw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=z7PxGXmlDJXSyCliRH/eytn/kmYqTJ8AY9LZ8KgcSqg=; b=ovYdFbObypeudW4v8thdyGSMltkvVDjULpz1pHOvJSCBM8H7res2RC+Tsl2i5w72rD hZsM/OozG/jqCGMwGmw4Ja70NlwZYMQNDngRTZ7CfGZ6Z+XozSFPmXsKYmhOm7MWm9e/ ohrC1ejlRP0xea/cMy0xISfpMRm5CQbIwIEZRksIP54wCny5a3cge+dsaFh+Qrw20Zyy OQ8wsvHfl/UBl8/bTlX5eREacKRUZMMNLMfG/hlXvxbyv7FhgSDCVJMu5Sy3agtVpmSh +UPWXTZ6OmcjjdqLxqhkfS/MIHAofZ+5UhPOWCw7AkxHkaGdimw7GqkK5sySHlVrkiiz rnMw== X-Gm-Message-State: AJaThX7/wS+1U0AXbIeQFNZGsTVVu4ukt6Y7HT+CWjJ5585ggV9eWS0X +sNksDkGpjqXCpVJdNenQbPDNw== X-Google-Smtp-Source: AGs4zMZlAE9L6hklThbuibaDID1Gl24V1ixdiI7r7UZZumdp5WvIbIqXyIfXkM1U71F/jwwk0flcOQ== X-Received: by 10.28.184.130 with SMTP id i124mr2132088wmf.85.1510853783803; Thu, 16 Nov 2017 09:36:23 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a71sm1752991wme.33.2017.11.16.09.36.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Nov 2017 09:36:22 -0800 (PST) Date: Thu, 16 Nov 2017 17:36:20 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, lersek@redhat.com Message-ID: <20171116173620.yovvab2cuqiqyr5l@bivouac.eciton.net> References: <20171116171216.7566-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171116171216.7566-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] ArmPlatformPkg ArmVirtPkg: reorganize PL011 code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 17:32:15 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 16, 2017 at 05:12:16PM +0000, Ard Biesheuvel wrote: > The PL011 code in ArmPlatformPkg is organized in a weird way: there is > a single PL011Uart.h header file under Include/Drivers containing both > register definitions and function entry points. The PL011Uart library > itself is in Drivers/ but it is actually a library. > > So let's clean this up: add a new PL011UartLib library class and associated > header file containing only the library prototypes, and move the library > itself under Library/ using a new GUID, with the register definitions moved > into a local header file. > > Note that we need to retain the old implementation for out of tree > platforms, s/need to// Do we need to? I mean, we could, and give a bit of a warning for people to switch over. But does the change actually entail anything more than pointing to the new .inf location? If not, we're just moving the point at which platforms fail and have to modify their .dsc/.fdf. That said, I'm not religiously opposed to a grace period - but I don't want the old version hanging around to get included in the next UDK release. I _would_ prefer to see the ArmVirtPkg change as a separate patch. Especially if the old copy is kept around. Nice bit of cleanup though. / Leif