Re: [PATCH] ArmPlatformPkg ArmVirtPkg: reorganize PL011 code

[Leif Lindholm <leif.lindholm@linaro.org>]

On Thu, Nov 16, 2017 at 05:38:10PM +0000, Ard Biesheuvel wrote:
> On 16 November 2017 at 17:36, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > On Thu, Nov 16, 2017 at 05:12:16PM +0000, Ard Biesheuvel wrote:
> >> The PL011 code in ArmPlatformPkg is organized in a weird way: there is
> >> a single PL011Uart.h header file under Include/Drivers containing both
> >> register definitions and function entry points. The PL011Uart library
> >> itself is in Drivers/ but it is actually a library.
> >>
> >> So let's clean this up: add a new PL011UartLib library class and associated
> >> header file containing only the library prototypes, and move the library
> >> itself under Library/ using a new GUID, with the register definitions moved
> >> into a local header file.
> >>
> >> Note that we need to retain the old implementation for out of tree
> >> platforms,
> >
> > s/need to//
> >
> > Do we need to?
> 
> At least until we switch over edk2-platforms, yes.

Sure, but given the people involved (when available) are the same at
both ends, this kind of thing can be done near-atomically enough that
I'm happy to buy everyone caught out a beer and apologise.

(This is not to be considered further feedback on this set, but
stating an opinion for potential similar situations in future.)

/
    Leif