From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3B7102035A7DA for ; Thu, 16 Nov 2017 10:08:19 -0800 (PST) Received: by mail-wm0-x241.google.com with SMTP id z3so1960102wme.5 for ; Thu, 16 Nov 2017 10:12:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/KPlZhUpQJKXDFPeWD/kDLxoOqbxJetmE4o0BlQzOjo=; b=Hzc9OBTe6PVnK5MiWb4NWMgVztObkjWGe6f+Md4eXUWzzwKbLfxwbbQvHB2z8lZqV/ PSqfTmGe1pdotnOwfuMTX8LAJuuXQ2hnlVVrb+amNCiRueir+/30bJF6zpSNlg+iDFFC crd2BZWnGiqrQFIgbhcsp8/VRb58EL8TMGLlg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/KPlZhUpQJKXDFPeWD/kDLxoOqbxJetmE4o0BlQzOjo=; b=D0X1kIBMPM5oMEm/6NbMlreazePKg0YynjgauTPKJJsA5P3Cjs1EeaeTD8ojXUvWBp M9XAaXT3qQZVTklu5pvsGwQDw4ItHc+W1sJPndAlEM0jHy1xhvvmJQ3vK+rZJhSVJnFs 0bXD6gL36rCyQbAQdAmrFydDz5Rm/RW+rD1ct6bckqWB62AaoUXJRZTmmBk5Z3OiZ2ki rQN6O3EePBv+rUwnRnUuETmeJxrt2VzWoVzQEFHj4UbE3GzqzpE1fbSarBV1Xheb0BCB qVqKNtxoLwMyipJHGivV4QtjDvIs/4/zSOehyRK83hB2OS/9CFH3Ccsdfu1GfHRjBSxc hd8w== X-Gm-Message-State: AJaThX7Bm1FgurTEyRjoppSWe7wVVFLaXUlUYJN+1wvPP1hIjH59RmX3 rrcU7PLu8jkCLekWh4uu6HYOxQ== X-Google-Smtp-Source: AGs4zMbBbDhMneTraBLjkgOSLS2swX1g77IoXZ9APWtj1qnlfu169HGrhZRQCUkdbQVGyx9iBdRacQ== X-Received: by 10.28.103.8 with SMTP id b8mr2432292wmc.70.1510855948464; Thu, 16 Nov 2017 10:12:28 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w76sm3947612wrc.79.2017.11.16.10.12.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Nov 2017 10:12:27 -0800 (PST) Date: Thu, 16 Nov 2017 18:12:25 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Laszlo Ersek Message-ID: <20171116181225.a5onmayzuwbuajns@bivouac.eciton.net> References: <20171116171216.7566-1-ard.biesheuvel@linaro.org> <20171116173620.yovvab2cuqiqyr5l@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] ArmPlatformPkg ArmVirtPkg: reorganize PL011 code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 18:08:20 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 16, 2017 at 05:38:10PM +0000, Ard Biesheuvel wrote: > On 16 November 2017 at 17:36, Leif Lindholm wrote: > > On Thu, Nov 16, 2017 at 05:12:16PM +0000, Ard Biesheuvel wrote: > >> The PL011 code in ArmPlatformPkg is organized in a weird way: there is > >> a single PL011Uart.h header file under Include/Drivers containing both > >> register definitions and function entry points. The PL011Uart library > >> itself is in Drivers/ but it is actually a library. > >> > >> So let's clean this up: add a new PL011UartLib library class and associated > >> header file containing only the library prototypes, and move the library > >> itself under Library/ using a new GUID, with the register definitions moved > >> into a local header file. > >> > >> Note that we need to retain the old implementation for out of tree > >> platforms, > > > > s/need to// > > > > Do we need to? > > At least until we switch over edk2-platforms, yes. Sure, but given the people involved (when available) are the same at both ends, this kind of thing can be done near-atomically enough that I'm happy to buy everyone caught out a beer and apologise. (This is not to be considered further feedback on this set, but stating an opinion for potential similar situations in future.) / Leif