Re: [PATCH edk2-platforms v4 14/34] Silicon/Socionext: add driver for SPI NOR flash

[Leif Lindholm <leif.lindholm@linaro.org>]

On Fri, Nov 10, 2017 at 02:21:07PM +0000, Ard Biesheuvel wrote:
> From: Pipat Methavanitpong <methavanitpong.pipat@socionext.com>
> 
> This imports the driver sources provided by Socionext for the FIP006
> SPI NOR flash device found on SynQuacer SoCs. It has been slightly
> tweaked to bring it up to date with the changes made on the EDK2 side
> since it was forked.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pipat Methavanitpong <methavanitpong.pipat@socionext.com>
> 
> [various tweaks and bugfixes]
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> v4: incorporate feedback from Leif, with the exception of subjective feedback
>     (i.e., 'this function is too long'), addressing of which would make this
>     driver deviate more from the driver it as based on in ArmPlatformPkg,
>     making it less likely we can ever merge these into a unified NOR flash
>     driver.

I accept this, and there is logic to what you say, but I also cannot
with good conscience claim that I have properly (even by my standards)
reviewed the driver. So...
Acked-by: Leif Lindholm <leif.lindholm@linaro.org>
?

(This version is certainly a major improvement on the original
submission.)

/
    Leif