From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 790B220349DAC for ; Fri, 17 Nov 2017 07:04:33 -0800 (PST) Received: by mail-wr0-x241.google.com with SMTP id o14so2367478wrf.9 for ; Fri, 17 Nov 2017 07:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QDkjGG08kJveaxTDnJ008xajc9LWpmetNVrg+Xj0xeM=; b=dH5QXoVAdA9xMMTjUlNM2Cix/t3OEWfxz7QxJMQCWFr+iTzObkLWYOpX2KEfqEjtWL N6DCFtIWXHmocjGxjuiZCyVE4nwMw5pvV7fGmdlhtkLVjCUvfqzg7cY8DAt2OYt6nRzk +gMz0l4X79+jkiRtLXDD7fg0dTfPApC4rtJuY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QDkjGG08kJveaxTDnJ008xajc9LWpmetNVrg+Xj0xeM=; b=PovSkqucq5oe+ZTcnF7Pd0IhDX9Ft8Z7u/eINdE/i5jkg0pi8pC+g0TP71GjC2ZohG Ovhh2vwM0bjbthkktQOwcuNju101n9FJ8Tc8TvLw6nOCsYgPu24bXj703pCoafZzryaV fQBhHMQIrr5AtZluPjvi3EQ2GumKVg9FUKxBbNvtL7+iZfIoJyHEg+8KKaZNcdLfvb22 ovtf1nsKPWVYtajkw3t6Lt66/4PAJghGD0MEoXjD4S1CsM1LBX7byF84aZOv4myllelI FLBdvf/IfAhU/NzxiAY6+hQRzihLQkUPqJfmLWiHOc7UWoPGJ8uClZwzvEmqxU+D+CEi 921w== X-Gm-Message-State: AJaThX6uhYMD0k2h3jiYkrQi8CuIg5C7NdHRNwS1rloQen9ewFy4hl1G +uqDKM+jvhLbVu8Ex+4bSQ6XNg== X-Google-Smtp-Source: AGs4zMZiRPDoXlJL/4JAoXgMZMlWjwIAbHmW6dN38F2JL0Mm2LNey8904qWP9gpaPZ+0t/5XTDcu0g== X-Received: by 10.223.181.131 with SMTP id c3mr4658121wre.198.1510931322403; Fri, 17 Nov 2017 07:08:42 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c54sm6265105wra.84.2017.11.17.07.08.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Nov 2017 07:08:41 -0800 (PST) Date: Fri, 17 Nov 2017 15:08:39 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, daniel.thompson@linaro.org, masami.hiramatsu@linaro.org, methavanitpong.pipat@socionext.com, masahisa.kojima@linaro.org Message-ID: <20171117150839.5kwnpe43xbvokt6u@bivouac.eciton.net> References: <20171110142127.12018-1-ard.biesheuvel@linaro.org> <20171110142127.12018-15-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171110142127.12018-15-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v4 14/34] Silicon/Socionext: add driver for SPI NOR flash X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 15:04:33 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 10, 2017 at 02:21:07PM +0000, Ard Biesheuvel wrote: > From: Pipat Methavanitpong > > This imports the driver sources provided by Socionext for the FIP006 > SPI NOR flash device found on SynQuacer SoCs. It has been slightly > tweaked to bring it up to date with the changes made on the EDK2 side > since it was forked. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pipat Methavanitpong > > [various tweaks and bugfixes] > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > v4: incorporate feedback from Leif, with the exception of subjective feedback > (i.e., 'this function is too long'), addressing of which would make this > driver deviate more from the driver it as based on in ArmPlatformPkg, > making it less likely we can ever merge these into a unified NOR flash > driver. I accept this, and there is logic to what you say, but I also cannot with good conscience claim that I have properly (even by my standards) reviewed the driver. So... Acked-by: Leif Lindholm ? (This version is certainly a major improvement on the original submission.) / Leif