From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 62F052035BB1B for ; Fri, 17 Nov 2017 08:16:20 -0800 (PST) Received: by mail-wm0-x242.google.com with SMTP id l8so7441594wmg.4 for ; Fri, 17 Nov 2017 08:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5IToMGUeT7D4bNssBQUdY7f6OaDE+vEYz7PpfUNCP7k=; b=Ut8COAQuSc+25HaC3er08tAJZO29m4EPm/kzcrof8rn7sdOrZeyRLnyaE3Yi4XcgxF Bocf6yknM7UAlRUJygxyn4/AgxLzI2Tv0qQQ3JEVySj9gONFm4ACuovUPqgNZ7Psu9jo h4kp5SwXQOjPKdvyT1EHZdLLlPJeNAkC3j2Kw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5IToMGUeT7D4bNssBQUdY7f6OaDE+vEYz7PpfUNCP7k=; b=i1ASSwZ9EYHHmIaBa5XtIGUmQpeKovq2FXSXRwRie8wlBMjOSLFfECIgGJhyNVMbxi SHmBffATp4bS06pJ/XVXWQTKdd8dmiWlTt8h6balvys4KQ8jjeqSgtCmTb9SQd7VhbhI U+e0WRI66PEyxI92Zk0e9h1PmlmSwkSE/7+/+9oRW6BaClFZIdSUgG1qEOy87cfqqqyi m1+nqPq3oBGKReVu+Fsaatm5x3B8LxLHBrO/qSihVHUVlZgd/NgS1dQ5szDdmIDPNVIq t5usHGLsbMUg7XsN01OyDfoIuYcnLEsSb+4FymO5CETMeZRJqntZRZ3UkmLvVaeqF/lN qJAg== X-Gm-Message-State: AJaThX7HCrszqge0BVZ3LAOplHVc6saoiVy2rRzBGt4TpsX8NVSC8d1i Pu8//azcOFH3ddMaLGjqEWKE6A== X-Google-Smtp-Source: AGs4zMa5BLjoMgXR/cXVbkXMX/eKvWC0ngzFIc0nOqmM0MOgh2UrL1spw/RNcPZTBK72BQaxRS+f/Q== X-Received: by 10.28.159.15 with SMTP id i15mr4418163wme.58.1510935629624; Fri, 17 Nov 2017 08:20:29 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p200sm3633093wmd.9.2017.11.17.08.20.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Nov 2017 08:20:28 -0800 (PST) Date: Fri, 17 Nov 2017 16:20:26 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, lersek@redhat.com Message-ID: <20171117162026.45dgzazw2scsdlhw@bivouac.eciton.net> References: <20171117160913.17292-1-ard.biesheuvel@linaro.org> <20171117160913.17292-2-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171117160913.17292-2-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 01/15] ArmPlatformPkg/ArmPlatformLibNull: remove bogus PCD dependencies X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 16:16:20 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 17, 2017 at 04:08:59PM +0000, Ard Biesheuvel wrote: > Remove dependencies on gArmTokenSpaceGuid.PcdSystemMemoryBase and > gArmTokenSpaceGuid.PcdSystemMemorySize, the presence of which in > a [FixedPcd] section makes this module unusable for ArmVirtQemu. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Question: shouldn't specifically ArmVirtQemu work fine with these, since it defines them as PcdsFixedAtBuild? Whereas both ArmVirtQemuKernel and ArmVirtXen define them as patchable. / Leif > --- > ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf > index 97b2a4b6e495..e59aef611a3c 100644 > --- a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf > +++ b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf > @@ -41,9 +41,6 @@ [Sources.AArch64] > AArch64/ArmPlatformHelper.S > > [FixedPcd] > - gArmTokenSpaceGuid.PcdSystemMemoryBase > - gArmTokenSpaceGuid.PcdSystemMemorySize > - > gArmTokenSpaceGuid.PcdArmPrimaryCoreMask > gArmTokenSpaceGuid.PcdArmPrimaryCore > > -- > 2.11.0 >