Re: [PATCH 01/15] ArmPlatformPkg/ArmPlatformLibNull: remove bogus PCD dependencies

[Leif Lindholm <leif.lindholm@linaro.org>]

On Fri, Nov 17, 2017 at 04:23:04PM +0000, Ard Biesheuvel wrote:
> On 17 November 2017 at 16:20, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > On Fri, Nov 17, 2017 at 04:08:59PM +0000, Ard Biesheuvel wrote:
> >> Remove dependencies on gArmTokenSpaceGuid.PcdSystemMemoryBase and
> >> gArmTokenSpaceGuid.PcdSystemMemorySize, the presence of which in
> >> a [FixedPcd] section makes this module unusable for ArmVirtQemu.
> >>
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >
> > Question: shouldn't specifically ArmVirtQemu work fine with these,
> > since it defines them as PcdsFixedAtBuild?
> > Whereas both ArmVirtQemuKernel and ArmVirtXen define them as
> > patchable.
> 
> PcdSystemMemorySize is dynamic in ArmVirtQemu, and is the only
> platform that will include this library after this series. The others
> have their own PrePi implementation, allowing me to drop any
> dependencies on ArmPlatformLib altogether.

Right.

Of course I only looked at *Base for ArmVirtQemu.
Never mind.

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

/
    Leif