From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22c; helo=mail-wm0-x22c.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7117F2035BB1B for ; Fri, 17 Nov 2017 08:24:52 -0800 (PST) Received: by mail-wm0-x22c.google.com with SMTP id 5so6374880wmk.1 for ; Fri, 17 Nov 2017 08:29:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+OiyWi8PqBzTzzc5HDOFRS/y6RwBiQh7BNXnuQY+oNE=; b=W5OCHecECGvsp/mr1GG6HJdq4flG22Sc9Y+GCm/TeGu1dCHdUKwZ56LQoxKCustagB 5Yhp4A+VZ/b1465aKNUANVtChTCkZfY1VoZfHKkEVDzypfVPBYTDERnK02Nb5B/6KP+e sECdQ8IgCH6l/+Yc0xLi6HgdU60kPuQyk3hrM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+OiyWi8PqBzTzzc5HDOFRS/y6RwBiQh7BNXnuQY+oNE=; b=gCGNf83cwntrP5WGtRH0XseWNbf6NV0FEuU8s65mpAdr9ABu4Lz1TSSxAoeJsLmO8C qHq9UThUn+db3SluicuJ41q7t0oboiGloOJQ+DAsLlul5E3osNzfSG5GIEdU0QA5Lvj2 vEIU8fAuniyGjk/29CFWraE1bXifPvgBggjVnKajoClH9NHdzGOx/NuTU7nvEN/wzDeX T37QGEM+3b8KhVffBJ8LdNBOpi88DITVgA2A/b+zN71OK7VTZLCWNkfzRqLajgDFne+p K49B+DbhLzq7Ts/rVSrSMzp2Jf3xr+ZDRU4jeOi5Met16tx6CPsZYN+pj+XLkIc+ikiY xhQg== X-Gm-Message-State: AJaThX6Ipe2Q3sZQziN8LFhHWtsaMnfJX6kJM4S6CYwfEZr8vTyWgaFx 32TAxevuhqwb6PXvXWgd7VVIdsE/hKI= X-Google-Smtp-Source: AGs4zMaYcT0bXC3veqWaWg3BbGh6wufXD5mjCid8ZiClYT7zSNefasimxm8kJ+xeaWHBw88AnApzWQ== X-Received: by 10.28.111.218 with SMTP id c87mr4428874wmi.91.1510936141789; Fri, 17 Nov 2017 08:29:01 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g26sm5836455wrb.19.2017.11.17.08.29.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Nov 2017 08:29:00 -0800 (PST) Date: Fri, 17 Nov 2017 16:28:58 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Laszlo Ersek Message-ID: <20171117162858.57cujpgykqhc2mq3@bivouac.eciton.net> References: <20171117160913.17292-1-ard.biesheuvel@linaro.org> <20171117160913.17292-2-ard.biesheuvel@linaro.org> <20171117162026.45dgzazw2scsdlhw@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 01/15] ArmPlatformPkg/ArmPlatformLibNull: remove bogus PCD dependencies X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 16:24:52 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 17, 2017 at 04:23:04PM +0000, Ard Biesheuvel wrote: > On 17 November 2017 at 16:20, Leif Lindholm wrote: > > On Fri, Nov 17, 2017 at 04:08:59PM +0000, Ard Biesheuvel wrote: > >> Remove dependencies on gArmTokenSpaceGuid.PcdSystemMemoryBase and > >> gArmTokenSpaceGuid.PcdSystemMemorySize, the presence of which in > >> a [FixedPcd] section makes this module unusable for ArmVirtQemu. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Ard Biesheuvel > > > > Question: shouldn't specifically ArmVirtQemu work fine with these, > > since it defines them as PcdsFixedAtBuild? > > Whereas both ArmVirtQemuKernel and ArmVirtXen define them as > > patchable. > > PcdSystemMemorySize is dynamic in ArmVirtQemu, and is the only > platform that will include this library after this series. The others > have their own PrePi implementation, allowing me to drop any > dependencies on ArmPlatformLib altogether. Right. Of course I only looked at *Base for ArmVirtQemu. Never mind. Reviewed-by: Leif Lindholm / Leif