From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, evan.lloyd@arm.com
Subject: Re: [PATCH 0/6] Move ArmPlatformPkg stuff into edk2-platforms
Date: Fri, 24 Nov 2017 17:16:57 +0000 [thread overview]
Message-ID: <20171124171657.sf2bauxswxvbtwc5@bivouac.eciton.net> (raw)
In-Reply-To: <20171115142628.10041-1-ard.biesheuvel@linaro.org>
On Wed, Nov 15, 2017 at 02:26:22PM +0000, Ard Biesheuvel wrote:
> This is mostly a preparatory series that will allow us to get rid of a lot
> of code that is specific to only a single ARM development platform out of
> the main EDK2 tree.
>
> First of all, it removes a couple of false dependencies of various platforms
> on libraries that are no longer used, or not actually used by the platform
> in question. Patches #5 and #6 move the bulk of the support for ARM
> development platforms into edk2-platforms.
So, for 1-5/6:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
For 6/6, this heavily clashes with Evan's team's graphics rework
effort. Could you hold off on that a bit?
Evan, what's the status on a v2?
/
Leif
> Ard Biesheuvel (6):
> Platform: remove bogus ArmPlatformSecExtraActionLib references
> Platform: remove bogus ArmTrustedMonitorLib references
> Platform/ArmVExpress-FVP: remove bogus ArmPlatformSecLib reference
> Platform/Hisilicon: remove bogus VExpress dependencies
> Platform/ARM/Juno: import ArmJunoPkg from EDK2
> Platform/ARM/VExpress: import VExpressPkg from EDK2
>
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 4 -
> Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf | 3 +-
> Platform/ARM/JunoPkg/ArmJuno.dec | 48 ++
> Platform/ARM/JunoPkg/ArmJuno.dsc | 8 +-
> Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +-
> Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/AcpiTables.c | 78 ++
> Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 550 ++++++++++++
> Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 88 ++
> Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxeInternal.h | 54 ++
> Platform/ARM/JunoPkg/Include/ArmPlatform.h | 178 ++++
> Platform/ARM/JunoPkg/Library/ArmJunoLib/AArch64/ArmJunoHelper.S | 58 ++
> Platform/ARM/JunoPkg/Library/ArmJunoLib/Arm/ArmJunoHelper.S | 91 ++
> Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | 193 +++++
> Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf | 80 ++
> Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c | 173 ++++
> Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf | 2 +-
> Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c | 68 ++
> Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJunoLib.inf | 33 +
> Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 2 +-
> Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf | 3 +-
> Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 35 +-
> Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf | 10 +-
> Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 19 +-
> Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 2 +-
> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 23 +-
> Platform/ARM/VExpressPkg/ArmVExpressPkg.dec | 53 ++
> Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.c | 90 ++
> Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.inf | 39 +
> Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmHwDxe.c | 38 +
> Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmHwDxe.inf | 37 +
> Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBoot.c | 519 ++++++++++++
> Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBootDxe.inf | 51 ++
> Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c | 133 +++
> Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf | 63 ++
> Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c | 882 ++++++++++++++++++++
> Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c | 393 +++++++++
> Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h | 128 +++
> Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c | 126 +++
> Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf | 59 ++
> Platform/ARM/VExpressPkg/Include/Library/ArmPlatformSysConfigLib.h | 63 ++
> Platform/ARM/VExpressPkg/Include/Platform/CTA15-A7/ArmPlatform.h | 154 ++++
> Platform/ARM/VExpressPkg/Include/Platform/CTA9x4/ArmPlatform.h | 121 +++
> Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h | 79 ++
> Platform/ARM/VExpressPkg/Include/VExpressMotherBoard.h | 140 ++++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/ArmVExpressLib.inf | 54 ++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c | 195 +++++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Helper.S | 81 ++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Helper.asm | 96 +++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Mem.c | 182 ++++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLib.inf | 57 ++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLibSec.inf | 54 ++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4.c | 198 +++++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.S | 49 ++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.asm | 63 ++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c | 119 +++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/AArch64/RTSMHelper.S | 61 ++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/Arm/RTSMHelper.S | 97 +++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/Arm/RTSMHelper.asm | 118 +++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 63 ++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf | 59 ++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c | 209 +++++
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c | 161 ++++
> Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigLib/ArmVExpressSysConfig.c | 273 ++++++
> Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigLib/ArmVExpressSysConfigLib.inf | 35 +
> Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.c | 283 +++++++
> Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.inf | 37 +
> Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 285 +++++++
> Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf | 45 +
> Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpress.c | 84 ++
> Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpressLib.inf | 33 +
> Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 370 ++++++++
> Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf | 44 +
> Platform/ARM/VExpressPkg/Library/ResetSystemLib/ResetSystemLib.c | 111 +++
> Platform/ARM/VExpressPkg/Library/ResetSystemLib/ResetSystemLib.inf | 36 +
> Platform/Hisilicon/D02/Pv660D02.dsc | 3 -
> Platform/Hisilicon/D03/D03.dsc | 5 -
> Platform/Hisilicon/D05/D05.dsc | 4 -
> Platform/Hisilicon/HiKey/HiKey.dsc | 1 -
> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 4 -
> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 4 -
> Silicon/Hisilicon/Hisilicon.dsc.inc | 10 -
> 81 files changed, 8463 insertions(+), 93 deletions(-)
> create mode 100644 Platform/ARM/JunoPkg/ArmJuno.dec
> create mode 100644 Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/AcpiTables.c
> create mode 100644 Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
> create mode 100644 Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
> create mode 100644 Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxeInternal.h
> create mode 100644 Platform/ARM/JunoPkg/Include/ArmPlatform.h
> create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoLib/AArch64/ArmJunoHelper.S
> create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoLib/Arm/ArmJunoHelper.S
> create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c
> create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf
> create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c
> create mode 100644 Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c
> create mode 100644 Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJunoLib.inf
> create mode 100644 Platform/ARM/VExpressPkg/ArmVExpressPkg.dec
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.c
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.inf
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmHwDxe.c
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmHwDxe.inf
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBoot.c
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBootDxe.inf
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c
> create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf
> create mode 100644 Platform/ARM/VExpressPkg/Include/Library/ArmPlatformSysConfigLib.h
> create mode 100644 Platform/ARM/VExpressPkg/Include/Platform/CTA15-A7/ArmPlatform.h
> create mode 100644 Platform/ARM/VExpressPkg/Include/Platform/CTA9x4/ArmPlatform.h
> create mode 100644 Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h
> create mode 100644 Platform/ARM/VExpressPkg/Include/VExpressMotherBoard.h
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/ArmVExpressLib.inf
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Helper.S
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Helper.asm
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Mem.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLib.inf
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLibSec.inf
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.S
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.asm
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/AArch64/RTSMHelper.S
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/Arm/RTSMHelper.S
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/Arm/RTSMHelper.asm
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigLib/ArmVExpressSysConfig.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigLib/ArmVExpressSysConfigLib.inf
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.inf
> create mode 100644 Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf
> create mode 100644 Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpress.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpressLib.inf
> create mode 100644 Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf
> create mode 100644 Platform/ARM/VExpressPkg/Library/ResetSystemLib/ResetSystemLib.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/ResetSystemLib/ResetSystemLib.inf
>
> --
> 2.11.0
>
prev parent reply other threads:[~2017-11-24 17:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 14:26 [PATCH 0/6] Move ArmPlatformPkg stuff into edk2-platforms Ard Biesheuvel
2017-11-15 14:26 ` [PATCH 1/6] Platform: remove bogus ArmPlatformSecExtraActionLib references Ard Biesheuvel
2017-11-15 14:26 ` [PATCH 2/6] Platform: remove bogus ArmTrustedMonitorLib references Ard Biesheuvel
2017-11-15 14:26 ` [PATCH 3/6] Platform/ArmVExpress-FVP: remove bogus ArmPlatformSecLib reference Ard Biesheuvel
2017-11-15 14:26 ` [PATCH 4/6] Platform/Hisilicon: remove bogus VExpress dependencies Ard Biesheuvel
2017-11-15 14:26 ` [PATCH 5/6] Platform/ARM/Juno: import ArmJunoPkg from EDK2 Ard Biesheuvel
2017-11-15 14:26 ` [PATCH 6/6] Platform/ARM/VExpress: import VExpressPkg " Ard Biesheuvel
2017-11-24 17:16 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124171657.sf2bauxswxvbtwc5@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox