From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 151B8220F3C4E for ; Fri, 24 Nov 2017 09:12:43 -0800 (PST) Received: by mail-wm0-x243.google.com with SMTP id x63so23824347wmf.4 for ; Fri, 24 Nov 2017 09:17:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rIYPFgdNn2gTWnGokk2S0bOgKFDcony6BKqV3y3jY4Y=; b=codbGEcrMm1NWQ7fp7z+i8AWuxKvsYGbGL/eHZMBJApjrS/yPPG3i9ddkAqSvIKmFy Jx9rj3yO6B5XXZ34AQpq/Vmo3OZMq6pnKDRhtxceneP8lAoYnoBqa0Zjr/BOYeXVtGCg fJdUYtYnowV0tV/BV/Lq9KPvlCQ0xs2Uvp/Nk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rIYPFgdNn2gTWnGokk2S0bOgKFDcony6BKqV3y3jY4Y=; b=XbTGcBKzE0vBy1xKfWdrTdcjGF6CGOxjzbre3//nY+T3zT3ITpRMLvR5e+LcFmf3pD fkbSdgG3QZKwrlRW9xRv3lUAoTbc/kzU9cI/EPOPrf7wrIOpWXZinOfpa0hqe0dpNzpw PzYa6rinxgmXjMehO+DkTHD/gNTc6yKdo/b+h88i8k+S0c0e1Ef2KzDTdJbBxeKL2iO1 Z4WPnhVptsWafBSzdHGd8G/9CwXaVfm1YWEfKZMwyNXfveny44Fs1IqPFUX2kt+kYEPv EKIjPLOz1HAoAoLNqpHFbyqVd28m5bQFKspLz0KB6yKgkK5EM2SCRiclJP66/W29QZlv oa/w== X-Gm-Message-State: AJaThX7bHqw7PvSl5tZ92i0GWdKCI6Au5pp8295B/s+8ASaxo+TzJP+S xcd8L6VJmFbfhlUfMcQJlScylw== X-Google-Smtp-Source: AGs4zMY7Aq9uaDZ/rVVOHli2pa++2FoUW8cAGGCLKjlIVnf1XjJnjMKlsTv6JXIFRAIDQDKXBTYgWQ== X-Received: by 10.28.210.129 with SMTP id j123mr10990872wmg.52.1511543820899; Fri, 24 Nov 2017 09:17:00 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y15sm44342495wrc.96.2017.11.24.09.16.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Nov 2017 09:16:59 -0800 (PST) Date: Fri, 24 Nov 2017 17:16:57 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, evan.lloyd@arm.com Message-ID: <20171124171657.sf2bauxswxvbtwc5@bivouac.eciton.net> References: <20171115142628.10041-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171115142628.10041-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 0/6] Move ArmPlatformPkg stuff into edk2-platforms X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2017 17:12:44 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 15, 2017 at 02:26:22PM +0000, Ard Biesheuvel wrote: > This is mostly a preparatory series that will allow us to get rid of a lot > of code that is specific to only a single ARM development platform out of > the main EDK2 tree. > > First of all, it removes a couple of false dependencies of various platforms > on libraries that are no longer used, or not actually used by the platform > in question. Patches #5 and #6 move the bulk of the support for ARM > development platforms into edk2-platforms. So, for 1-5/6: Reviewed-by: Leif Lindholm For 6/6, this heavily clashes with Evan's team's graphics rework effort. Could you hold off on that a bit? Evan, what's the status on a v2? / Leif > Ard Biesheuvel (6): > Platform: remove bogus ArmPlatformSecExtraActionLib references > Platform: remove bogus ArmTrustedMonitorLib references > Platform/ArmVExpress-FVP: remove bogus ArmPlatformSecLib reference > Platform/Hisilicon: remove bogus VExpress dependencies > Platform/ARM/Juno: import ArmJunoPkg from EDK2 > Platform/ARM/VExpress: import VExpressPkg from EDK2 > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 4 - > Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf | 3 +- > Platform/ARM/JunoPkg/ArmJuno.dec | 48 ++ > Platform/ARM/JunoPkg/ArmJuno.dsc | 8 +- > Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +- > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/AcpiTables.c | 78 ++ > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 550 ++++++++++++ > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 88 ++ > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxeInternal.h | 54 ++ > Platform/ARM/JunoPkg/Include/ArmPlatform.h | 178 ++++ > Platform/ARM/JunoPkg/Library/ArmJunoLib/AArch64/ArmJunoHelper.S | 58 ++ > Platform/ARM/JunoPkg/Library/ArmJunoLib/Arm/ArmJunoHelper.S | 91 ++ > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | 193 +++++ > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf | 80 ++ > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c | 173 ++++ > Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf | 2 +- > Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c | 68 ++ > Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJunoLib.inf | 33 + > Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 2 +- > Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf | 3 +- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 35 +- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf | 10 +- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 19 +- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 2 +- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 23 +- > Platform/ARM/VExpressPkg/ArmVExpressPkg.dec | 53 ++ > Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.c | 90 ++ > Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.inf | 39 + > Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmHwDxe.c | 38 + > Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmHwDxe.inf | 37 + > Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBoot.c | 519 ++++++++++++ > Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBootDxe.inf | 51 ++ > Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c | 133 +++ > Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf | 63 ++ > Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c | 882 ++++++++++++++++++++ > Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c | 393 +++++++++ > Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h | 128 +++ > Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c | 126 +++ > Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf | 59 ++ > Platform/ARM/VExpressPkg/Include/Library/ArmPlatformSysConfigLib.h | 63 ++ > Platform/ARM/VExpressPkg/Include/Platform/CTA15-A7/ArmPlatform.h | 154 ++++ > Platform/ARM/VExpressPkg/Include/Platform/CTA9x4/ArmPlatform.h | 121 +++ > Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h | 79 ++ > Platform/ARM/VExpressPkg/Include/VExpressMotherBoard.h | 140 ++++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/ArmVExpressLib.inf | 54 ++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c | 195 +++++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Helper.S | 81 ++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Helper.asm | 96 +++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Mem.c | 182 ++++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLib.inf | 57 ++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLibSec.inf | 54 ++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4.c | 198 +++++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.S | 49 ++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.asm | 63 ++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c | 119 +++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/AArch64/RTSMHelper.S | 61 ++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/Arm/RTSMHelper.S | 97 +++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/Arm/RTSMHelper.asm | 118 +++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 63 ++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf | 59 ++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c | 209 +++++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c | 161 ++++ > Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigLib/ArmVExpressSysConfig.c | 273 ++++++ > Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigLib/ArmVExpressSysConfigLib.inf | 35 + > Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.c | 283 +++++++ > Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.inf | 37 + > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 285 +++++++ > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf | 45 + > Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpress.c | 84 ++ > Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpressLib.inf | 33 + > Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 370 ++++++++ > Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf | 44 + > Platform/ARM/VExpressPkg/Library/ResetSystemLib/ResetSystemLib.c | 111 +++ > Platform/ARM/VExpressPkg/Library/ResetSystemLib/ResetSystemLib.inf | 36 + > Platform/Hisilicon/D02/Pv660D02.dsc | 3 - > Platform/Hisilicon/D03/D03.dsc | 5 - > Platform/Hisilicon/D05/D05.dsc | 4 - > Platform/Hisilicon/HiKey/HiKey.dsc | 1 - > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 4 - > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 4 - > Silicon/Hisilicon/Hisilicon.dsc.inc | 10 - > 81 files changed, 8463 insertions(+), 93 deletions(-) > create mode 100644 Platform/ARM/JunoPkg/ArmJuno.dec > create mode 100644 Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/AcpiTables.c > create mode 100644 Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > create mode 100644 Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf > create mode 100644 Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxeInternal.h > create mode 100644 Platform/ARM/JunoPkg/Include/ArmPlatform.h > create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoLib/AArch64/ArmJunoHelper.S > create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoLib/Arm/ArmJunoHelper.S > create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c > create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf > create mode 100644 Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c > create mode 100644 Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c > create mode 100644 Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJunoLib.inf > create mode 100644 Platform/ARM/VExpressPkg/ArmVExpressPkg.dec > create mode 100644 Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.inf > create mode 100644 Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmHwDxe.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmHwDxe.inf > create mode 100644 Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBoot.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBootDxe.inf > create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf > create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h > create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf > create mode 100644 Platform/ARM/VExpressPkg/Include/Library/ArmPlatformSysConfigLib.h > create mode 100644 Platform/ARM/VExpressPkg/Include/Platform/CTA15-A7/ArmPlatform.h > create mode 100644 Platform/ARM/VExpressPkg/Include/Platform/CTA9x4/ArmPlatform.h > create mode 100644 Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h > create mode 100644 Platform/ARM/VExpressPkg/Include/VExpressMotherBoard.h > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/ArmVExpressLib.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Helper.S > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Helper.asm > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Mem.c > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLib.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLibSec.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4.c > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.S > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.asm > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/AArch64/RTSMHelper.S > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/Arm/RTSMHelper.S > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/Arm/RTSMHelper.asm > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigLib/ArmVExpressSysConfig.c > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigLib/ArmVExpressSysConfigLib.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.c > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > create mode 100644 Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpress.c > create mode 100644 Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpressLib.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > create mode 100644 Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/ResetSystemLib/ResetSystemLib.c > create mode 100644 Platform/ARM/VExpressPkg/Library/ResetSystemLib/ResetSystemLib.inf > > -- > 2.11.0 >