From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH edk2-platforms 0/4] Platform/ARM: import BdsLib and FdtPlatformDxe
Date: Sat, 25 Nov 2017 13:28:37 +0000 [thread overview]
Message-ID: <20171125132837.mbpwfykf4of7q3cy@bivouac.eciton.net> (raw)
In-Reply-To: <20171120113714.21856-1-ard.biesheuvel@linaro.org>
On Mon, Nov 20, 2017 at 11:37:10AM +0000, Ard Biesheuvel wrote:
> The only remnant of the deprecated ARM BDS in EDK2 is its BdsLib, which is
> depended upon by FdtPlatformDxe in EmbeddedPkg, which itself is something
> we'd prefer to get rid of. Since only TC2 and Juno actually use this driver,
> let's move both FdtPlatformDxe and BdsLib under Platform/ARM, so that we can
> remove it from the main EDK2 repository.
I see no issue with this series as such (and agree with its intent).
However, on the EDK2 side, we still have some users of BdsLib in the
EmbeddedPkg Android loaders.
(I have sent out a trivial series to get rid of these, but this move
should be ordered against that set.)
Once that's in, for the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
/
Leif
> Ard Biesheuvel (4):
> Platform/ARM: import BdsLib from ArmPkg
> Platform/ARM: import FdtPlatformDxe driver from EDK2
> Platform/ARM/Juno: move to migrated FdtPlatformDxe
> Platform/TC2: move to private FdtPlatformDxe implementation
>
> Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.c | 461 +++++++
> Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.h | 174 +++
> Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.dec | 31 +
> Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 65 +
> Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni | 109 ++
> Platform/ARM/Drivers/FdtPlatformDxe/README.txt | 72 +
> Platform/ARM/Drivers/FdtPlatformDxe/ShellDumpFdt.c | 279 ++++
> Platform/ARM/Drivers/FdtPlatformDxe/ShellSetFdt.c | 468 +++++++
> Platform/ARM/JunoPkg/ArmJuno.dsc | 6 +-
> Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +-
> Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 3 +-
> Platform/ARM/Library/BdsLib/BdsAppLoader.c | 253 ++++
> Platform/ARM/Library/BdsLib/BdsFilePath.c | 1413 ++++++++++++++++++++
> Platform/ARM/Library/BdsLib/BdsHelper.c | 183 +++
> Platform/ARM/Library/BdsLib/BdsInternal.h | 111 ++
> Platform/ARM/Library/BdsLib/BdsLib.inf | 62 +
> Platform/ARM/Library/BdsLib/BdsLoadOption.c | 272 ++++
> Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 6 +-
> Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf | 2 +-
> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 5 +-
> 20 files changed, 3964 insertions(+), 13 deletions(-)
> create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.c
> create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.h
> create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.dec
> create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf
> create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni
> create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/README.txt
> create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/ShellDumpFdt.c
> create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/ShellSetFdt.c
> create mode 100644 Platform/ARM/Library/BdsLib/BdsAppLoader.c
> create mode 100644 Platform/ARM/Library/BdsLib/BdsFilePath.c
> create mode 100644 Platform/ARM/Library/BdsLib/BdsHelper.c
> create mode 100644 Platform/ARM/Library/BdsLib/BdsInternal.h
> create mode 100644 Platform/ARM/Library/BdsLib/BdsLib.inf
> create mode 100644 Platform/ARM/Library/BdsLib/BdsLoadOption.c
>
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-11-25 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 11:37 [PATCH edk2-platforms 0/4] Platform/ARM: import BdsLib and FdtPlatformDxe Ard Biesheuvel
2017-11-20 11:37 ` [PATCH edk2-platforms 1/4] Platform/ARM: import BdsLib from ArmPkg Ard Biesheuvel
2017-11-20 11:37 ` [PATCH edk2-platforms 2/4] Platform/ARM: import FdtPlatformDxe driver from EDK2 Ard Biesheuvel
2017-11-20 11:37 ` [PATCH edk2-platforms 3/4] Platform/ARM/Juno: move to migrated FdtPlatformDxe Ard Biesheuvel
2017-11-20 11:37 ` [PATCH edk2-platforms 4/4] Platform/TC2: move to private FdtPlatformDxe implementation Ard Biesheuvel
2017-11-25 13:28 ` Leif Lindholm [this message]
2017-11-26 10:41 ` [PATCH edk2-platforms 0/4] Platform/ARM: import BdsLib and FdtPlatformDxe Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171125132837.mbpwfykf4of7q3cy@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox