From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B9E3A21A10969 for ; Sat, 25 Nov 2017 05:24:21 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id x63so26927869wmf.4 for ; Sat, 25 Nov 2017 05:28:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yS6FLTP4bP7L/3IhphZFFb3C6KIdaHecQujCDHK6y1E=; b=I/NuAw8+xe/8CAHAMlUHkCf/Hfs5lM0nsrs5/8G03jnStLlcFM4e39n+YCIzeL5MYc eUkcbWq0ZDaiFOy82WoAn9EXz1tN4PAx+iX6hpV6FEiTO5Q221F0LML9IUPyzJgqcdAX jUvegCmdqaQoGLT9n3/9GI+yf33g61lzavBx8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yS6FLTP4bP7L/3IhphZFFb3C6KIdaHecQujCDHK6y1E=; b=Yenknclxi30XENUwGleW+q9/Nw8inK26yyjIEBPPayhcEjWTg1Bf19vSn+A4vyFWtp UQ+eiilqdNCKCDudRk/VCO69hzjOk56GNjze9YKIEWzcvjjpLTMac2mi/RFDjw3xQO0I ZXNwE5epXV56lUeXPNfCV4ien+zudFiWIIBqaHcz8PBMBmv3U2GeQf7pQ/nVgCdg/DaR 9oaLbzN7B4QDbeinkGZXDo3wLDC2RSzen3IebOIMowrzFDXLJzU/p+PL6ko56wx4cMQr kt/1L861FQWDvaxkp9HhG71GzgclJXbDYkrNZv4Rub6pK8xcbqMM7e27xQzCYxJWn3Zy vsAw== X-Gm-Message-State: AJaThX7GS5ziVnjIm1+nL9Pj9su5/YZSSgPQP5E9JvhjTO1iPkzTx3Ps 5u23/wmQlQJPyqp3spS+URt9WgZB75o= X-Google-Smtp-Source: AGs4zMbGjJKFsvklnbqd3l8Iy9GgCKszr5ga3tNWfoJREXF9TfBUFRUixqHBSz3cv1wP8PHB5BD5UQ== X-Received: by 10.28.218.70 with SMTP id r67mr11661036wmg.14.1511616520088; Sat, 25 Nov 2017 05:28:40 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f140sm11299522wmd.27.2017.11.25.05.28.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Nov 2017 05:28:38 -0800 (PST) Date: Sat, 25 Nov 2017 13:28:37 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20171125132837.mbpwfykf4of7q3cy@bivouac.eciton.net> References: <20171120113714.21856-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171120113714.21856-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 0/4] Platform/ARM: import BdsLib and FdtPlatformDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2017 13:24:22 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 20, 2017 at 11:37:10AM +0000, Ard Biesheuvel wrote: > The only remnant of the deprecated ARM BDS in EDK2 is its BdsLib, which is > depended upon by FdtPlatformDxe in EmbeddedPkg, which itself is something > we'd prefer to get rid of. Since only TC2 and Juno actually use this driver, > let's move both FdtPlatformDxe and BdsLib under Platform/ARM, so that we can > remove it from the main EDK2 repository. I see no issue with this series as such (and agree with its intent). However, on the EDK2 side, we still have some users of BdsLib in the EmbeddedPkg Android loaders. (I have sent out a trivial series to get rid of these, but this move should be ordered against that set.) Once that's in, for the series: Reviewed-by: Leif Lindholm / Leif > Ard Biesheuvel (4): > Platform/ARM: import BdsLib from ArmPkg > Platform/ARM: import FdtPlatformDxe driver from EDK2 > Platform/ARM/Juno: move to migrated FdtPlatformDxe > Platform/TC2: move to private FdtPlatformDxe implementation > > Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.c | 461 +++++++ > Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.h | 174 +++ > Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.dec | 31 + > Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 65 + > Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni | 109 ++ > Platform/ARM/Drivers/FdtPlatformDxe/README.txt | 72 + > Platform/ARM/Drivers/FdtPlatformDxe/ShellDumpFdt.c | 279 ++++ > Platform/ARM/Drivers/FdtPlatformDxe/ShellSetFdt.c | 468 +++++++ > Platform/ARM/JunoPkg/ArmJuno.dsc | 6 +- > Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +- > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 3 +- > Platform/ARM/Library/BdsLib/BdsAppLoader.c | 253 ++++ > Platform/ARM/Library/BdsLib/BdsFilePath.c | 1413 ++++++++++++++++++++ > Platform/ARM/Library/BdsLib/BdsHelper.c | 183 +++ > Platform/ARM/Library/BdsLib/BdsInternal.h | 111 ++ > Platform/ARM/Library/BdsLib/BdsLib.inf | 62 + > Platform/ARM/Library/BdsLib/BdsLoadOption.c | 272 ++++ > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 6 +- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf | 2 +- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 5 +- > 20 files changed, 3964 insertions(+), 13 deletions(-) > create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.c > create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatform.h > create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.dec > create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf > create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni > create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/README.txt > create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/ShellDumpFdt.c > create mode 100644 Platform/ARM/Drivers/FdtPlatformDxe/ShellSetFdt.c > create mode 100644 Platform/ARM/Library/BdsLib/BdsAppLoader.c > create mode 100644 Platform/ARM/Library/BdsLib/BdsFilePath.c > create mode 100644 Platform/ARM/Library/BdsLib/BdsHelper.c > create mode 100644 Platform/ARM/Library/BdsLib/BdsInternal.h > create mode 100644 Platform/ARM/Library/BdsLib/BdsLib.inf > create mode 100644 Platform/ARM/Library/BdsLib/BdsLoadOption.c > > -- > 2.11.0 >