From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH 0/2] remove ARM BdsLib and FdtPlatformDxe
Date: Sat, 25 Nov 2017 13:38:01 +0000 [thread overview]
Message-ID: <20171125133801.ctcnwquugi3dpbjt@bivouac.eciton.net> (raw)
In-Reply-To: <20171120114505.22344-1-ard.biesheuvel@linaro.org>
On Mon, Nov 20, 2017 at 11:45:03AM +0000, Ard Biesheuvel wrote:
> Remove two pieces of legacy that are only used by platforms residing under
> Platform/ARM in edk2-platforms, and really shouldn't serve as examples for
> new contributions. So after migrating the code to edk2-platforms, remove it
> from EDK2.
1/2 should also delete
---
# FDT installation
EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf {
<LibraryClasses>
# It depends on BdsLib that depends on TimerLib
TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
}
---
from EmbeddedPkg/EmbeddedPkg.dsc
and 2/2 should delete the
---
BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf
---
resolution from the same file.
2/2 should also delete the BdsLib references from ArmPkg/ArmPkg.dsc:
---
[LibraryClasses.common]
BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf
---
and
---
[Components.common]
ArmPkg/Library/BdsLib/BdsLib.inf
---
And both should be ordered after the Android*Boot patches I just sent out.
If you do that, and fold in the above comments:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> Ard Biesheuvel (2):
> EmbeddedPkg: remove FdtPlatformDxe
> ArmPkg: remove BdsLib and remaining ARM BDS related PCDs
>
> ArmPkg/ArmPkg.dec | 8 -
> ArmPkg/Library/BdsLib/BdsAppLoader.c | 253 ----
> ArmPkg/Library/BdsLib/BdsFilePath.c | 1411 --------------------
> ArmPkg/Library/BdsLib/BdsHelper.c | 183 ---
> ArmPkg/Library/BdsLib/BdsInternal.h | 111 --
> ArmPkg/Library/BdsLib/BdsLib.inf | 69 -
> ArmPkg/Library/BdsLib/BdsLoadOption.c | 272 ----
> BeagleBoardPkg/BeagleBoardPkg.dsc | 3 -
> EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c | 461 -------
> EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h | 174 ---
> EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 64 -
> EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni | 109 --
> EmbeddedPkg/Drivers/FdtPlatformDxe/README.txt | 72 -
> EmbeddedPkg/Drivers/FdtPlatformDxe/ShellDumpFdt.c | 279 ----
> EmbeddedPkg/Drivers/FdtPlatformDxe/ShellSetFdt.c | 468 -------
> EmbeddedPkg/EmbeddedPkg.dec | 6 -
> 16 files changed, 3943 deletions(-)
> delete mode 100644 ArmPkg/Library/BdsLib/BdsAppLoader.c
> delete mode 100644 ArmPkg/Library/BdsLib/BdsFilePath.c
> delete mode 100644 ArmPkg/Library/BdsLib/BdsHelper.c
> delete mode 100644 ArmPkg/Library/BdsLib/BdsInternal.h
> delete mode 100644 ArmPkg/Library/BdsLib/BdsLib.inf
> delete mode 100644 ArmPkg/Library/BdsLib/BdsLoadOption.c
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/README.txt
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/ShellDumpFdt.c
> delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/ShellSetFdt.c
>
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-11-25 13:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 11:45 [PATCH 0/2] remove ARM BdsLib and FdtPlatformDxe Ard Biesheuvel
2017-11-20 11:45 ` [PATCH 1/2] EmbeddedPkg: remove FdtPlatformDxe Ard Biesheuvel
2017-11-20 11:45 ` [PATCH 2/2] ArmPkg: remove BdsLib and remaining ARM BDS related PCDs Ard Biesheuvel
2017-11-25 13:38 ` Leif Lindholm [this message]
2017-11-26 11:28 ` [PATCH 0/2] remove ARM BdsLib and FdtPlatformDxe Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171125133801.ctcnwquugi3dpbjt@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox