From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 222FD21A10969 for ; Sat, 25 Nov 2017 05:33:45 -0800 (PST) Received: by mail-wm0-x243.google.com with SMTP id x63so26549019wmf.2 for ; Sat, 25 Nov 2017 05:38:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YmYxzvlNdGybubNJr7b8tl8hto2NSSu4pg/1/piH6Kg=; b=ZI51oj8UggEPYLF43I3TgPkBdO06d31VY57sPX+jtA7WWRrBPhXIDSv5XTRqATqYLR gt2Fjg5iicMzlT9PO3iinA+DQ2fTEnulKIO/9fZVOj8CWnFjLQY51wR7MewFWZ+mjMKy 4VtyeW1yGOszJIq27G1XyBLPi94yxU3/EVQnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YmYxzvlNdGybubNJr7b8tl8hto2NSSu4pg/1/piH6Kg=; b=OA0gveioiWmEBVXYEUgHY8oP40ARoEUctp6G9DMurq6Ttg7tw2dToF0KjG9yFKhEId vkaljPm+fAcmOvP53kIF37HAsTxrO1gp9GWu2JgMQSY8gyfB+wqb7DNC1Tcue1Dc8lE4 OZyRQM0E4NA1kgxbyAcurUKmwDpqLJdzJ44G9l0WZ7VZpcjOex5cTj9zdPXi8KB1MPnU EQdVSimjEtLBuctlUAeEAmkK1pxIsBM0JdQKDVpyL6zaEyVeRElPIsOKjueYScgGP6iI XG4nPi4ziyUso+uCTEMi5qVm5cDA245AmER3/lN7fMJjgndPOugW2AgpE54vRRA0gqyj PGRw== X-Gm-Message-State: AJaThX5XWmVIc4sWpyTIkcC1FXWxlOVSPc33S0cHqfiOy35nS/TSFCIB kvkcYN0d5nbD+/5GxuLU6TjgVEHxJng= X-Google-Smtp-Source: AGs4zMYnvGXVMPCRFdrf1H3sEal0XzA1TmeNX1Z6GtgiGICD7jdKviyQY3Wv6x4BiBttYL7yctf7qg== X-Received: by 10.28.104.6 with SMTP id d6mr12415192wmc.101.1511617084374; Sat, 25 Nov 2017 05:38:04 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j10sm11579651wrh.32.2017.11.25.05.38.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Nov 2017 05:38:03 -0800 (PST) Date: Sat, 25 Nov 2017 13:38:01 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20171125133801.ctcnwquugi3dpbjt@bivouac.eciton.net> References: <20171120114505.22344-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171120114505.22344-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 0/2] remove ARM BdsLib and FdtPlatformDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2017 13:33:46 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 20, 2017 at 11:45:03AM +0000, Ard Biesheuvel wrote: > Remove two pieces of legacy that are only used by platforms residing under > Platform/ARM in edk2-platforms, and really shouldn't serve as examples for > new contributions. So after migrating the code to edk2-platforms, remove it > from EDK2. 1/2 should also delete --- # FDT installation EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf { # It depends on BdsLib that depends on TimerLib TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf } --- from EmbeddedPkg/EmbeddedPkg.dsc and 2/2 should delete the --- BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf --- resolution from the same file. 2/2 should also delete the BdsLib references from ArmPkg/ArmPkg.dsc: --- [LibraryClasses.common] BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf --- and --- [Components.common] ArmPkg/Library/BdsLib/BdsLib.inf --- And both should be ordered after the Android*Boot patches I just sent out. If you do that, and fold in the above comments: Reviewed-by: Leif Lindholm > Ard Biesheuvel (2): > EmbeddedPkg: remove FdtPlatformDxe > ArmPkg: remove BdsLib and remaining ARM BDS related PCDs > > ArmPkg/ArmPkg.dec | 8 - > ArmPkg/Library/BdsLib/BdsAppLoader.c | 253 ---- > ArmPkg/Library/BdsLib/BdsFilePath.c | 1411 -------------------- > ArmPkg/Library/BdsLib/BdsHelper.c | 183 --- > ArmPkg/Library/BdsLib/BdsInternal.h | 111 -- > ArmPkg/Library/BdsLib/BdsLib.inf | 69 - > ArmPkg/Library/BdsLib/BdsLoadOption.c | 272 ---- > BeagleBoardPkg/BeagleBoardPkg.dsc | 3 - > EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c | 461 ------- > EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h | 174 --- > EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 64 - > EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni | 109 -- > EmbeddedPkg/Drivers/FdtPlatformDxe/README.txt | 72 - > EmbeddedPkg/Drivers/FdtPlatformDxe/ShellDumpFdt.c | 279 ---- > EmbeddedPkg/Drivers/FdtPlatformDxe/ShellSetFdt.c | 468 ------- > EmbeddedPkg/EmbeddedPkg.dec | 6 - > 16 files changed, 3943 deletions(-) > delete mode 100644 ArmPkg/Library/BdsLib/BdsAppLoader.c > delete mode 100644 ArmPkg/Library/BdsLib/BdsFilePath.c > delete mode 100644 ArmPkg/Library/BdsLib/BdsHelper.c > delete mode 100644 ArmPkg/Library/BdsLib/BdsInternal.h > delete mode 100644 ArmPkg/Library/BdsLib/BdsLib.inf > delete mode 100644 ArmPkg/Library/BdsLib/BdsLoadOption.c > delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c > delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h > delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf > delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni > delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/README.txt > delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/ShellDumpFdt.c > delete mode 100644 EmbeddedPkg/Drivers/FdtPlatformDxe/ShellSetFdt.c > > -- > 2.11.0 >