From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BE05421A10967 for ; Sat, 25 Nov 2017 06:12:05 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id x63so27059016wmf.4 for ; Sat, 25 Nov 2017 06:16:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nSFXql2QL07x2NX7e4Cu9RBMUOtW2Tpzc3PLBVT7CM0=; b=i63DmsOmhT9k6q1ZfPug5un1Yj+CnYBNFSUvtx6zg9EXbCxbls7m/+4q1Pm5ac2NqU Rg2XSmVG7IF9jnX4Xo3IU/zERu032weNA9GYh5BIBj167GWfchspyFXXlxiLg/JfDTNN fed6e+36IDGQmNr55iVGGsFZgDDU8uJgWtEm8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nSFXql2QL07x2NX7e4Cu9RBMUOtW2Tpzc3PLBVT7CM0=; b=FJWldZX1QAOsGO9B4aXi5cjvn90SGKUbDZzanNhsYPagut7lLZ+xDBkuA+VeYeeLXG gsyVIcPkM+DooaYxpB4pweaGKhFKa6laYjJYibRVlfMH2zFAs4MAn7YBtFopQ5IG3tD0 4XvCYRzRCogXK7eIwVoEoBEFLh9Y1TKSqR6yonkFjWvqS/yumJpAaOGCJNYW1RdAqwgX wc58wtNX7Wj+gsRDazK3tiy8Hc64kY8guKCSYI/L8R9xVhn5Z6cR93qNyD6kwxJHtlcg w3jIyx7Ksh0sSMTeQzefZ5kTblUkwZuev8Bxmc8zJ7w9A9S2M5YnsfZqNgVkR0m7DAU/ tB9Q== X-Gm-Message-State: AJaThX5j56XKw/aHTdMSHKDfXVCPL+Uc6GrEtkaMbe/g0VNW/DyNASRy ON1FrxQ1E1Aa0RRpWsAYeRC2sg== X-Google-Smtp-Source: AGs4zMZXgDlP9ZOv8ZHIVUXGDCpcKviGjU2mToccMZtknrNBY2E4QamqN9ZvJs0CQ77sVQOhfppW+g== X-Received: by 10.28.54.3 with SMTP id d3mr12953014wma.79.1511619383982; Sat, 25 Nov 2017 06:16:23 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 68sm15686609wmh.2.2017.11.25.06.16.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Nov 2017 06:16:22 -0800 (PST) Date: Sat, 25 Nov 2017 14:16:21 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171125141621.xusgefgfdz7ydjy6@bivouac.eciton.net> References: <1511246781-7073-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1511246781-7073-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 0/4] Armada 7k/8k variable support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2017 14:12:06 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 21, 2017 at 07:46:17AM +0100, Marcin Wojtas wrote: > Hi, > > I submit v2 of the Armada variable support with the style of > the MvFvbDxe driver fixed and other minor modifications. Depex > configuration was moved from 4/4 to previous patches. Details > can be found in the changelog and commit messages. > > Patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/var-upstream-r20171121 > > I'm looking forward to the comments or remarks. For 2-4/4: Reviewed-by: Leif Lindholm > Best regards, > Marcin > > Changelog: > v1 -> v2: > * Change patches order in order to safely apply related Depex modifications > > * 1/4: > - Fix style (line breaking, openining brackets, alignment, typos) > - Rework MvFvbSetAttributes - because it can return only EFI_SUCCESS / > EFI_INVALID_PARAMETER and should return FVB attributes, > add debug information, that operation is not supported and return > default values via MvFvbGetAttributes. > - Return EFI_SUCCESS, in case NumBytes == 0 in MvFvbRead. > > * 2/4: > - Move Depex configuration from 4/4 > > * 3/4: > - Move Depex configuration from 4/4 > - Reword and break commit message. > > * 4/4: > - Remove Depex configuration > > Marcin Wojtas (4): > Platform/Marvell: Introduce MvFvbDxe variable support driver > Marvell/Drivers: MvSpiFlash: Enable using driver in RT > Marvell/Drivers: MvSpiDxe: Enable using driver in RT > Marvell/Armada: Enable variables support > > Platform/Marvell/Armada/Armada.dsc.inc | 25 +- > Platform/Marvell/Armada/Armada70x0.fdf | 6 +- > Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c | 58 +- > Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.h | 1 + > Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.inf | 11 +- > Platform/Marvell/Drivers/Spi/MvSpiDxe.c | 50 +- > Platform/Marvell/Drivers/Spi/MvSpiDxe.h | 2 + > Platform/Marvell/Drivers/Spi/MvSpiDxe.inf | 9 +- > Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.c | 1056 ++++++++++++++++++++ > Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.h | 114 +++ > Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.inf | 91 ++ > Platform/Marvell/Include/Protocol/Spi.h | 7 + > Platform/Marvell/Marvell.dec | 4 + > 13 files changed, 1420 insertions(+), 14 deletions(-) > create mode 100644 Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.c > create mode 100644 Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.h > create mode 100644 Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.inf > > -- > 2.7.4 >