From: Leif Lindholm <leif.lindholm@linaro.org>
To: kalyan-nagabhirava <kalyankumar.nagabhirava@linaro.org>
Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org,
mark.gregotski@linaro.org, peter.griffin@linaro.org
Subject: Re: [PATCH] [edk2-platforms]: Adding usb Host driver support from OpenPlatformPkg hikey-wip branch
Date: Sat, 25 Nov 2017 15:00:54 +0000 [thread overview]
Message-ID: <20171125150054.jmtoywmfwmkzstfg@bivouac.eciton.net> (raw)
In-Reply-To: <20171120102544.21532-1-kalyankumar.nagabhirava@linaro.org>
Hi Kalyan,
This is a huge (and much appreciated) contribution.
However, in order to simplify reviewing, could you please:
1) Configure your edk2-platforms clone as described in
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contributor-workflow
(step 5 onwards)
2) Split this patch up into
1) DwUsbDxe
2) DwUsbHostDxe
3) HiKey-specific changes/additions.
It would probably also be worth cc:ing Jeremy Linton
(Jeremy.Linton@arm.com) on this set.
For some early high-level feedback:
* I see you have included UncachedMemoryAllocationLib under HiKey.
We did delete that library for a reason - it does not really do what
people seem to think it does.
Ard: could you pitch in with a more suitable solution?
* The DwNonPci module is not really part of the generic driver, but
something that could be integrated somewhere in the platform
initialization (HiKeylib?).
Best Regards,
Leif
On Mon, Nov 20, 2017 at 03:55:44PM +0530, kalyan-nagabhirava wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: kalyan-nagabhirava <kalyankumar.nagabhirava@linaro.org>
> ---
> Platform/Hisilicon/HiKey/HiKey.dec | 4 +
> Platform/Hisilicon/HiKey/HiKey.dsc | 11 +
> Platform/Hisilicon/HiKey/HiKey.fdf | 3 +
> .../Include/Library/UncachedMemoryAllocationLib.h | 665 ++++++
> .../Hisilicon/HiKey/Library/ArmDmaLib/ArmDmaLib.c | 342 +++
> .../HiKey/Library/ArmDmaLib/ArmDmaLib.inf | 50 +
> .../UncachedMemoryAllocationLib.c | 692 ++++++
> .../UncachedMemoryAllocationLib.inf | 45 +
> Silicon/Synopsys/Usb/DwNonPci/DwNonPciUsbDxe.inf | 47 +
> Silicon/Synopsys/Usb/DwNonPci/InitController.c | 37 +
> Silicon/Synopsys/Usb/DwUsbDxe/ComponentName.c | 244 ++
> Silicon/Synopsys/Usb/DwUsbDxe/ComponentName.h | 148 ++
> Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.c | 2324 ++++++++++++++++++++
> Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.dec | 42 +
> Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.h | 534 +++++
> Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.inf | 60 +
> Silicon/Synopsys/Usb/DwUsbHostDxe/ComponentName.c | 243 ++
> Silicon/Synopsys/Usb/DwUsbHostDxe/ComponentName.h | 148 ++
> Silicon/Synopsys/Usb/DwUsbHostDxe/DwUsbHostDxe.c | 2043 +++++++++++++++++
> Silicon/Synopsys/Usb/DwUsbHostDxe/DwUsbHostDxe.h | 121 +
> Silicon/Synopsys/Usb/DwUsbHostDxe/DwUsbHostDxe.inf | 61 +
> Silicon/Synopsys/Usb/DwUsbHostDxe/DwcHw.h | 792 +++++++
> 22 files changed, 8656 insertions(+)
> create mode 100644 Platform/Hisilicon/HiKey/Include/Library/UncachedMemoryAllocationLib.h
> create mode 100644 Platform/Hisilicon/HiKey/Library/ArmDmaLib/ArmDmaLib.c
> create mode 100644 Platform/Hisilicon/HiKey/Library/ArmDmaLib/ArmDmaLib.inf
> create mode 100644 Platform/Hisilicon/HiKey/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c
> create mode 100644 Platform/Hisilicon/HiKey/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.inf
> create mode 100644 Silicon/Synopsys/Usb/DwNonPci/DwNonPciUsbDxe.inf
> create mode 100644 Silicon/Synopsys/Usb/DwNonPci/InitController.c
> create mode 100644 Silicon/Synopsys/Usb/DwUsbDxe/ComponentName.c
> create mode 100644 Silicon/Synopsys/Usb/DwUsbDxe/ComponentName.h
> create mode 100644 Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.c
> create mode 100644 Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.dec
> create mode 100644 Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.h
> create mode 100644 Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.inf
> create mode 100644 Silicon/Synopsys/Usb/DwUsbHostDxe/ComponentName.c
> create mode 100644 Silicon/Synopsys/Usb/DwUsbHostDxe/ComponentName.h
> create mode 100644 Silicon/Synopsys/Usb/DwUsbHostDxe/DwUsbHostDxe.c
> create mode 100644 Silicon/Synopsys/Usb/DwUsbHostDxe/DwUsbHostDxe.h
> create mode 100644 Silicon/Synopsys/Usb/DwUsbHostDxe/DwUsbHostDxe.inf
> create mode 100644 Silicon/Synopsys/Usb/DwUsbHostDxe/DwcHw.h
prev parent reply other threads:[~2017-11-25 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 10:25 [PATCH] [edk2-platforms]: Adding usb Host driver support from OpenPlatformPkg hikey-wip branch kalyan-nagabhirava
2017-11-25 15:00 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171125150054.jmtoywmfwmkzstfg@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox