From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AF8F421A10971 for ; Sat, 25 Nov 2017 06:56:39 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id x63so26762626wmf.2 for ; Sat, 25 Nov 2017 07:00:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gheYDX/7ZNl6prtLulVxkbuBIC84wGLC1NUzu00pUeE=; b=fPLWoz4bqgclBwELe+Li7IXRIgUyp47E9qV272WhoVf05KN+cnjQQzSF/B6aEXpmZS CR3+Z0Mus4zhaJwJwEKQlyTLBnooSxi81WxE0q7v6MGTy6/cXCQTwXBUtMQWPqoGtgH5 mhIZuud8ajypbGaQUZvOgBzX+hDFIbq/XtsDY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gheYDX/7ZNl6prtLulVxkbuBIC84wGLC1NUzu00pUeE=; b=KyIgeo1XMAsP87qVRsKPiQfU8UWcCo4bSh69699Z8Jhp07Z2kkQe5YLEExlSICNvZm bnELYI+cHbkI8CVNjrPrt4qhnpuCZ64FU383bjT22O8AUEFHR12Fb6scscHWEiG7c5oc JV/zPDJEg4qgAY+RqcALaZzmE1voB1AZsqp/3GPuzXTUQgqvwzpm9kIP7+ffUxF+zsP3 EapcDVd544NVzZka+4EVy4wRF9ipaYMWOyahRsUwxI/4QeyIgax6427+5+eTayycXpAd 4SnvzmOXz4Q0MdMM0KrSdrYNHIia3NipsRSnSjQDLxFmRKml5rQ8qAr86Pw+sEV/4tGO I1Ew== X-Gm-Message-State: AJaThX4RGYPNPc1xdRetpTk1uIi5ZhrbeciGKw7wjRXH7+/YKUYqW+Oq qDxUu7qPtJysjpqAbWc+TUnnvQ== X-Google-Smtp-Source: AGs4zMYH5i2ip1Rvdj3JNq7a/7+EKX0PUhZ69Vund0mIAgXnenYUZBTo7/L46rdOuEJqPKGGz3zdSQ== X-Received: by 10.28.178.135 with SMTP id b129mr12516259wmf.103.1511622057787; Sat, 25 Nov 2017 07:00:57 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l140sm18950609wma.5.2017.11.25.07.00.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Nov 2017 07:00:56 -0800 (PST) Date: Sat, 25 Nov 2017 15:00:54 +0000 From: Leif Lindholm To: kalyan-nagabhirava Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, mark.gregotski@linaro.org, peter.griffin@linaro.org Message-ID: <20171125150054.jmtoywmfwmkzstfg@bivouac.eciton.net> References: <20171120102544.21532-1-kalyankumar.nagabhirava@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171120102544.21532-1-kalyankumar.nagabhirava@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] [edk2-platforms]: Adding usb Host driver support from OpenPlatformPkg hikey-wip branch X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2017 14:56:40 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Kalyan, This is a huge (and much appreciated) contribution. However, in order to simplify reviewing, could you please: 1) Configure your edk2-platforms clone as described in https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contributor-workflow (step 5 onwards) 2) Split this patch up into 1) DwUsbDxe 2) DwUsbHostDxe 3) HiKey-specific changes/additions. It would probably also be worth cc:ing Jeremy Linton (Jeremy.Linton@arm.com) on this set. For some early high-level feedback: * I see you have included UncachedMemoryAllocationLib under HiKey. We did delete that library for a reason - it does not really do what people seem to think it does. Ard: could you pitch in with a more suitable solution? * The DwNonPci module is not really part of the generic driver, but something that could be integrated somewhere in the platform initialization (HiKeylib?). Best Regards, Leif On Mon, Nov 20, 2017 at 03:55:44PM +0530, kalyan-nagabhirava wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: kalyan-nagabhirava > --- > Platform/Hisilicon/HiKey/HiKey.dec | 4 + > Platform/Hisilicon/HiKey/HiKey.dsc | 11 + > Platform/Hisilicon/HiKey/HiKey.fdf | 3 + > .../Include/Library/UncachedMemoryAllocationLib.h | 665 ++++++ > .../Hisilicon/HiKey/Library/ArmDmaLib/ArmDmaLib.c | 342 +++ > .../HiKey/Library/ArmDmaLib/ArmDmaLib.inf | 50 + > .../UncachedMemoryAllocationLib.c | 692 ++++++ > .../UncachedMemoryAllocationLib.inf | 45 + > Silicon/Synopsys/Usb/DwNonPci/DwNonPciUsbDxe.inf | 47 + > Silicon/Synopsys/Usb/DwNonPci/InitController.c | 37 + > Silicon/Synopsys/Usb/DwUsbDxe/ComponentName.c | 244 ++ > Silicon/Synopsys/Usb/DwUsbDxe/ComponentName.h | 148 ++ > Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.c | 2324 ++++++++++++++++++++ > Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.dec | 42 + > Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.h | 534 +++++ > Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.inf | 60 + > Silicon/Synopsys/Usb/DwUsbHostDxe/ComponentName.c | 243 ++ > Silicon/Synopsys/Usb/DwUsbHostDxe/ComponentName.h | 148 ++ > Silicon/Synopsys/Usb/DwUsbHostDxe/DwUsbHostDxe.c | 2043 +++++++++++++++++ > Silicon/Synopsys/Usb/DwUsbHostDxe/DwUsbHostDxe.h | 121 + > Silicon/Synopsys/Usb/DwUsbHostDxe/DwUsbHostDxe.inf | 61 + > Silicon/Synopsys/Usb/DwUsbHostDxe/DwcHw.h | 792 +++++++ > 22 files changed, 8656 insertions(+) > create mode 100644 Platform/Hisilicon/HiKey/Include/Library/UncachedMemoryAllocationLib.h > create mode 100644 Platform/Hisilicon/HiKey/Library/ArmDmaLib/ArmDmaLib.c > create mode 100644 Platform/Hisilicon/HiKey/Library/ArmDmaLib/ArmDmaLib.inf > create mode 100644 Platform/Hisilicon/HiKey/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c > create mode 100644 Platform/Hisilicon/HiKey/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.inf > create mode 100644 Silicon/Synopsys/Usb/DwNonPci/DwNonPciUsbDxe.inf > create mode 100644 Silicon/Synopsys/Usb/DwNonPci/InitController.c > create mode 100644 Silicon/Synopsys/Usb/DwUsbDxe/ComponentName.c > create mode 100644 Silicon/Synopsys/Usb/DwUsbDxe/ComponentName.h > create mode 100644 Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.c > create mode 100644 Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.dec > create mode 100644 Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.h > create mode 100644 Silicon/Synopsys/Usb/DwUsbDxe/DwUsbDxe.inf > create mode 100644 Silicon/Synopsys/Usb/DwUsbHostDxe/ComponentName.c > create mode 100644 Silicon/Synopsys/Usb/DwUsbHostDxe/ComponentName.h > create mode 100644 Silicon/Synopsys/Usb/DwUsbHostDxe/DwUsbHostDxe.c > create mode 100644 Silicon/Synopsys/Usb/DwUsbHostDxe/DwUsbHostDxe.h > create mode 100644 Silicon/Synopsys/Usb/DwUsbHostDxe/DwUsbHostDxe.inf > create mode 100644 Silicon/Synopsys/Usb/DwUsbHostDxe/DwcHw.h