From: Ruiyu Ni <ruiyu.ni@intel.com>
To: edk2-devel@lists.01.org
Cc: Laszlo Ersek <lersek@redhat.com>
Subject: [PATCH] OvmfPkg/Sec: Fix 64bit SEC build failure
Date: Mon, 27 Nov 2017 09:38:31 +0800 [thread overview]
Message-ID: <20171127013831.294104-1-ruiyu.ni@intel.com> (raw)
Original code breaks a single assembly code to multiple lines.
But build tool doesn't support such usage in Windows OS environment.
Changing the multiple lines to one line to resolve the build failure.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/Sec/X64/SecEntry.nasm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/OvmfPkg/Sec/X64/SecEntry.nasm b/OvmfPkg/Sec/X64/SecEntry.nasm
index 7c55032ac9..d76adcffd8 100644
--- a/OvmfPkg/Sec/X64/SecEntry.nasm
+++ b/OvmfPkg/Sec/X64/SecEntry.nasm
@@ -45,10 +45,8 @@ ASM_PFX(_ModuleEntryPoint):
; Fill the temporary RAM with the initial stack value.
; The loop below will seed the heap as well, but that's harmless.
;
- mov rax, (FixedPcdGet32 ( \
- PcdInitValueInTempStack \
- ) << 32) | \
- FixedPcdGet32 (PcdInitValueInTempStack) ; qword to store
+ mov rax, (FixedPcdGet32 (PcdInitValueInTempStack) << 32) | FixedPcdGet32 (PcdInitValueInTempStack)
+ ; qword to store
mov rdi, FixedPcdGet32 (PcdOvmfSecPeiTempRamBase) ; base address,
; relative to
; ES
--
2.15.0.gvfs.1.preview.4
next reply other threads:[~2017-11-27 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 1:38 Ruiyu Ni [this message]
2017-11-27 15:02 ` [PATCH] OvmfPkg/Sec: Fix 64bit SEC build failure Laszlo Ersek
2017-11-28 10:14 ` Gao, Liming
2017-11-28 13:57 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127013831.294104-1-ruiyu.ni@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox