From: Leif Lindholm <leif.lindholm@linaro.org>
To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com,
edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com
Subject: Re: [PATCH edk2-platforms] [PATCH v3 0/9] Platform/NXP
Date: Mon, 27 Nov 2017 12:05:04 +0000 [thread overview]
Message-ID: <20171127120504.rjsga2d77dydxtpk@bivouac.eciton.net> (raw)
In-Reply-To: <1511779917-9255-1-git-send-email-meenakshi.aggarwal@nxp.com>
On Mon, Nov 27, 2017 at 04:21:48PM +0530, Meenakshi Aggarwal wrote:
> v3:
> Added patch-prefix
I only meant you could apply this in future.
However, this new posting has ended up with ([PATCH ...][PATCH...]),
which is not ideal. There is no need to edit the patch subject for
each version - just specify (for a v3)
git format-patch --subject-prefix="PATCH edk2-platforms" -v3
If there is a need for a v4, or for future submissions, please also
look into
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contributor-workflow
for how to configure your cloned git repository to generate summaries
and diffs that are easier to review.
> v2:
> 1. Incorporated styling comments
> 2. Removed/Rewrite function referred from linux
> 3. Created DS1307 Library under Silicon/Maxim and make it i2c driver based.
> 4. Created i2c driver
>
> Meenakshi Aggarwal (9):
> Platform/NXP: Add support for Big Endian Mmio APIs
> Platform/NXP : Add support for Watchdog driver
> SocLib : Add support for initialization of peripherals
> Platform/NXP : Add support for DUART library
> Platform/NXP: Add support for I2c driver
> Silicon/Maxim : Add support for DS1307 RTC library
> Platform/NXP: Add support for ArmPlatformLib
> Compilation : Add the fdf, dsc and dec files.
> Build : Add build script and environment script
>
> Platform/NXP/Drivers/I2cDxe/I2cDxe.c | 728 +++++++++++++++++++++
> Platform/NXP/Drivers/I2cDxe/I2cDxe.h | 64 ++
> Platform/NXP/Drivers/I2cDxe/I2cDxe.inf | 57 ++
> Platform/NXP/Drivers/WatchDog/WatchDog.c | 421 ++++++++++++
> Platform/NXP/Drivers/WatchDog/WatchDog.h | 37 ++
> Platform/NXP/Drivers/WatchDog/WatchDogDxe.inf | 47 ++
> Platform/NXP/Env.cshrc | 77 +++
> Platform/NXP/Include/Bitops.h | 179 +++++
> Platform/NXP/Include/Library/BeIoLib.h | 332 ++++++++++
> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dec | 29 +
> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 77 +++
> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 281 ++++++++
> .../Library/PlatformLib/ArmPlatformLib.c | 105 +++
> .../Library/PlatformLib/ArmPlatformLib.inf | 70 ++
> .../Library/PlatformLib/NxpQoriqLsHelper.S | 38 ++
> .../Library/PlatformLib/NxpQoriqLsMem.c | 184 ++++++
In particular these ..., meaning reviewers need to start guessing
which files are affected.
Best Regards,
Leif
> Platform/NXP/Library/BeIoLib/BeIoLib.c | 400 +++++++++++
> Platform/NXP/Library/BeIoLib/BeIoLib.inf | 31 +
> Platform/NXP/Library/DUartPortLib/DUart.h | 128 ++++
> Platform/NXP/Library/DUartPortLib/DUartPortLib.c | 331 ++++++++++
> Platform/NXP/Library/DUartPortLib/DUartPortLib.inf | 39 ++
> Platform/NXP/NxpQoriqLs.dec | 248 +++++++
> Platform/NXP/NxpQoriqLs.dsc | 453 +++++++++++++
> Platform/NXP/Readme.md | 15 +
> Platform/NXP/build.sh | 103 +++
> Silicon/Maxim/Library/Ds1307RtcLib/Ds1307Rtc.h | 59 ++
> Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c | 327 +++++++++
> .../Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.dec | 26 +
> .../Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.inf | 45 ++
> Silicon/NXP/Chassis/Chassis.c | 413 ++++++++++++
> Silicon/NXP/Chassis/Chassis.h | 144 ++++
> Silicon/NXP/Chassis/Chassis2/Chassis2.dec | 19 +
> Silicon/NXP/Chassis/Chassis2/SerDes.h | 69 ++
> Silicon/NXP/Chassis/Chassis2/Soc.c | 145 ++++
> Silicon/NXP/Chassis/Chassis2/Soc.h | 376 +++++++++++
> Silicon/NXP/Chassis/LS1043aSocLib.inf | 47 ++
> Silicon/NXP/Chassis/SerDes.c | 254 +++++++
> Silicon/NXP/LS1043A/Include/SocSerDes.h | 55 ++
> Silicon/NXP/LS1043A/LS1043A.dec | 22 +
> Silicon/NXP/LS1043A/LS1043A.dsc | 82 +++
> 40 files changed, 6557 insertions(+)
> create mode 100644 Platform/NXP/Drivers/I2cDxe/I2cDxe.c
> create mode 100644 Platform/NXP/Drivers/I2cDxe/I2cDxe.h
> create mode 100644 Platform/NXP/Drivers/I2cDxe/I2cDxe.inf
> create mode 100644 Platform/NXP/Drivers/WatchDog/WatchDog.c
> create mode 100644 Platform/NXP/Drivers/WatchDog/WatchDog.h
> create mode 100644 Platform/NXP/Drivers/WatchDog/WatchDogDxe.inf
> create mode 100755 Platform/NXP/Env.cshrc
> create mode 100644 Platform/NXP/Include/Bitops.h
> create mode 100644 Platform/NXP/Include/Library/BeIoLib.h
> create mode 100644 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dec
> create mode 100644 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc
> create mode 100644 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf
> create mode 100644 Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.c
> create mode 100644 Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf
> create mode 100644 Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S
> create mode 100644 Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c
> create mode 100644 Platform/NXP/Library/BeIoLib/BeIoLib.c
> create mode 100644 Platform/NXP/Library/BeIoLib/BeIoLib.inf
> create mode 100644 Platform/NXP/Library/DUartPortLib/DUart.h
> create mode 100644 Platform/NXP/Library/DUartPortLib/DUartPortLib.c
> create mode 100644 Platform/NXP/Library/DUartPortLib/DUartPortLib.inf
> create mode 100644 Platform/NXP/NxpQoriqLs.dec
> create mode 100644 Platform/NXP/NxpQoriqLs.dsc
> create mode 100644 Platform/NXP/Readme.md
> create mode 100755 Platform/NXP/build.sh
> create mode 100644 Silicon/Maxim/Library/Ds1307RtcLib/Ds1307Rtc.h
> create mode 100644 Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c
> create mode 100644 Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.dec
> create mode 100644 Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.inf
> create mode 100644 Silicon/NXP/Chassis/Chassis.c
> create mode 100644 Silicon/NXP/Chassis/Chassis.h
> create mode 100644 Silicon/NXP/Chassis/Chassis2/Chassis2.dec
> create mode 100644 Silicon/NXP/Chassis/Chassis2/SerDes.h
> create mode 100644 Silicon/NXP/Chassis/Chassis2/Soc.c
> create mode 100644 Silicon/NXP/Chassis/Chassis2/Soc.h
> create mode 100644 Silicon/NXP/Chassis/LS1043aSocLib.inf
> create mode 100644 Silicon/NXP/Chassis/SerDes.c
> create mode 100644 Silicon/NXP/LS1043A/Include/SocSerDes.h
> create mode 100644 Silicon/NXP/LS1043A/LS1043A.dec
> create mode 100644 Silicon/NXP/LS1043A/LS1043A.dsc
>
> v1:
> Following patches will add support of NXP SoCs in edk2-platforms.
>
> Our directory structure will be:
>
> edk2-platforms/
> |-- Platform
> | |-- NXP
> | | |-- build.sh
> | | |-- Drivers
> | | |-- Env.cshrc
> | | |-- Include
> | | | `-- Library
> | | | `-- Drivers
> | | |-- Library
> | | |-- LS1043aRdbPkg
> | | | |-- Drivers
> | | | |-- Include
> | | | | `-- Library
> | | | | `-- Drivers
> | | | |-- Library
> | | | |-- LS1043aRdbPkg.dec
> | | | |-- LS1043aRdbPkg.dsc
> | | | `-- LS1043aRdbPkg.fdf
> | | |-- NxpQoriqLs.dec
> | | |-- NxpQoriqLs.dsc
> | | `-- Readme.md
> `-- Silicon
> |-- NXP
> |-- Chassis
> | |-- Chassis2
> `-- LS1043A
> |-- Include
> |-- LS1043A.dec
> `-- LS1043A.dsc
>
> In Silicon/NXP, we are keeping our SoC specific information and remaining code will be kept in Platform/NXP.
>
> Platform/NXP/LS1043aRdbPkg will host .dsc and .fdf files to support compilation for LS1043A RDB board.
>
> In next series of patches we will be adding support for LS2088 and LS1046 board.
>
>
> Looking forward for your kind support in upstreaming our board in edk2-platforms.
>
>
> Meenakshi Aggarwal (10):
> Platform/NXP: Library to provide helper functions.
> Platform/NXP: Add support for system reset library
> Platform/NXP: Add support for Big Endian Mmio APIs
> Platform/NXP : Add support for Watchdog driver
> Platform/NXP : Add support for DUART library
> Platform/NXP: Add support for I2c operations library
> Platform/NXP : Add support for DS1307 RTC library
> Platform/NXP: Add support for ArmPlatformLib
> SocLib : Add support for initialization of peripherals
> Compilation : Add the fdf, dsc and dec files.
>
> Platform/NXP/Drivers/WatchDog/WatchDog.c | 386 +++++++++++++++
> Platform/NXP/Drivers/WatchDog/WatchDog.h | 37 ++
> Platform/NXP/Drivers/WatchDog/WatchDogDxe.inf | 47 ++
> Platform/NXP/Env.cshrc | 75 +++
> Platform/NXP/Include/Bitops.h | 179 +++++++
> Platform/NXP/Include/Library/BeIoLib.h | 332 +++++++++++++
> Platform/NXP/Include/Library/I2c.h | 125 +++++
> Platform/NXP/Include/Library/Utils.h | 137 +++++
> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dec | 29 ++
> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 74 +++
> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 279 +++++++++++
> .../Library/PlatformLib/ArmPlatformLib.c | 105 ++++
> .../Library/PlatformLib/ArmPlatformLib.inf | 70 +++
> .../Library/PlatformLib/NxpQoriqLsHelper.S | 38 ++
> .../Library/PlatformLib/NxpQoriqLsMem.c | 184 +++++++
> Platform/NXP/Library/BeIoLib/BeIoLib.c | 400 +++++++++++++++
> Platform/NXP/Library/BeIoLib/BeIoLib.inf | 31 ++
> Platform/NXP/Library/DUartPortLib/DUart.h | 128 +++++
> Platform/NXP/Library/DUartPortLib/DUartPortLib.c | 334 +++++++++++++
> Platform/NXP/Library/DUartPortLib/DUartPortLib.inf | 39 ++
> Platform/NXP/Library/Ds1307RtcLib/Ds1307Rtc.h | 40 ++
> Platform/NXP/Library/Ds1307RtcLib/Ds1307RtcLib.c | 226 +++++++++
> Platform/NXP/Library/Ds1307RtcLib/Ds1307RtcLib.inf | 40 ++
> Platform/NXP/Library/I2cLib/I2cLib.c | 549 +++++++++++++++++++++
> Platform/NXP/Library/I2cLib/I2cLib.h | 109 ++++
> Platform/NXP/Library/I2cLib/I2cLib.inf | 43 ++
> .../NXP/Library/ResetSystemLib/ResetSystemLib.c | 96 ++++
> .../NXP/Library/ResetSystemLib/ResetSystemLib.inf | 33 ++
> Platform/NXP/Library/UtilsLib/Utils.c | 97 ++++
> Platform/NXP/Library/UtilsLib/Utils.inf | 30 ++
> Platform/NXP/NxpQoriqLs.dec | 257 ++++++++++
> Platform/NXP/NxpQoriqLs.dsc | 453 +++++++++++++++++
> Platform/NXP/Readme.md | 14 +
> Platform/NXP/build.sh | 100 ++++
> Silicon/NXP/Chassis/Chassis.c | 393 +++++++++++++++
> Silicon/NXP/Chassis/Chassis.h | 123 +++++
> Silicon/NXP/Chassis/Chassis2/Chassis2.dec | 19 +
> Silicon/NXP/Chassis/Chassis2/SerDes.h | 82 +++
> Silicon/NXP/Chassis/Chassis2/Soc.c | 146 ++++++
> Silicon/NXP/Chassis/Chassis2/Soc.h | 376 ++++++++++++++
> Silicon/NXP/Chassis/LS1043aSocLib.inf | 48 ++
> Silicon/NXP/Chassis/SerDes.c | 253 ++++++++++
> Silicon/NXP/LS1043A/Include/SocSerDes.h | 55 +++
> Silicon/NXP/LS1043A/LS1043A.dec | 22 +
> Silicon/NXP/LS1043A/LS1043A.dsc | 82 +++
> 45 files changed, 6715 insertions(+)
> create mode 100644 Platform/NXP/Drivers/WatchDog/WatchDog.c
> create mode 100644 Platform/NXP/Drivers/WatchDog/WatchDog.h
> create mode 100644 Platform/NXP/Drivers/WatchDog/WatchDogDxe.inf
> create mode 100644 Platform/NXP/Env.cshrc create mode 100644
> Platform/NXP/Include/Bitops.h create mode 100644
> Platform/NXP/Include/Library/BeIoLib.h
> create mode 100644 Platform/NXP/Include/Library/I2c.h
> create mode 100644 Platform/NXP/Include/Library/Utils.h
> create mode 100644 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dec
> create mode 100644 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc
> create mode 100644 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf
> create mode 100644
> Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.c
> create mode 100644
> Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf
> create mode 100644
> Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S
> create mode 100644
> Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c
> create mode 100644 Platform/NXP/Library/BeIoLib/BeIoLib.c
> create mode 100644 Platform/NXP/Library/BeIoLib/BeIoLib.inf
> create mode 100644 Platform/NXP/Library/DUartPortLib/DUart.h
> create mode 100644 Platform/NXP/Library/DUartPortLib/DUartPortLib.c
> create mode 100644 Platform/NXP/Library/DUartPortLib/DUartPortLib.inf
> create mode 100644 Platform/NXP/Library/Ds1307RtcLib/Ds1307Rtc.h
> create mode 100644 Platform/NXP/Library/Ds1307RtcLib/Ds1307RtcLib.c
> create mode 100644 Platform/NXP/Library/Ds1307RtcLib/Ds1307RtcLib.inf
> create mode 100644 Platform/NXP/Library/I2cLib/I2cLib.c
> create mode 100644 Platform/NXP/Library/I2cLib/I2cLib.h
> create mode 100644 Platform/NXP/Library/I2cLib/I2cLib.inf
> create mode 100644
> Platform/NXP/Library/ResetSystemLib/ResetSystemLib.c
> create mode 100644
> Platform/NXP/Library/ResetSystemLib/ResetSystemLib.inf
> create mode 100644 Platform/NXP/Library/UtilsLib/Utils.c
> create mode 100644 Platform/NXP/Library/UtilsLib/Utils.inf
> create mode 100644 Platform/NXP/NxpQoriqLs.dec create mode 100644
> Platform/NXP/NxpQoriqLs.dsc create mode 100644 Platform/NXP/Readme.md
> create mode 100755 Platform/NXP/build.sh create mode 100644
> Silicon/NXP/Chassis/Chassis.c create mode 100644
> Silicon/NXP/Chassis/Chassis.h create mode 100644
> Silicon/NXP/Chassis/Chassis2/Chassis2.dec
> create mode 100644 Silicon/NXP/Chassis/Chassis2/SerDes.h
> create mode 100644 Silicon/NXP/Chassis/Chassis2/Soc.c
> create mode 100644 Silicon/NXP/Chassis/Chassis2/Soc.h
> create mode 100644 Silicon/NXP/Chassis/LS1043aSocLib.inf
> create mode 100644 Silicon/NXP/Chassis/SerDes.c create mode 100644
> Silicon/NXP/LS1043A/Include/SocSerDes.h
> create mode 100644 Silicon/NXP/LS1043A/LS1043A.dec create mode
> 100644 Silicon/NXP/LS1043A/LS1043A.dsc
>
> --
> 1.9.1
>
prev parent reply other threads:[~2017-11-27 12:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 10:51 [PATCH edk2-platforms] [PATCH v3 0/9] Platform/NXP Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 1/9] Platform/NXP: Add support for Big Endian Mmio APIs Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver Meenakshi Aggarwal
2017-12-04 14:35 ` Leif Lindholm
2017-12-04 15:23 ` Gao, Liming
2017-12-05 5:07 ` Udit Kumar
2017-12-05 11:06 ` Leif Lindholm
2017-12-07 3:35 ` Meenakshi Aggarwal
2017-12-07 7:11 ` Gao, Liming
2017-12-07 11:03 ` Leif Lindholm
2017-12-07 14:54 ` Gao, Liming
2017-12-07 15:34 ` Leif Lindholm
2017-12-08 4:41 ` Udit Kumar
2017-12-10 13:30 ` Gao, Liming
2017-12-14 3:37 ` Meenakshi Aggarwal
2017-12-07 11:15 ` Udit Kumar
2017-12-07 14:51 ` Gao, Liming
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 3/9] SocLib : Add support for initialization of peripherals Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 4/9] Platform/NXP : Add support for DUART library Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 5/9] Platform/NXP: Add support for I2c driver Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 6/9] Silicon/Maxim : Add support for DS1307 RTC library Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 7/9] Platform/NXP: Add support for ArmPlatformLib Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 8/9] Compilation : Add the fdf, dsc and dec files Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 9/9] Build : Add build script and environment script Meenakshi Aggarwal
2017-11-27 12:05 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127120504.rjsga2d77dydxtpk@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox