From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::22d; helo=mail-wr0-x22d.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x22d.google.com (mail-wr0-x22d.google.com [IPv6:2a00:1450:400c:c0c::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 477E7203564C5 for ; Tue, 28 Nov 2017 04:03:08 -0800 (PST) Received: by mail-wr0-x22d.google.com with SMTP id o14so105806wrf.9 for ; Tue, 28 Nov 2017 04:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XN8xqyFSg3zNJEZvsUi58j25Bri9+llFXiYyIUQ2eXQ=; b=WfPQLFIF9VUoHHSKq3CT5XmQ2B6UXmrXvtdUk8DoHehidY5FlUyBNlYNXZxIn5YKf/ b2aqY6+PMY1k03gXMsrnjHVCYhRaCA6G7JEDg+22X1xGYMuAZJXafUMJBgALG3J8QXdG 9d2l5eB3KfQHabBw7Asx/WbyWForYByNxvzoA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XN8xqyFSg3zNJEZvsUi58j25Bri9+llFXiYyIUQ2eXQ=; b=pETgybcIIuEQBL5hmY9G1PDTUSqAoyuAmYB5ctMzLXPYL9Ygp2/hvZUlNG0+bswrYF mym9CT31plEqjWh0wB9wKn8wIUfoibHrG3SjmExaF0+ZAW4Fzw8XRyDHaDSLnXUriET8 5uTUO/Ixzm2/sMatN/rSEpLqg7f3Sv5vbwPxVNfZi9qew208XIg4RuOGOhsVGzvq7TIx 4YWc2KvH+Lnj+JRALUMnmeHoKHpt35nc84jdPwln3aTJS1LRBPvj5PM8JvOmnXAhasNA klKM/wQqnQ6/5zLOoIywRcLqe2M3S9ZBAKYCiFap4q826tM1CVy+z2exr76mdP873mPa VoPg== X-Gm-Message-State: AJaThX6ySq1Y3+v+E3O/MX70EDAfXhv9SYsfhgKj0fOyh1O2ZOKprPd5 hosR+D298ZVt5icfhgsFUvvDlg== X-Google-Smtp-Source: AGs4zMbfBrWXgZxTXE4ee3f70q+DszlBhc5YfMtpZlXqkbCMxpBf87w5OY5k7Akf5lDYE+bs/M8k/w== X-Received: by 10.223.136.164 with SMTP id f33mr31865442wrf.162.1511870849145; Tue, 28 Nov 2017 04:07:29 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t10sm22013426wra.16.2017.11.28.04.07.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Nov 2017 04:07:28 -0800 (PST) Date: Tue, 28 Nov 2017 12:07:26 +0000 From: Leif Lindholm To: Ruiyu Ni Cc: edk2-devel@lists.01.org Message-ID: <20171128120726.bvolgusyeq2pj5mj@bivouac.eciton.net> References: <20171128120009.176316-1-ruiyu.ni@intel.com> MIME-Version: 1.0 In-Reply-To: <20171128120009.176316-1-ruiyu.ni@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v2 0/6] Fix build failure due to tftp/dp library removal X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 12:03:08 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline It would be helpful if the cover letter included a reference to the commit that caused the breakage. / Leif On Tue, Nov 28, 2017 at 08:00:03PM +0800, Ruiyu Ni wrote: > v2: v1 still causes build failures. I tried best to verify the build. > OVMF boot is also tried. > > Ruiyu Ni (6): > ShellPkg/tftp: Correct file comments header of Tftp.uni > EmulatorPkg: Fix build failure due to Tftp library removal > ArmVirtPkg: Fix build failure due to Tftp library removal > BeagleBoardPkg: Fix build failure due to Tftp library removal > CorebootPayloadPkg: Fix build failure due to Tftp/Dp library removal > OvmfPkg: Add tftp dynamic command > > ArmVirtPkg/ArmVirt.dsc.inc | 11 ++++--- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 +- > ArmVirtPkg/ArmVirtXen.fdf | 3 +- > BeagleBoardPkg/BeagleBoardPkg.dsc | 17 +++++----- > BeagleBoardPkg/BeagleBoardPkg.fdf | 3 +- > CorebootPayloadPkg/CorebootPayloadPkg.fdf | 4 ++- > CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 36 ++++++++++++---------- > CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 36 ++++++++++++---------- > EmulatorPkg/EmulatorPkg.dsc | 10 +++--- > EmulatorPkg/EmulatorPkg.fdf | 3 +- > OvmfPkg/OvmfPkgIa32.dsc | 7 +++-- > OvmfPkg/OvmfPkgIa32.fdf | 3 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 7 +++-- > OvmfPkg/OvmfPkgIa32X64.fdf | 3 +- > OvmfPkg/OvmfPkgX64.dsc | 7 +++-- > OvmfPkg/OvmfPkgX64.fdf | 1 + > .../DynamicCommand/TftpDynamicCommand/Tftp.uni | 4 +-- > 17 files changed, 93 insertions(+), 65 deletions(-) > > -- > 2.15.0.gvfs.1.preview.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel