From: Leif Lindholm <leif.lindholm@linaro.org>
To: Kalyan Nagabhirava <kalyankumar.nagabhirava@linaro.org>
Cc: Laszlo Ersek <lersek@redhat.com>,
edk2-devel@lists.01.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Mark Gregotski <mark.gregotski@linaro.org>
Subject: Re: [PATCH] [edk2-platforms]:Enabling Secure boot feature support on hikey platfrom
Date: Tue, 28 Nov 2017 12:37:30 +0000 [thread overview]
Message-ID: <20171128123730.ijrm7xmndnzln7gh@bivouac.eciton.net> (raw)
In-Reply-To: <CAPcudRjfhmKixSzvnyG5Nyaw6TTN_PkgRFVXnunUT5hNtSPbmQ@mail.gmail.com>
On Tue, Nov 28, 2017 at 01:05:35PM +0530, Kalyan Nagabhirava wrote:
> HI Leif,
> we didn't implemented enabling USB host and Secure boot support on Hikey
> , we just took the code from openplatfrompkg (hikey branch)
There is no hikey branch in OpenPlatformPkg.
If you are referring to some sort of fork somewhere, then please point
it out explicitly.
> , we have implemented secureboot and DRI -disaster recovery image (HTTP
> image download) application
> and tested on HIkey platform , so for that purpose we are trying to
> upstream the hikey code.
>
> but hikey platform code looks in bad shape (as per ard and your comments)
> ,so we are planning to upstream
> only our application code which is independent of platform.
I understand, but I cannot merge new code which is not used by any
upstream platform. If you do not have the time and bandwidth to clean
up these drivers, can you ask whoever looks after that fork to
upstream their platform support?
Best Regards,
Leif
next prev parent reply other threads:[~2017-11-28 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 10:53 [PATCH] [edk2-platforms]:Enabling Secure boot feature support on hikey platfrom kalyan-nagabhirava
2017-11-26 15:22 ` Leif Lindholm
2017-11-27 13:02 ` Laszlo Ersek
2017-11-27 16:57 ` Leif Lindholm
2017-11-28 7:35 ` Kalyan Nagabhirava
2017-11-28 12:37 ` Leif Lindholm [this message]
2017-11-28 13:01 ` Kalyan Nagabhirava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128123730.ijrm7xmndnzln7gh@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox