From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 801E921A10972 for ; Tue, 28 Nov 2017 12:14:02 -0800 (PST) Received: by mail-wm0-x242.google.com with SMTP id l141so2008252wmg.1 for ; Tue, 28 Nov 2017 12:18:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=psrezzqZYyshXCvViRR7LYPYIZwCDefrPnNAJuZVOXY=; b=UOS2VG8ztrqvDaxJiqx2xjmk3QGq4VxOg30t+Mgh/5rCdh33sQwf+QiOtgTGMOR8iw oexUMDu8nSWqJpwtsg84v7cocLnLrvV9lqfJmf4DNWxpsczY5aJIjs167UY9OpPFDFVv H6GKedw8bq/azedvj7UZZXWnfIfqw8db0VOXM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=psrezzqZYyshXCvViRR7LYPYIZwCDefrPnNAJuZVOXY=; b=boYnmzNRuyQ3BPJqU5frHf//NErV4OOK1ecZGydgJDqh6O19qrEUpszcUQcSgZXOLJ S5ehtFwC5UzpLsiGMbguM+uxCzXc1GDQU8edEibJMG8h053nuq6LWJd9sH5600RG9gZB 8F2AX92+1vzmJzYtYw0dBFUsyi3Rmh0Zf+g0y1nJC+VzVcATg6H2JXH88J5zTCM8WyrI nYW7ydarzZup/SyRft5H4L4mCf3xShfIJp19ESOQjF7IYWs2kUVXa7tED6xnmKy++CCl eHgVej4wgohNh4066yvsVlQPNip8Jj0c2sIX0qUyyM/z5RRIJx0m0u9rymOT3nm99AxB NPDA== X-Gm-Message-State: AJaThX4h3iXvAsOmI3MdE5RZ/1+XYDI0W9Y3vP4HgpfmGWdHp3DK/aeB Tt8yFQ9SpV22sCejPg+Tq00DmA== X-Google-Smtp-Source: AGs4zMaAKsis/REWxwYYhl5cKpl+2mT+Q6p0yHMwemMW3E6hEwcBXSS8yYMGnEtHsnStg96DtjYxrQ== X-Received: by 10.28.20.213 with SMTP id 204mr608400wmu.132.1511900304088; Tue, 28 Nov 2017 12:18:24 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 1sm323027wmu.8.2017.11.28.12.18.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Nov 2017 12:18:22 -0800 (PST) Date: Tue, 28 Nov 2017 20:18:21 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20171128201821.we2giq7yhtjynl3w@bivouac.eciton.net> References: <20171128173526.22413-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171128173526.22413-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] Silicon/AMD Silicon/Hisilicon: remove -ArmGetCpuCountPerCluster() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 20:14:02 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 28, 2017 at 05:35:26PM +0000, Ard Biesheuvel wrote: > The function ArmGetCpuCountPerCluster () was moved out of ArmPlatformLib > because it was unused (except internally by one of the implementations) > So remove the remaining implementations from edk2-platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Silicon/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S | 6 ------ > Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c | 6 ------ > Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/AArch64/Helper.S | 6 ------ > Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c | 5 ----- > 4 files changed, 23 deletions(-) > > diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S b/Silicon/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S > index b7ec02f0e69f..19a2fc07f3d7 100644 > --- a/Silicon/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S > +++ b/Silicon/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S > @@ -47,12 +47,6 @@ ASM_FUNC(ArmPlatformGetPrimaryCoreMpId) > ldr w0, PrimaryCoreMpid > ret > > -# IN None > -# OUT x0 = number of cores present in the system > -ASM_FUNC(ArmGetCpuCountPerCluster) > - MOV32 (w0, FixedPcdGet32 (PcdCoreCount)) > - ret > - > //UINTN > //ArmPlatformIsPrimaryCore ( > // IN UINTN MpId > diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c b/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c > index f17a960d60ad..facfd61ca230 100644 > --- a/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c > +++ b/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c > @@ -45,12 +45,6 @@ > extern EFI_GUID gAmdStyxMpCoreInfoGuid; > > > -UINTN > -ArmGetCpuCountPerCluster ( > - VOID > - ); > - > - > /** > Return the current Boot Mode > > diff --git a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/AArch64/Helper.S b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/AArch64/Helper.S > index 3422df279c73..74e4aeeffc31 100644 > --- a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/AArch64/Helper.S > +++ b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/AArch64/Helper.S > @@ -29,12 +29,6 @@ ASM_FUNC(ArmPlatformGetPrimaryCoreMpId) > MOV32 (w0, FixedPcdGet32(PcdArmPrimaryCore)) > ret > > -# IN None > -# OUT x0 = number of cores present in the system > -ASM_FUNC(ArmGetCpuCountPerCluster) > - MOV32 (w0, FixedPcdGet32(PcdCoreCount)) > - ret > - > //UINTN > //ArmPlatformIsPrimaryCore ( > // IN UINTN MpId > diff --git a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c > index 07ab0d1dc271..b59b9f027573 100644 > --- a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c > +++ b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c > @@ -23,11 +23,6 @@ > > #include > > -UINTN > -ArmGetCpuCountPerCluster ( > - VOID > - ); > - > extern EFI_STATUS MemInitEntry (VOID); > > /** > -- > 2.11.0 >