From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 98F3B21A04E2F for ; Wed, 29 Nov 2017 00:17:43 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2017 00:22:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,472,1505804400"; d="scan'208";a="181467435" Received: from ray-dev.ccr.corp.intel.com ([10.239.9.50]) by fmsmga005.fm.intel.com with ESMTP; 29 Nov 2017 00:22:06 -0800 From: Ruiyu Ni To: edk2-devel@lists.01.org Cc: Jaben Carsey Date: Wed, 29 Nov 2017 16:22:05 +0800 Message-Id: <20171129082205.269556-1-ruiyu.ni@intel.com> X-Mailer: git-send-email 2.15.0.gvfs.1.preview.4 Subject: [PATCH] ShellPkg/ShellPkg.dec: Change comments for PcdShellLibAutoInitialize X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 08:17:43 -0000 When Dynamic command drivers links to ShellLib, the ShellLib constructor shouldn't be called because the Shell and ShellParameters protocols don't exist when the driver starts. So it's required to set PcdShellLibAutoInitialize to FALSE for dynamic command drivers. Update the comments in DEC file to describe such requirement for this PCD. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/ShellPkg.dec | 1 + 1 file changed, 1 insertion(+) diff --git a/ShellPkg/ShellPkg.dec b/ShellPkg/ShellPkg.dec index 5859c49033..48d50b87b3 100644 --- a/ShellPkg/ShellPkg.dec +++ b/ShellPkg/ShellPkg.dec @@ -81,6 +81,7 @@ [PcdsFeatureFlag] [PcdsFixedAtBuild] ## This flag is used to control initialization of the shell library # This should be FALSE for compiling the shell application itself only. + # This should be FALSE for compiling the dynamic command drivers. gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|TRUE|BOOLEAN|0x00000005 ## This is the max buffer for ShellLib and internal Shell printings. -- 2.15.0.gvfs.1.preview.4