From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EC376203564AF for ; Wed, 29 Nov 2017 03:26:29 -0800 (PST) Received: by mail-wr0-x243.google.com with SMTP id s66so3041897wrc.9 for ; Wed, 29 Nov 2017 03:30:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OHiAGXmatWtGgPeKPUFfX1p1y6nDK0O2v9vntNVJ/qM=; b=CdqnumcHd9RyYDNC4EO2vw+z+ay+718gCoEMNziE35JRcHEPnnK0YukoJd+0eiKd7Y hJaxYH71FqihNgEM8b4EokjyzIr2S/e4sXv7XEyk1I8YkU9kREonrzJsP7eq8MTtThRB cqG+4JMzhtvy9T/PN5lVMrtcQLvdkWGh3V3JU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OHiAGXmatWtGgPeKPUFfX1p1y6nDK0O2v9vntNVJ/qM=; b=RVEIEfLMWy/fn4mEnEWXSQL64ZpUtXFRq2IZbJ7NJAF4d8T8g4G252OA2xv/rTfIbO Hu1Zjq4H4pqvCfwPYI1Pt9FkOCELBgiFmfrfZpxUfOTSGs0SC+FVn5id3uBTwDuI+t46 T6IjKkF7B/toBoGMTlWUJIKmm+9LKnLNGBYbdIpguDMjVS8cKMvL8PyrA67efILEE+9x smOQ1fd+civV8kb6XhgCbHsltu20xG69GtOki9w6nYzA3BdYlGyoy9xjvMUpoPGLik9D S0SO1w3S52JEJra8+haOnZtSCSdkcg/iQ+W6FYisYSTJSz7t5eH98qxQ0efAH+YDYlYX 9idw== X-Gm-Message-State: AJaThX5rKYrSLXTTDdxGafSyLalufsHENudfw1to5TXI+C/FFQafBr+Q YhTOvCG/kUdiPOw4dT5rTDbICA== X-Google-Smtp-Source: AGs4zMa5y+ugUJ1nFI+tVvIjaYYyb4j/GcIESG64zOtVF4P44njh55xU0ikemlhcs5nN45r4zO9BTw== X-Received: by 10.223.185.3 with SMTP id k3mr2156567wrf.40.1511955052125; Wed, 29 Nov 2017 03:30:52 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q13sm859761wrg.97.2017.11.29.03.30.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Nov 2017 03:30:51 -0800 (PST) Date: Wed, 29 Nov 2017 11:30:49 +0000 From: Leif Lindholm To: Ruiyu Ni Cc: edk2-devel@lists.01.org Message-ID: <20171129113049.7k6dnldu32bupuah@bivouac.eciton.net> References: <20171129101500.288384-1-ruiyu.ni@intel.com> <20171129101500.288384-4-ruiyu.ni@intel.com> MIME-Version: 1.0 In-Reply-To: <20171129101500.288384-4-ruiyu.ni@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v4 3/3] BeagleBoardPkg: Fix build failure due to Tftp library removal X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 11:26:30 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 29, 2017 at 06:15:00PM +0800, Ruiyu Ni wrote: > The TFTP command was converted from a NULL class library > instance to a dynamic shell command in commit 0961002352e9. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Leif Lindholm > Reviewed-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > BeagleBoardPkg/BeagleBoardPkg.dsc | 16 +++++++++------- > BeagleBoardPkg/BeagleBoardPkg.fdf | 3 ++- > 2 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc > index 4f7c0bd645..d67ccf377e 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -2,7 +2,7 @@ > # Beagle board package. > # > # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
> -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> # Copyright (c) 2016, Linaro Ltd. All rights reserved.
> # > # This program and the accompanying materials > @@ -355,11 +355,6 @@ [PcdsFixedAtBuild.common] > # OMAP Interrupt Controller > gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress|0x48200000 > > - # We want to use the Shell Libraries but don't want it to initialise > - # automatically. We initialise the libraries when the command is called by the > - # Shell. > - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > - > gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|10 > > # GUID of the UEFI Shell > @@ -487,6 +482,14 @@ [Components.common] > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > } > + > + # > + # Shell > + # > + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > ShellPkg/Application/Shell/Shell.inf { > > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf > @@ -497,7 +500,6 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > - NULL|ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf b/BeagleBoardPkg/BeagleBoardPkg.fdf > index c9c6afd714..71249c7eb3 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.fdf > +++ b/BeagleBoardPkg/BeagleBoardPkg.fdf > @@ -1,7 +1,7 @@ > # FLASH layout file for Beagle board. > # > # Copyright (c) 2009, Apple Inc. All rights reserved.
> -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> # Copyright (c) 2016, Linaro, Ltd. All rights reserved.
> # > # This program and the accompanying materials > @@ -178,6 +178,7 @@ [FV.FvMain] > # UEFI application (Shell Embedded Boot Loader) > # > INF ShellPkg/Application/Shell/Shell.inf > + INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > > # > # Bds > -- > 2.15.0.gvfs.1.preview.4 >