From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=julien.grall@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3263F21B00DC4 for ; Wed, 29 Nov 2017 09:24:06 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id r78so7909152wme.5 for ; Wed, 29 Nov 2017 09:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FB/GkuSdLB969O880F/fYyIZGRBhGZpp92IR9EbEErw=; b=CgsqNms57KT3c1LG7AOIdaABNf/hsBtni4GN0ismMs16C0+zDt380tZ/AwqtU/dC5/ 3UM2dz1eGRkOLMcadPPi9kgZpdW0stiwNvIlQyHOJf5IIj9joaJjYP7zm38SQETix245 BI68yaMi6uCwc7EquVnbkycvfhmdQPjDEoheI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FB/GkuSdLB969O880F/fYyIZGRBhGZpp92IR9EbEErw=; b=QIujneMKQY3C7D/1A1NrngkEKGK470iNcbverHSU8/tC+YEQVJAvXCE+HEnklS4+BT BmltLWXxXMxOg3JukO3GwswHlzt768seI/mvgLYyj7duQcpuZ42JhEKNx/40kwW+nzu0 dPIZSwrO6FhcQPKinmzzl4d/ZggqKyiAI1kJEbQwlOmgD3Lzap9BQYEpNFCuPwgVisr4 NaqsZ9E6+otZuVbto+cfoDWhnZaTMnUM7NI9qI+NIj9zUE6jAwRf1DNggvClPu1UR785 18OD7Sus4x928ANCqLvUao+FS3rt8P0Jx6Y10N2igwrgukOC84EOFZkfeTwJyom7T1XA MGIw== X-Gm-Message-State: AJaThX57EKJzk9cR5jSaZfKyXkoVrxXZrm4nKCuIXyqwzaULSz/kS+5y FRjHpB/aFVikjsP5Xalfaw42wNfea+E= X-Google-Smtp-Source: AGs4zMZA/IT60qtlk4xevGaWeDRdBzzmL7a/p6hUcQQINSR+0jU3/epJoB3BgaJ1Enu1n05nxNFm+w== X-Received: by 10.28.10.5 with SMTP id 5mr3060847wmk.74.1511976509280; Wed, 29 Nov 2017 09:28:29 -0800 (PST) Received: from e108454-lin.cambridge.arm.com ([2001:41d0:1:6c23::1]) by smtp.gmail.com with ESMTPSA id o80sm1782687wmg.6.2017.11.29.09.28.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Nov 2017 09:28:28 -0800 (PST) From: Julien Grall To: star.zeng@intel.com, eric.dong@intel.com, pankaj.bansal@nxp.com, lersek@redhat.com, leif.lindholm@linaro.org Cc: edk2-devel@lists.01.org, Julien Grall Date: Wed, 29 Nov 2017 17:28:21 +0000 Message-Id: <20171129172823.2906-2-julien.grall@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171129172823.2906-1-julien.grall@linaro.org> References: <20171129172823.2906-1-julien.grall@linaro.org> Subject: [PATCH v3 1/3] MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for SetAttributes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 17:24:06 -0000 Per the UEFIv2.7 spec, EFI_DEVICE_ERROR is returned when the serial device is not functioning correctly. Update the description to avoid confusion. Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall Reviewed-by: Star Zeng --- Star, I found a prototype for SetAttributes in SerialIo.c as well and updated the description there. I decided to keep the Reviewed-by even with that change. Let me know whether it is fine for you. Changes in v3: - Modify description of EFI_DEVICE_ERROR above the prototypes for SetAttributes as well. - Add Star reviewed-by --- MdeModulePkg/Universal/SerialDxe/SerialIo.c | 4 ++-- MdePkg/Include/Protocol/SerialIo.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Universal/SerialDxe/SerialIo.c b/MdeModulePkg/Universal/SerialDxe/SerialIo.c index 964d0329f4..19fc889c25 100644 --- a/MdeModulePkg/Universal/SerialDxe/SerialIo.c +++ b/MdeModulePkg/Universal/SerialDxe/SerialIo.c @@ -67,7 +67,7 @@ SerialReset ( stop bits. @retval EFI_SUCCESS The device was reset. - @retval EFI_DEVICE_ERROR The serial device could not be reset. + @retval EFI_DEVICE_ERROR The serial device is not functioning correctly. **/ EFI_STATUS @@ -265,7 +265,7 @@ SerialReset ( stop bits. @retval EFI_SUCCESS The device was reset. - @retval EFI_DEVICE_ERROR The serial device could not be reset. + @retval EFI_DEVICE_ERROR The serial device is not functioning correctly. **/ EFI_STATUS diff --git a/MdePkg/Include/Protocol/SerialIo.h b/MdePkg/Include/Protocol/SerialIo.h index 31cd46614e..84cb34364d 100644 --- a/MdePkg/Include/Protocol/SerialIo.h +++ b/MdePkg/Include/Protocol/SerialIo.h @@ -126,7 +126,7 @@ EFI_STATUS stop bits. @retval EFI_SUCCESS The device was reset. - @retval EFI_DEVICE_ERROR The serial device could not be reset. + @retval EFI_DEVICE_ERROR The serial device is not functioning correctly. **/ typedef -- 2.11.0