From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 68FE621A1099A for ; Thu, 30 Nov 2017 02:24:26 -0800 (PST) Received: by mail-wr0-x243.google.com with SMTP id a41so4159834wra.6 for ; Thu, 30 Nov 2017 02:28:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YPOP/6iA71ejHew98hBHsnTW75j9BgG3yhYnzN3f5Tw=; b=Rz3XXOPbMxBLVdNX8VShjvudfFmoI5cp8dhf6L/HhV8njuphunXLtwliajC1MikuDf ujFkvBK7V39G/G3wWBpI6u4A71vSEZt83LMGYI6IYLvz2eESEAC5kksIl+SPy4Fqvw1X uTBBLUsqyXCvBYMo0UeEADfhLw+S/R8XW3J2s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YPOP/6iA71ejHew98hBHsnTW75j9BgG3yhYnzN3f5Tw=; b=ZM4HPGs8lcxj1BAzOKYMSMFUDINx3jYH0bqFFnhgSFZwkC30jv6hHsvat0PqdPAkqu nuHSEjiT1hhhTsAwZw0uOnVkr+6JK/vRXFWuxFz2gEOT3wJujaolvtBCS14BEc4tRLKc dbjpXyH5dOpPgEySWaaXNQoGdUFIi37Zz8hCeDrIwo8XHsKWudPH9giq7pJ/osn/uznX cWrrisZx7EaZsvjvCP2cy1K3Gs7bwowA2facUNf+sHo+cU8IYl3/Dap3vLzvqXGG4GRP fxSiR28eMRJmZXQUikHxKfmSt2B5X+AbnaL0K4laCulzQhDdP7bo30jwwTnnVOW/P98k 03qQ== X-Gm-Message-State: AJaThX4i0y/PWK85ws43I8+GUMXRJnbr9cvXhFBEZJa1CtvET2eSM/0/ cqDJJJUU9HEGhaXi8NfXKPeBPQ== X-Google-Smtp-Source: AGs4zMZAGAId7qZmXKdvUbNfKkcXxvcg/NzJVFXsAP4Wn5v4PHpSGzQR+/0ei+bOXPJw/a2/BWeHGA== X-Received: by 10.223.142.49 with SMTP id n46mr1459440wrb.279.1512037730066; Thu, 30 Nov 2017 02:28:50 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p17sm23232wma.23.2017.11.30.02.28.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Nov 2017 02:28:49 -0800 (PST) Date: Thu, 30 Nov 2017 10:28:47 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20171130102847.7alxdhev5a5wmefs@bivouac.eciton.net> References: <20171130102135.2343-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] EmbeddedPkg: remove nonexistent FLASH_DEFINITION from package .dsc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 10:24:26 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 30, 2017 at 10:22:42AM +0000, Ard Biesheuvel wrote: > On 30 November 2017 at 10:21, Leif Lindholm wrote: > > For whatever reason, EmbeddedPkg.dsc included a FLASH_DEFINITION entry > > pointing to a nonexistent EmbeddedPkg.fdf. > > > > This used to be silently ignored, but recent BaseTools changes > > 5e9256cd7f54 ("BaseTools: Guid.xref contain information from FILE statements in FDF") > > now caused builds against EmbeddedPkg.dsc to fail. > > So delete the redundant entry. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm > > Reviewed-by: Ard Biesheuvel Thanks! Pushed as 97eaeaa199. > > --- > > EmbeddedPkg/EmbeddedPkg.dsc | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc > > index 9ec24f7fa8..073a156884 100644 > > --- a/EmbeddedPkg/EmbeddedPkg.dsc > > +++ b/EmbeddedPkg/EmbeddedPkg.dsc > > @@ -30,7 +30,6 @@ [Defines] > > SUPPORTED_ARCHITECTURES = IA32|X64|IPF|ARM|AARCH64 > > BUILD_TARGETS = DEBUG|RELEASE > > SKUID_IDENTIFIER = DEFAULT > > - FLASH_DEFINITION = EmbeddedPkg/EmbeddedPkg.fdf > > > > > > ################################################################################ > > -- > > 2.11.0 > >