* [PATCH edk2-platforms] Platform/Hisilicon: drop BdsLib inclusion from HiKey .dsc
@ 2017-11-30 10:46 Leif Lindholm
2017-11-30 11:13 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2017-11-30 10:46 UTC (permalink / raw)
To: edk2-devel; +Cc: ard.biesheuvel
The ArmPkg BdsLib has been dropped from EDK2, and is no longer
required by the Android*Boot applications - so delete the
reference to fix the resulting build failure.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
Platform/Hisilicon/HiKey/HiKey.dsc | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
index 97811eb8d9..957e4d4a9e 100644
--- a/Platform/Hisilicon/HiKey/HiKey.dsc
+++ b/Platform/Hisilicon/HiKey/HiKey.dsc
@@ -411,10 +411,7 @@ [Components.common]
#
# Fastboot
#
- EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf {
- <LibraryClasses>
- BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf
- }
+ EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf
#
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH edk2-platforms] Platform/Hisilicon: drop BdsLib inclusion from HiKey .dsc
2017-11-30 10:46 [PATCH edk2-platforms] Platform/Hisilicon: drop BdsLib inclusion from HiKey .dsc Leif Lindholm
@ 2017-11-30 11:13 ` Ard Biesheuvel
2017-11-30 12:09 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2017-11-30 11:13 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel
> On 30 Nov 2017, at 10:46, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> The ArmPkg BdsLib has been dropped from EDK2, and is no longer
> required by the Android*Boot applications - so delete the
> reference to fix the resulting build failure.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> Platform/Hisilicon/HiKey/HiKey.dsc | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> index 97811eb8d9..957e4d4a9e 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> @@ -411,10 +411,7 @@ [Components.common]
> #
> # Fastboot
> #
> - EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf {
> - <LibraryClasses>
> - BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf
> - }
> + EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf
>
>
> #
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH edk2-platforms] Platform/Hisilicon: drop BdsLib inclusion from HiKey .dsc
2017-11-30 11:13 ` Ard Biesheuvel
@ 2017-11-30 12:09 ` Leif Lindholm
0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2017-11-30 12:09 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
On Thu, Nov 30, 2017 at 11:13:49AM +0000, Ard Biesheuvel wrote:
>
>
> > On 30 Nov 2017, at 10:46, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > The ArmPkg BdsLib has been dropped from EDK2, and is no longer
> > required by the Android*Boot applications - so delete the
> > reference to fix the resulting build failure.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks, pushed as 53a3ad49a9.
/
Leif
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-30 12:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-30 10:46 [PATCH edk2-platforms] Platform/Hisilicon: drop BdsLib inclusion from HiKey .dsc Leif Lindholm
2017-11-30 11:13 ` Ard Biesheuvel
2017-11-30 12:09 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox